Skip to contentSkip to conversation

get_maintainer: Emit longer section headers

PATCH New Joe Perches 1 participant 1 message Jun 17, 2015 GET_MAINTAINER script

lore
Share & tools
lore

Joe Perches

author maintainer
#0 lore raw

PATCH 1/1 get_maintainer: Emit longer section headers

Section headers can be quite long and some are very long and duplicated for many initial characters.

The current maximum length emitted for a section header is 20 bytes (or 17 bytes then ... when the section header length is > 20).

Change that length to 50 so more of the section is shown.

Example new output:

$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/broadcom/bnx2x/
Ariel Elior <[email protected]> (supporter:BROADCOM BNX2X 10 GIGABIT ETHERNET DRIVER)
[email protected] (open list:BROADCOM BNX2X 10 GIGABIT ETHERNET DRIVER)
[email protected] (open list)

Old:

$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/broadcom/bnx2x/
Ariel Elior <[email protected]> (supporter:BROADCOM BNX2X 10...)
[email protected] (open list:BROADCOM BNX2X 10...)
[email protected] (open list)
---
 scripts/get_maintainer.pl | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
scripts/get_maintainer.pl +5 -4
index fc169fd..cffa658 100755
@@ -42,6 +42,7 @@ my $output_multiline = 1;
 my $output_separator = ", ";
 my $output_roles = 0;
 my $output_rolestats = 1;
+my $output_section_maxlen = 50;
 my $scm = 0;
 my $web = 0;
 my $subsystem = 0;
@@ -978,8 +979,8 @@ sub get_maintainer_role {
 
     my $role = "unknown";
     my $subsystem = $typevalue[$start];
-    if (length($subsystem) > 20) {
-	$subsystem = substr($subsystem, 0, 17);
+    if ($output_section_maxlen && length($subsystem) > $output_section_maxlen) {
+	$subsystem = substr($subsystem, 0, $output_section_maxlen - 3);
 	$subsystem =~ s/\s*$//;
 	$subsystem = $subsystem . "...";
     }
@@ -1021,8 +1022,8 @@ sub get_list_role {
     my $end = find_ending_index($index);
 
     my $subsystem = $typevalue[$start];
-    if (length($subsystem) > 20) {
-	$subsystem = substr($subsystem, 0, 17);
+    if ($output_section_maxlen && length($subsystem) > $output_section_maxlen) {
+	$subsystem = substr($subsystem, 0, $output_section_maxlen - 3);
 	$subsystem =~ s/\s*$//;
 	$subsystem = $subsystem . "...";
     }