Skip to contentSkip to conversation

cxl: Fix typo in debug print

PATCH In review Michael Neuling 3 participants 4 messages Jun 18, 2015 Char and misc drivers

lore
Share & tools
lore

Michael Neuling

author
#0 lore raw

PATCH 1/1 cxl: Fix typo in debug print

Fix typo in debug print. p1->p2. No functional change.

Signed-off-by Michael Neuling <[email protected]>
drivers/misc/cxl/pci.c +1 -1
index 1ef0164..8515791 100644
@@ -204,7 +204,7 @@ static void dump_cxl_config_space(struct pci_dev *dev)
 	dev_info(&dev->dev, "p1 regs: %#llx, len: %#llx\n",
 		p1_base(dev), p1_size(dev));
 	dev_info(&dev->dev, "p2 regs: %#llx, len: %#llx\n",
-		p1_base(dev), p2_size(dev));
+		p2_base(dev), p2_size(dev));
 	dev_info(&dev->dev, "BAR 4/5: %#llx, len: %#llx\n",
 		pci_resource_start(dev, 4), pci_resource_len(dev, 4));

=20

#2 lore raw
In reply to Michael Neuling
Quoted 1 line · Michael Neuling

Fix typo in debug print. p1->p2. No functional change.

That's not "no functional change", it changes the behaviour, unless p2_base() implements the same logic as p1_base()?

cheers

Quoted 15 lines
drivers/misc/cxl/pci.c +1 -1
index 1ef0164..8515791 100644
@@ -204,7 +204,7 @@ static void dump_cxl_config_space(struct pci_dev *dev)
 	dev_info(&dev->dev, "p1 regs: %#llx, len: %#llx\n",
 		p1_base(dev), p1_size(dev));
 	dev_info(&dev->dev, "p2 regs: %#llx, len: %#llx\n",
-		p1_base(dev), p2_size(dev));
+		p2_base(dev), p2_size(dev));
 	dev_info(&dev->dev, "BAR 4/5: %#llx, len: %#llx\n",
 		pci_resource_start(dev, 4), pci_resource_len(dev, 4));
author
#3 lore raw
Quoted 4 lines · Michael Ellerman
Quoted 1 line · Michael Neuling

Fix typo in debug print. p1->p2. No functional change.

=20
That's not "no functional change", it changes the behaviour, unless p2_ba=

se()

Quoted 1 line

implements the same logic as p1_base()?

Maybe I should change it to "Only debug output printing change"?

Mikey

Quoted 8 lines

=20
cheers
=20

drivers/misc/cxl/pci.c static void dump_cxl_config_space(struct pci_dev *d=

Quoted 5 lines
drivers/misc/cxl/pci.c +0 -0
index 1ef0164..8515791 100644
@@ -204,7 +204,7 @@ static void dump_cxl_config_space(struct pci_dev *d=

ev)

Quoted 14 lines
Quoted 10 lines
drivers/misc/cxl/pci.c +1 -1
 	dev_info(&dev->dev, "p1 regs: %#llx, len: %#llx\n",
 		p1_base(dev), p1_size(dev));
 	dev_info(&dev->dev, "p2 regs: %#llx, len: %#llx\n",
-		p1_base(dev), p2_size(dev));
+		p2_base(dev), p2_size(dev));
 	dev_info(&dev->dev, "BAR 4/5: %#llx, len: %#llx\n",
 		pci_resource_start(dev, 4), pci_resource_len(dev, 4));

=20
=20
=20

=20
=20
=20
=20