Skip to contentSkip to conversation

iommu/amd: Handle large pages correctly in free_pagetable

PATCH New Joerg Roedel 1 participant 1 message Jun 18, 2015 IOMMU

lore
Share & tools
lore

Joerg Roedel

author maintainer
#0 lore raw

PATCH 1/1 iommu/amd: Handle large pages correctly in free_pagetable

From: Joerg Roedel <[email protected]>

Make sure that we are skipping over large PTEs while walking the page-table tree.

Fixes 5c34c403b723 ("iommu/amd: Fix memory leak in free_pagetable")
---
 drivers/iommu/amd_iommu.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/iommu/amd_iommu.c +6 -0
index 79892d2..45532ff 100644
@@ -1749,9 +1749,15 @@ static void free_pt_##LVL (unsigned long __pt)			\
 	pt = (u64 *)__pt;					\
 								\
 	for (i = 0; i < 512; ++i) {				\
+		/* PTE present? */				\
 		if (!IOMMU_PTE_PRESENT(pt[i]))			\
 			continue;				\
 								\
+		/* Large PTE? */				\
+		if (IOMMU_PTE_MODE(pt[i]) == 0 ||		\
+		    IOMMU_PTE_MODE(pt[i]) == 7)			\
+			continue;				\
+								\
 		p = (unsigned long)IOMMU_PTE_PAGE(pt[i]);	\
 		FN(p);						\
 	}							\
Signature · 1 line
1.9.1