Skip to contentSkip to conversation

drm/dp: cancel any work on disconnect

PATCH In review Dave Airlie 1 participant 2 messages Jun 19, 2015

Subsystems (2)
lore
Share & tools
lore

Dave Airlie

author maintainer
#0 lore raw

PATCH 1/1 drm/dp: cancel any work on disconnect

From: Dave Airlie <[email protected]>

Since we might have queued work but it hasn't executed yet this could cause an oops in drm_dp_check_and_send_link_address.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89366

---
 drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/drm_dp_mst_topology.c +2 -0
index fb65f5d..7678cb5 100644
@@ -1936,6 +1936,8 @@ int drm_dp_mst_topology_mgr_set_mst(struct drm_dp_mst_topology_mgr *mgr, bool ms
 
 		ret = 0;
 	} else {
+		/* flush any pending work */
+		cancel_work_sync(&mgr->work);
 		/* disable MST on the device */
 		mstb = mgr->mst_primary;
 		mgr->mst_primary = NULL;
Signature · 6 lines
2.4.1

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
author maintainer
#1 lore raw
Quoted 6 lines · Dave Airlie

From: Dave Airlie <[email protected]>

Since we might have queued work but it hasn't executed yet this could cause an oops in drm_dp_check_and_send_link_address.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89366

Ignore this, it was lockdeppy.

the other fix is better.

Dave.
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel