Skip to contentSkip to conversation

Patch "Input: alps - do not reduce trackpoint speed by half" has been added to the 4.0-stable tree

PATCH [email protected] 1 participant 1 message Jun 19, 2015

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

Input: alps - do not reduce trackpoint speed by half

to the 4.0-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
input-alps-do-not-reduce-trackpoint-speed-by-half.patch
and it can be found in the queue-4.0 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 088df2ccef75754cc16a6ba31829d23bcb2b68ed Mon Sep 17 00:00:00 2001

From: Hans de Goede <[email protected]>
Date: Thu, 4 Jun 2015 22:31:43 -0700
Subject: Input: alps - do not reduce trackpoint speed by half

From: Hans de Goede <[email protected]>

commit 088df2ccef75754cc16a6ba31829d23bcb2b68ed upstream.

On some v7 devices (e.g. Lenovo-E550) the deltas reported are typically only in the 0-1 range dividing this by 2 results in a range of 0-0.

And even for v7 devices where this does not lead to making the trackstick entirely unusable, it makes it twice as slow as before we added v7 support and were using the ps/2 mouse emulation of the dual point setup.

If some kind of generic slowdown is actually necessary for some devices, then that belongs in userspace, not in the kernel.

---
 drivers/input/mouse/alps.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/input/mouse/alps.c +2 -3
@@ -1042,9 +1042,8 @@ static void alps_process_trackstick_pack
 	right = (packet[1] & 0x02) >> 1;
 	middle = (packet[1] & 0x04) >> 2;
 
-	/* Divide 2 since trackpoint's speed is too fast */
-	input_report_rel(dev2, REL_X, (char)x / 2);
-	input_report_rel(dev2, REL_Y, -((char)y / 2));
+	input_report_rel(dev2, REL_X, (char)x);
+	input_report_rel(dev2, REL_Y, -((char)y));
 
 	input_report_key(dev2, BTN_LEFT, left);
 	input_report_key(dev2, BTN_RIGHT, right);

Patches currently in stable-queue which might be from [email protected] are

queue-4.0/input-elantech-fix-detection-of-touchpads-where-the-revision-matches-a-known-rate.patch queue-4.0/input-alps-do-not-reduce-trackpoint-speed-by-half.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in