Skip to contentSkip to conversation

Patch "md: don't return 0 from array_state_store" has been added to the 4.0-stable tree

PATCH [email protected] 1 participant 1 message Jun 19, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

md: don't return 0 from array_state_store

to the 4.0-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
md-don-t-return-0-from-array_state_store.patch
and it can be found in the queue-4.0 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From c008f1d356277a5b7561040596a073d87e56b0c8 Mon Sep 17 00:00:00 2001

From: NeilBrown <[email protected]>
Date: Fri, 12 Jun 2015 19:46:44 +1000
Subject: md: don't return 0 from array_state_store

From: NeilBrown <[email protected]>

commit c008f1d356277a5b7561040596a073d87e56b0c8 upstream.

Returning zero from a 'store' function is bad. The return value should be either len length of the string or an error.

So use 'len' if 'err' is zero.

Fixes 6791875e2e53 ("md: make reconfig_mutex optional for writes to md sysfs files.")
---
 drivers/md/md.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/md/md.c +1 -1
@@ -3765,7 +3765,7 @@ array_state_store(struct mddev *mddev, c
 				err = -EBUSY;
 		}
 		spin_unlock(&mddev->lock);
-		return err;
+		return err ?: len;
 	}
 	err = mddev_lock(mddev);
 	if (err)

Patches currently in stable-queue which might be from [email protected] are

queue-4.0/md-close-race-when-setting-action-to-idle.patch queue-4.0/md-don-t-return-0-from-array_state_store.patch queue-4.0/block-fix-ext_dev_lock-lockdep-report.patch queue-4.0/block-discard-bdi_unregister-in-favour-of-bdi_destroy.patch queue-4.0/blk-mq-free-hctx-ctxs-in-queue-s-release-handler.patch --
To unsubscribe from this list: send the line "unsubscribe stable" in