mfd: fix dependency warning for CHROME_PLATFORMS on !X86, !ARM
PATCH 1/1 mfd: fix dependency warning for CHROME_PLATFORMS on !X86, !ARM
In commit 062476f24aa7cf714169342cc50626fd9bbb93da ("mfd: cros_ec:
Move protocol helpers out of the MFD driver") there was a select added on CHROME_PLATFORMS, which leads to the following for ppc/mips:
warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies (X86 || ARM)
Presumably the above means MFD_CROS_EC is only currently useful on x86 and ARM, so lets limit it to there.
--- drivers/mfd/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/mfd/Kconfig +1 -0
@@ -94,6 +94,7 @@ config MFD_AXP20X config MFD_CROS_EC tristate "ChromeOS Embedded Controller" + depends on X86 || ARM select MFD_CORE select CHROME_PLATFORMS select CROS_EC_PROTO
Signature · 5 lines
2.2.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/
Hello Paul,
Quoted 7 lines · Paul Gortmaker
In commit
062476f24aa7cf714169342cc50626fd9bbb93da("mfd:cros_ec:
Move protocol helpers out of the MFD driver") there was a select added onCHROME_PLATFORMS, which leads to the following for ppc/mips:warning: (
MFD_CROS_EC) selectsCHROME_PLATFORMSwhich has unmet direct dependencies (X86 || ARM)
Right, sorry for missing that and thank a lot for taking care of it.
Quoted 3 lines
Presumably the above means
MFD_CROS_ECis only currently useful on x86 and ARM, so lets limit it to there.
That is correct, although I wonder if CHROME_PLATFORMS should not also depend on || COMPILE_TEST and same for MFD_CROS_EC so those have at least build coverage on other architectures.
I can't think for a reason to not be buildable on other archs...
Quoted 16 lines
Cc Lee Jones <[email protected]>Cc Javier Martinez Canillas <[email protected]>Cc Heiko Stuebner <[email protected]>Cc Olof Johansson <[email protected]>Cc Samuel Ortiz <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>--- drivers/mfd/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/mfd/Kconfig +0
-0
drivers/mfd/Kconfig config MFD_AXP20X · line 100
Quoted 7 lines
drivers/mfd/Kconfig +1
-0@@ -94,6 +94,7 @@ config MFD_AXP20X config MFD_CROS_EC tristate "ChromeOS Embedded Controller" + depends on X86 || ARM select MFD_CORE select CHROME_PLATFORMS select CROS_EC_PROTO
...but that is orthogonal to this patch so:
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/
Quoted 17 lines · Javier Martinez Canillas
Hello Paul,
Quoted 7 lines · Paul Gortmaker
In commit
062476f24aa7cf714169342cc50626fd9bbb93da("mfd:cros_ec:
Move protocol helpers out of the MFD driver") there was a select added onCHROME_PLATFORMS, which leads to the following for ppc/mips:warning: (
MFD_CROS_EC) selectsCHROME_PLATFORMSwhich has unmet direct dependencies (X86 || ARM)Right, sorry for missing that and thank a lot for taking care of it.
Quoted 3 lines
Presumably the above means
MFD_CROS_ECis only currently useful on x86 and ARM, so lets limit it to there.
Quoted 5 lines
That is correct, although I wonder if
CHROME_PLATFORMSshould not also depend on ||COMPILE_TESTand same forMFD_CROS_ECso those have at least build coverage on other architectures.I can't think for a reason to not be buildable on other archs...
Right. Will you fix that Javier?
Quoted 30 lines
Quoted 16 lines
Cc Lee Jones <[email protected]>Cc Javier Martinez Canillas <[email protected]>Cc Heiko Stuebner <[email protected]>Cc Olof Johansson <[email protected]>Cc Samuel Ortiz <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>--- drivers/mfd/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/mfd/Kconfig +0
-0drivers/mfd/Kconfig config MFD_AXP20X · line 100
Quoted 7 lines
drivers/mfd/Kconfig +1
-0@@ -94,6 +94,7 @@ config MFD_AXP20X config MFD_CROS_EC tristate "ChromeOS Embedded Controller" + depends on X86 || ARM select MFD_CORE select CHROME_PLATFORMS select CROS_EC_PROTO...but that is orthogonal to this patch so:
Best regards,
Javier
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Am Mittwoch, 24. Juni 2015, 15:17:50 schrieb Lee Jones:
Quoted 16 lines · Javier Martinez Canillas
Quoted 15 lines
Hello Paul,
Quoted 6 lines · Paul Gortmaker
In commit
062476f24aa7cf714169342cc50626fd9bbb93da("mfd:cros_ec:
Move protocol helpers out of the MFD driver") there was a select added onCHROME_PLATFORMS, which leads to the following for ppc/mips:warning: (
MFD_CROS_EC) selectsCHROME_PLATFORMSwhich has unmet direct dependencies (X86 || ARM)Right, sorry for missing that and thank a lot for taking care of it.
Quoted 2 lines
Presumably the above means
MFD_CROS_ECis only currently useful on x86 and ARM, so lets limit it to there.
Quoted 7 lines
Quoted 5 lines
That is correct, although I wonder if
CHROME_PLATFORMSshould not also depend on ||COMPILE_TESTand same forMFD_CROS_ECso those have at least build coverage on other architectures.I can't think for a reason to not be buildable on other archs...
Right. Will you fix that Javier?
looking at the ChromeOS kernel tree (3.18 / oak) it looks like ARM64 might also be a nice addition to this list, but I'm not sure if there are more ec changes involved.
Quoted 25 lines · Heiko Stübner
Am Mittwoch, 24. Juni 2015, 15:17:50 schrieb Lee Jones:
Quoted 23 lines · Javier Martinez Canillas
Quoted 12 lines
Hello Paul,
Quoted 6 lines · Paul Gortmaker
In commit
062476f24aa7cf714169342cc50626fd9bbb93da("mfd:cros_ec:
Move protocol helpers out of the MFD driver") there was a select added onCHROME_PLATFORMS, which leads to the following for ppc/mips:warning: (
MFD_CROS_EC) selectsCHROME_PLATFORMSwhich has unmet direct dependencies (X86 || ARM)Right, sorry for missing that and thank a lot for taking care of it.
Quoted 8 lines
Quoted 2 lines
Presumably the above means
MFD_CROS_ECis only currently useful on x86 and ARM, so lets limit it to there.That is correct, although I wonder if
CHROME_PLATFORMSshould not also depend on ||COMPILE_TESTand same forMFD_CROS_ECso those have at least build coverage on other architectures.I can't think for a reason to not be buildable on other archs...
Right. Will you fix that Javier?
Yes, I was waiting to see if Paul agreed and wanted to re-spin his patches or if anyone else had other opinions.
Quoted 4 lines
looking at the ChromeOS kernel tree (3.18 / oak) it looks like ARM64 might also be a nice addition to this list, but I'm not sure if there are more ec changes involved.
Right, on a second thought I wonder if having CHROME_PLATFORMS depends on depends on X86 || ARM even makes sense. I see that the individual drivers already depend on a certain architecture. i.e: CROS_EC_LPC on x86 because LPC is only found on x86, etc.
So maybe we can just remove the constrain from CHROME_PLATFORMS and let it be selected on all architectures if someone choose to.
I'll double check and post a patch on top of Paul's tomorrow.
Best regards,
Javier
Lee Jones
AppliedQuoted 16 lines · Paul Gortmaker
In commit
062476f24aa7cf714169342cc50626fd9bbb93da("mfd:cros_ec:
Move protocol helpers out of the MFD driver") there was a select added onCHROME_PLATFORMS, which leads to the following for ppc/mips:warning: (
MFD_CROS_EC) selectsCHROME_PLATFORMSwhich has unmet direct dependencies (X86 || ARM)Presumably the above means
MFD_CROS_ECis only currently useful on x86 and ARM, so lets limit it to there.Cc Lee Jones <[email protected]>Cc Javier Martinez Canillas <[email protected]>Cc Heiko Stuebner <[email protected]>Cc Olof Johansson <[email protected]>Cc Samuel Ortiz <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>
Quoted 3 lines
--- drivers/mfd/Kconfig | 1 + 1 file changed, 1 insertion(+)
Applied, thanks.
Quoted 12 lines
drivers/mfd/Kconfig +1
-0@@ -94,6 +94,7 @@ config MFD_AXP20X config MFD_CROS_EC tristate "ChromeOS Embedded Controller" + depends on X86 || ARM select MFD_CORE select CHROME_PLATFORMS select CROS_EC_PROTO
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog