Skip to contentSkip to conversation

ocfs2:Make the function ocfs2_initxattrs static

PATCH In review Nicholas Krause 2 participants 2 messages Jun 23, 2015 – Jun 24, 2015 OCFS2

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ocfs2:Make the function ocfs2_initxattrs static

This makes the function ocfs2_initxattrs static now due to this function's only caller being in its own declaration and definition file of xattr.c.

---
 fs/ocfs2/xattr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ocfs2/xattr.c +1 -1
index d03bfbf..889f379 100644
@@ -7271,7 +7271,7 @@ static int ocfs2_xattr_security_set(struct dentry *dentry, const char *name,
 			       name, value, size, flags);
 }
 
-int ocfs2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
+static int ocfs2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
 		     void *fs_info)
 {
 	const struct xattr *xattr;
Signature · 1 line
2.1.4
#1 lore raw

Hi Nicholas,
It has already been staged as a part of the patch "ocfs2: mark local functions as static" in the -mm tree.
Thanks all the same.

--
Joseph

Quoted 23 lines · Nicholas Krause

This makes the function ocfs2_initxattrs static now due to this function's only caller being in its own declaration and definition file of xattr.c.

---
 fs/ocfs2/xattr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ocfs2/xattr.c +1 -1
index d03bfbf..889f379 100644
@@ -7271,7 +7271,7 @@ static int ocfs2_xattr_security_set(struct dentry *dentry, const char *name,
 			       name, value, size, flags);
 }
 
-int ocfs2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
+static int ocfs2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
 		     void *fs_info)
 {
 	const struct xattr *xattr;