Skip to contentSkip to conversation

OSSTest: some more info when capturing logs

PATCH In review Dario Faggioli 2 participants 4 messages Jun 24, 2015 – Jun 25, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 OSSTest: some more info when capturing logs

more specifically:

* '-n' switch to xl info, to show the topology
of the host,
* 'xl vcpu-list', to show what the various vcpus
are up to.

---
 ts-logs-capture |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
ts-logs-capture +2 -1
index 2078459..2498416 100755
@@ -153,9 +153,10 @@ sub fetch_logs_host_guests () {
 
     foreach my $cmd
         (
-         'xl info',
+         'xl info -n',
          'cat /proc/cpuinfo',
          'xl list',
+         'xl vcpu-list',
          'xm list',
          'xm list --long',
          'xenstore-ls -fp',
Signature · 4 lines
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

#1 lore raw
Quoted 4 lines · Dario Faggioli

more specifically:

* '-n' switch to xl info, to show the topology
of the host,

Is the information from "xl info -n" a superset of that from "xl info"? IOW could we just collect xl info -n and be done with it?

Quoted 25 lines

* 'xl vcpu-list', to show what the various vcpus
are up to.

---
 ts-logs-capture |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
ts-logs-capture +2 -1
index 2078459..2498416 100755
@@ -153,9 +153,10 @@ sub fetch_logs_host_guests () {
 
     foreach my $cmd
         (
-         'xl info',
+         'xl info -n',
          'cat /proc/cpuinfo',
          'xl list',
+         'xl vcpu-list',
          'xm list',
          'xm list --long',
          'xenstore-ls -fp',
#2 lore raw
Quoted 8 lines · Ian Campbell
Quoted 4 lines · Dario Faggioli

more specifically:

* '-n' switch to xl info, to show the topology
of the host,

Is the information from "xl info -n" a superset of that from "xl info"?

Yes.

Quoted 2 lines

IOW could we just collect xl info -n and be done with it?

That's what the patch is doing:

Quoted 7 lines

ts-logs-capture sub fetch_logs_host_guests () { · line 156

Quoted 6 lines
ts-logs-capture +1 -1
@@ -153,9 +153,10 @@ sub fetch_logs_host_guests () {
 
     foreach my $cmd
         (
-         'xl info',
+         'xl info -n',

Perhaps the changelog was not so clear... in this case, "more info" applies right because adding '-n' adds information, wrt not using it, or at least that was what I meant.

Should I clarify and resend?

Dario

Signature · 4 lines
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

Acked-by
#3 lore raw
Quoted 22 lines · Dario Faggioli
Quoted 8 lines · Ian Campbell
Quoted 4 lines · Dario Faggioli

more specifically:

* '-n' switch to xl info, to show the topology
of the host,

Is the information from "xl info -n" a superset of that from "xl info"?

Yes.

Quoted 2 lines

IOW could we just collect xl info -n and be done with it?

That's what the patch is doing:

Quoted 7 lines

ts-logs-capture sub fetch_logs_host_guests () { · line 156

Quoted 6 lines
ts-logs-capture +1 -1
@@ -153,9 +153,10 @@ sub fetch_logs_host_guests () {
 
     foreach my $cmd
         (
-         'xl info',
+         'xl info -n',
Quoted 5 lines

Perhaps the changelog was not so clear... in this case, "more info" applies right because adding '-n' adds information, wrt not using it, or at least that was what I meant.

Should I clarify and resend?

No need, I should just learn to read a diff properly, sorry.