Skip to contentSkip to conversation

Crystalcove (CRC) PMIC based panel and pwm control

PATCH In review Shobhit Kumar 8 participants 18 messages Jun 26, 2015 – Jul 21, 2015

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

v3 cover Crystalcove (CRC) PMIC based panel and pwm control

Hi,
Next update of the series reviewed at
https://lkml.org/lkml/2015/6/22/155

Major changes are few review comments from Varka and Ville being addressed. Also except for intel-gfx patches, all patches reviesion history is moved out of commit message.

Hope this series finally finds its mark.

Regards
Shobhit

Shobhit Kumar (7):
gpiolib: Add support for removing registered consumer lookup table
mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO
signal
mfd: intel_soc_pmic_crc: Add PWM cell device for Crystalcove PMIC
mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM
pwm: crc: Add Crystalcove (CRC) PWM driver
drm/i915: Use the CRC gpio for panel enable/disable drm/i915: Backlight control using CRC PMIC based PWM driver

 drivers/gpio/gpiolib.c             |  13 ++++
 drivers/gpu/drm/i915/intel_bios.h  |   7 ++
 drivers/gpu/drm/i915/intel_drv.h   |   4 ++
 drivers/gpu/drm/i915/intel_dsi.c   |  37 +++++++++-
 drivers/gpu/drm/i915/intel_dsi.h   |   3 +
 drivers/gpu/drm/i915/intel_panel.c |  94 ++++++++++++++++++++++--
 drivers/mfd/intel_soc_pmic_core.c  |  29 ++++++++
 drivers/mfd/intel_soc_pmic_crc.c   |   3 +
 drivers/pwm/Kconfig                |   7 ++
 drivers/pwm/Makefile               |   1 +
 drivers/pwm/pwm-crc.c              | 143 +++++++++++++++++++++++++++++++++++++
 include/linux/gpio/machine.h       |   1 +
 12 files changed, 335 insertions(+), 7 deletions(-)
 create mode 100644 drivers/pwm/pwm-crc.c
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH v3 1/7 gpiolib: Add support for removing registered consumer lookup table

In case we unload and load a driver module again that is registering a lookup table, without this it will result in multiple entries. Provide an option to remove the lookup table on driver unload

---
v2: Ccing maintainers
v3: Correct the subject line (Lee jones)

 drivers/gpio/gpiolib.c       | 13 +++++++++++++
 include/linux/gpio/machine.h |  1 +
 2 files changed, 14 insertions(+)
drivers/gpio/gpiolib.c +13 -0
index 957ede5..9d3ea4e 100644
@@ -1675,6 +1675,19 @@ void gpiod_add_lookup_table(struct gpiod_lookup_table *table)
 	mutex_unlock(&gpio_lookup_lock);
 }
 
+/**
+ * gpiod_remove_lookup_table() - unregister GPIO device consumers
+ * @table: table of consumers to unregister
+ */
+void gpiod_remove_lookup_table(struct gpiod_lookup_table *table)
+{
+	mutex_lock(&gpio_lookup_lock);
+
+	list_del(&table->list);
+
+	mutex_unlock(&gpio_lookup_lock);
+}
+
 static struct gpio_desc *of_find_gpio(struct device *dev, const char *con_id,
 				      unsigned int idx,
 				      enum gpio_lookup_flags *flags)
include/linux/gpio/machine.h +1 -0
index e270614..c0d712d 100644
@@ -57,5 +57,6 @@ struct gpiod_lookup_table {
 }
 
 void gpiod_add_lookup_table(struct gpiod_lookup_table *table);
+void gpiod_remove_lookup_table(struct gpiod_lookup_table *table);
 
 #endif /* __LINUX_GPIO_MACHINE_H */
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Acked-by on v3 1/7
#2 lore raw

Re: [v3 1/7] gpiolib: Add support for removing registered consumer lookup table

Quoted 12 lines · Shobhit Kumar

In case we unload and load a driver module again that is registering a lookup table, without this it will result in multiple entries. Provide an option to remove the lookup table on driver unload

Quoted 3 lines

---
v2: Ccing maintainers
v3: Correct the subject line (Lee jones)

Quoted 39 lines
 drivers/gpio/gpiolib.c       | 13 +++++++++++++
 include/linux/gpio/machine.h |  1 +
 2 files changed, 14 insertions(+)
drivers/gpio/gpiolib.c +13 -0
index 957ede5..9d3ea4e 100644
@@ -1675,6 +1675,19 @@ void gpiod_add_lookup_table(struct gpiod_lookup_table *table)
 	mutex_unlock(&gpio_lookup_lock);
 }
 
+/**
+ * gpiod_remove_lookup_table() - unregister GPIO device consumers
+ * @table: table of consumers to unregister
+ */
+void gpiod_remove_lookup_table(struct gpiod_lookup_table *table)
+{
+	mutex_lock(&gpio_lookup_lock);
+
+	list_del(&table->list);
+
+	mutex_unlock(&gpio_lookup_lock);
+}
+
 static struct gpio_desc *of_find_gpio(struct device *dev, const char *con_id,
 				      unsigned int idx,
 				      enum gpio_lookup_flags *flags)
include/linux/gpio/machine.h +1 -0
index e270614..c0d712d 100644
@@ -57,5 +57,6 @@ struct gpiod_lookup_table {
 }
 
 void gpiod_add_lookup_table(struct gpiod_lookup_table *table);
+void gpiod_remove_lookup_table(struct gpiod_lookup_table *table);
 
 #endif /* __LINUX_GPIO_MACHINE_H */
Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#3 lore raw

PATCH v3 2/7 mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal

In reply to Shobhit Kumar

On some Intel SoC platforms, the panel enable/disable signals are controlled by CRC PMIC. Add those control as a new GPIO in a lookup table for gpio-crystalcove chip during CRC driver load

---
v2: Make the lookup table static (Thierry)
Remove the lookup table during driver remove (Thierry)

v3: Correct the subject line (Lee jones)

 drivers/mfd/intel_soc_pmic_core.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
drivers/mfd/intel_soc_pmic_core.c +17 -0
index 7b50b6b..f3d918e 100644
@@ -24,8 +24,19 @@
 #include <linux/acpi.h>
 #include <linux/regmap.h>
 #include <linux/mfd/intel_soc_pmic.h>
+#include <linux/gpio/machine.h>
 #include "intel_soc_pmic_core.h"
 
+/* Lookup table for the Panel Enable/Disable line as GPIO signals */
+static struct gpiod_lookup_table panel_gpio_table = {
+	/* Intel GFX is consumer */
+	.dev_id = "0000:00:02.0",
+	.table = {
+		/* Panel EN/DISABLE */
+		GPIO_LOOKUP("gpio_crystalcove", 94, "panel", GPIO_ACTIVE_HIGH),
+	},
+};
+
 static int intel_soc_pmic_find_gpio_irq(struct device *dev)
 {
 	struct gpio_desc *desc;
@@ -85,6 +96,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c,
 	if (ret)
 		dev_warn(dev, "Can't enable IRQ as wake source: %d\n", ret);
 
+	/* Add lookup table binding for Panel Control to the GPIO Chip */
+	gpiod_add_lookup_table(&panel_gpio_table);
+
 	ret = mfd_add_devices(dev, -1, config->cell_dev,
 			      config->n_cell_devs, NULL, 0,
 			      regmap_irq_get_domain(pmic->irq_chip_data));
@@ -104,6 +118,9 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c)
 
 	regmap_del_irq_chip(pmic->irq, pmic->irq_chip_data);
 
+	/* Remove lookup table for Panel Control from the GPIO Chip */
+	gpiod_remove_lookup_table(&panel_gpio_table);
+
 	mfd_remove_devices(&i2c->dev);
 
 	return 0;
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw

PATCH v3 3/7 mfd: intel_soc_pmic_crc: Add PWM cell device for Crystalcove PMIC

In reply to Shobhit Kumar

Needed for PWM control suuported by the PMIC

---
v2: Correct the subject line (Lee jones)

 drivers/mfd/intel_soc_pmic_crc.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mfd/intel_soc_pmic_crc.c +3 -0
index 7436075..4a74948 100644
@@ -109,6 +109,9 @@ static struct mfd_cell crystal_cove_dev[] = {
 	{
 		.name = "crystal_cove_pmic",
 	},
+	{
+		.name = "crystal_cove_pwm",
+	},
 };
 
 static const struct regmap_config crystal_cove_regmap_config = {
Signature · 1 line
1.9.1
#5 lore raw

PATCH v3 4/7 mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM

In reply to Shobhit Kumar

On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup entry for the same to be used by the consumer (Intel GFX)

---
v2: Remove the lookup table on driver unload (Thierry)

v3: Correct the subject line (Lee jones)

 drivers/mfd/intel_soc_pmic_core.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
drivers/mfd/intel_soc_pmic_core.c +12 -0
index f3d918e..a00ddd9 100644
@@ -25,6 +25,7 @@
 #include <linux/regmap.h>
 #include <linux/mfd/intel_soc_pmic.h>
 #include <linux/gpio/machine.h>
+#include <linux/pwm.h>
 #include "intel_soc_pmic_core.h"
 
 /* Lookup table for the Panel Enable/Disable line as GPIO signals */
@@ -37,6 +38,11 @@ static struct gpiod_lookup_table panel_gpio_table = {
 	},
 };
 
+/* PWM consumed by the Intel GFX */
+static struct pwm_lookup crc_pwm_lookup[] = {
+	PWM_LOOKUP("crystal_cove_pwm", 0, "0000:00:02.0", "pwm_backlight", 0, PWM_POLARITY_NORMAL),
+};
+
 static int intel_soc_pmic_find_gpio_irq(struct device *dev)
 {
 	struct gpio_desc *desc;
@@ -99,6 +105,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c,
 	/* Add lookup table binding for Panel Control to the GPIO Chip */
 	gpiod_add_lookup_table(&panel_gpio_table);
 
+	/* Add lookup table for crc-pwm */
+	pwm_add_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup));
+
 	ret = mfd_add_devices(dev, -1, config->cell_dev,
 			      config->n_cell_devs, NULL, 0,
 			      regmap_irq_get_domain(pmic->irq_chip_data));
@@ -121,6 +130,9 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c)
 	/* Remove lookup table for Panel Control from the GPIO Chip */
 	gpiod_remove_lookup_table(&panel_gpio_table);
 
+	/* remove crc-pwm lookup table */
+	pwm_remove_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup));
+
 	mfd_remove_devices(&i2c->dev);
 
 	return 0;
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#6 lore raw

PATCH v3 5/7 pwm: crc: Add Crystalcove (CRC) PWM driver

In reply to Shobhit Kumar

The Crystalcove PMIC provides three PWM signals and this driver exports one of them on the BYT platform which is used to control backlight for DSI panel. This is platform device implementation of the drivers/mfd cell device for CRC PMIC.

CC Samuel Ortiz <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Alexandre Courbot <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Paul Bolle <[email protected]>
Cc Paul Gortmaker <[email protected]>

---
v2: Use the existing config callback with duty_ns and period_ns(Thierry)

v3: Correct the subject line (Lee jones)

v4: Address comment by Thierry & Paul
- Commit message update and fixes for few syntax errors
- Add PWM_CRC in Kconfig and Makefile sorted alphabetically
- Use the PWM_BASE_CLK as 6000000 for better code readability
- Remove the redundant rule of three while calculating pwm level
- Use the platform_device in pwm_chip
- Use builin_platform_driver

v5: Address comments by Varka
- Make the bit definition using BIT macro
- reorder probe and remove code to directly return from pwmchip_add/remove

 drivers/pwm/Kconfig   |   7 +++
 drivers/pwm/Makefile  |   1 +
 drivers/pwm/pwm-crc.c | 143 ++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 151 insertions(+)
 create mode 100644 drivers/pwm/pwm-crc.c
drivers/pwm/Kconfig +7 -0
index b1541f4..948d9ab 100644
@@ -111,6 +111,13 @@ config PWM_CLPS711X
 	  To compile this driver as a module, choose M here: the module
 	  will be called pwm-clps711x.
 
+config PWM_CRC
+	bool "Intel Crystalcove (CRC) PWM support"
+	depends on X86 && INTEL_SOC_PMIC
+	help
+	  Generic PWM framework driver for Crystalcove (CRC) PMIC based PWM
+	  control.
+
 config PWM_EP93XX
 	tristate "Cirrus Logic EP93xx PWM support"
 	depends on ARCH_EP93XX
drivers/pwm/Makefile +1 -0
index ec50eb5..d186f35 100644
@@ -8,6 +8,7 @@ obj-$(CONFIG_PWM_BCM_KONA)	+= pwm-bcm-kona.o
 obj-$(CONFIG_PWM_BCM2835)	+= pwm-bcm2835.o
 obj-$(CONFIG_PWM_BFIN)		+= pwm-bfin.o
 obj-$(CONFIG_PWM_CLPS711X)	+= pwm-clps711x.o
+obj-$(CONFIG_PWM_CRC)		+= pwm-crc.o
 obj-$(CONFIG_PWM_EP93XX)	+= pwm-ep93xx.o
 obj-$(CONFIG_PWM_FSL_FTM)	+= pwm-fsl-ftm.o
 obj-$(CONFIG_PWM_IMG)		+= pwm-img.o
drivers/pwm/pwm-crc.c new file +143 -0

143 lines not on this page · raw message

Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v3 5/7
#7 lore raw

Re: [v3 5/7] pwm: crc: Add Crystalcove (CRC) PWM driver

Quoted 30 lines · Shobhit Kumar

The Crystalcove PMIC provides three PWM signals and this driver exports one of them on the BYT platform which is used to control backlight for DSI panel. This is platform device implementation of the drivers/mfd cell device for CRC PMIC.

CC Samuel Ortiz <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Alexandre Courbot <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Paul Bolle <[email protected]>
Cc Paul Gortmaker <[email protected]>

---
v2: Use the existing config callback with duty_ns and period_ns(Thierry)

v3: Correct the subject line (Lee jones)

v4: Address comment by Thierry & Paul
- Commit message update and fixes for few syntax errors
- Add PWM_CRC in Kconfig and Makefile sorted alphabetically
- Use the PWM_BASE_CLK as 6000000 for better code readability
- Remove the redundant rule of three while calculating pwm level
- Use the platform_device in pwm_chip
- Use builin_platform_driver

v5: Address comments by Varka
- Make the bit definition using BIT macro
- reorder probe and remove code to directly return from pwmchip_add/remove

Quoted 5 lines
  drivers/pwm/Kconfig   |   7 +++
  drivers/pwm/Makefile  |   1 +
  drivers/pwm/pwm-crc.c | 143 ++++++++++++++++++++++++++++++++++++++++++++++++++
  3 files changed, 151 insertions(+)

create mode 100644 drivers/pwm/pwm-crc.c

Signature · 7 lines
Best regards,
Varka Bhadram.

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#8 lore raw

PATCH v3 6/7 drm/i915: Use the CRC gpio for panel enable/disable

In reply to Shobhit Kumar

The CRC (Crystal Cove) PMIC, controls the panel enable and disable signals for BYT for dsi panels. This is indicated in the VBT fields. Use that to initialize and use GPIO based control for these signals.

v2: Use the newer gpiod interface(Alexandre)
v3: Remove the redundant checks and unused code (Ville)
v4: Moved PWM vs SoC backlight #defines to intel_bios.h (Jani)

---
 drivers/gpu/drm/i915/intel_bios.h |  7 +++++++
 drivers/gpu/drm/i915/intel_dsi.c  | 32 ++++++++++++++++++++++++++++++--
 drivers/gpu/drm/i915/intel_dsi.h  |  3 +++
 3 files changed, 40 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_bios.h +7 -0
index af0b476..f7ad6a5 100644
@@ -778,6 +778,13 @@ int intel_parse_bios(struct drm_device *dev);
 #define MIPI_DSI_UNDEFINED_PANEL_ID	0
 #define MIPI_DSI_GENERIC_PANEL_ID	1
 
+/*
+ * PMIC vs SoC Backlight support specified in pwm_blc
+ * field in mipi_config block below.
+*/
+#define PPS_BLC_PMIC   0
+#define PPS_BLC_SOC    1
+
 struct mipi_config {
 	u16 panel_id;
 
drivers/gpu/drm/i915/intel_dsi.c +30 -2
index b5a5558..c4db74a 100644
@@ -31,6 +31,7 @@
 #include <drm/drm_panel.h>
 #include <drm/drm_mipi_dsi.h>
 #include <linux/slab.h>
+#include <linux/gpio/consumer.h>
 #include "i915_drv.h"
 #include "intel_drv.h"
 #include "intel_dsi.h"
@@ -415,6 +416,12 @@ static void intel_dsi_pre_enable(struct intel_encoder *encoder)
 
 	DRM_DEBUG_KMS("\n");
 
+	/* Panel Enable over CRC PMIC */
+	if (intel_dsi->gpio_panel)
+		gpiod_set_value_cansleep(intel_dsi->gpio_panel, 1);
+
+	msleep(intel_dsi->panel_on_delay);
+
 	/* Disable DPOunit clock gating, can stall pipe
 	 * and we need DPLL REFA always enabled */
 	tmp = I915_READ(DPLL(pipe));
@@ -432,8 +439,6 @@ static void intel_dsi_pre_enable(struct intel_encoder *encoder)
 	/* put device in ready state */
 	intel_dsi_device_ready(encoder);
 
-	msleep(intel_dsi->panel_on_delay);
-
 	drm_panel_prepare(intel_dsi->panel);
 
 	for_each_dsi_port(port, intel_dsi->ports)
@@ -576,6 +581,10 @@ static void intel_dsi_post_disable(struct intel_encoder *encoder)
 
 	msleep(intel_dsi->panel_off_delay);
 	msleep(intel_dsi->panel_pwr_cycle_delay);
+
+	/* Panel Disable over CRC PMIC */
+	if (intel_dsi->gpio_panel)
+		gpiod_set_value_cansleep(intel_dsi->gpio_panel, 0);
 }
 
 static bool intel_dsi_get_hw_state(struct intel_encoder *encoder,
@@ -955,6 +964,11 @@ static void intel_dsi_encoder_destroy(struct drm_encoder *encoder)
 		/* XXX: Logically this call belongs in the panel driver. */
 		drm_panel_remove(intel_dsi->panel);
 	}
+
+	/* dispose of the gpios */
+	if (intel_dsi->gpio_panel)
+		gpiod_put(intel_dsi->gpio_panel);
+
 	intel_encoder_destroy(encoder);
 }
 
@@ -1071,6 +1085,20 @@ void intel_dsi_init(struct drm_device *dev)
 		goto err;
 	}
 
+	/*
+	 * In case of BYT with CRC PMIC, we need to use GPIO for
+	 * Panel control.
+	 */
+	if (dev_priv->vbt.dsi.config->pwm_blc == PPS_BLC_PMIC) {
+		intel_dsi->gpio_panel =
+			gpiod_get(dev->dev, "panel", GPIOD_OUT_HIGH);
+
+		if (IS_ERR(intel_dsi->gpio_panel)) {
+			DRM_ERROR("Failed to own gpio for panel control\n");
+			intel_dsi->gpio_panel = NULL;
+		}
+	}
+
 	intel_encoder->type = INTEL_OUTPUT_DSI;
 	intel_encoder->cloneable = 0;
 	drm_connector_init(dev, connector, &intel_dsi_connector_funcs,
drivers/gpu/drm/i915/intel_dsi.h +3 -0
index 2784ac4..42a6859 100644
@@ -42,6 +42,9 @@ struct intel_dsi {
 	struct drm_panel *panel;
 	struct intel_dsi_host *dsi_hosts[I915_MAX_PORTS];
 
+	/* GPIO Desc for CRC based Panel control */
+	struct gpio_desc *gpio_panel;
+
 	struct intel_connector *attached_connector;
 
 	/* bit mask of ports being driven */
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#9 lore raw

PATCH v3 7/7 drm/i915: Backlight control using CRC PMIC based PWM driver

In reply to Shobhit Kumar

Use the CRC PWM device in intel_panel.c and add new MIPI backlight specififc callbacks

v2: Modify to use pwm_config callback
v3: Addressed Jani's comments
- Renamed all function as pwm_* instead of vlv_*
- Call intel_panel_actually_set_backlight in enable function
- Return -ENODEV in case pwm_get fails
- in case pwm_config error return error cdoe from pwm_config
- Cleanup pwm in intel_panel_destroy_backlight
v4: Removed unused #defines and initialized backlight with INVALID_PIPE (Ville)

---
 drivers/gpu/drm/i915/intel_drv.h   |  4 ++
 drivers/gpu/drm/i915/intel_dsi.c   |  5 ++
 drivers/gpu/drm/i915/intel_panel.c | 94 ++++++++++++++++++++++++++++++++++++--
 3 files changed, 98 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/intel_drv.h +4 -0
index 2afb31a..561c17f 100644
@@ -182,6 +182,10 @@ struct intel_panel {
 		bool enabled;
 		bool combination_mode;	/* gen 2/4 only */
 		bool active_low_pwm;
+
+		/* PWM chip */
+		struct pwm_device *pwm;
+
 		struct backlight_device *device;
 	} backlight;
 
drivers/gpu/drm/i915/intel_dsi.c +5 -0
index c4db74a..892b936 100644
@@ -402,6 +402,8 @@ static void intel_dsi_enable(struct intel_encoder *encoder)
 
 		intel_dsi_port_enable(encoder);
 	}
+
+	intel_panel_enable_backlight(intel_dsi->attached_connector);
 }
 
 static void intel_dsi_pre_enable(struct intel_encoder *encoder)
@@ -466,6 +468,8 @@ static void intel_dsi_pre_disable(struct intel_encoder *encoder)
 
 	DRM_DEBUG_KMS("\n");
 
+	intel_panel_disable_backlight(intel_dsi->attached_connector);
+
 	if (is_vid_mode(intel_dsi)) {
 		/* Send Shutdown command to the panel in LP mode */
 		for_each_dsi_port(port, intel_dsi->ports)
@@ -1132,6 +1136,7 @@ void intel_dsi_init(struct drm_device *dev)
 	}
 
 	intel_panel_init(&intel_connector->panel, fixed_mode, NULL);
+	intel_panel_setup_backlight(connector, INVALID_PIPE);
 
 	return;
 
drivers/gpu/drm/i915/intel_panel.c +89 -5

144 lines not on this page · raw message

Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#10 lore raw
In reply to Shobhit Kumar
Quoted 12 lines · Shobhit Kumar

Hi,
Next update of the series reviewed at
https://lkml.org/lkml/2015/6/22/155

Major changes are few review comments from Varka and Ville being addressed. Also except for intel-gfx patches, all patches reviesion history is moved out of commit message.

Hope this series finally finds its mark.

Regards
Shobhit

Quoted 9 lines

Shobhit Kumar (7):
gpiolib: Add support for removing registered consumer lookup table
mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO
signal
mfd: intel_soc_pmic_crc: Add PWM cell device for Crystalcove PMIC
mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM
pwm: crc: Add Crystalcove (CRC) PWM driver
drm/i915: Use the CRC gpio for panel enable/disable drm/i915: Backlight control using CRC PMIC based PWM driver

I think we have r-b/acks on all the patches now. Ok if I pull this in through drm-intel.git for 4.3? Or should I make a topic branch with tag and then send out pull requests to everyone? Or will each maintainer merge on their own since it's all only coupled at runtime anyway? Any of these would suit me.

Thanks, Daniel

Quoted 23 lines
 drivers/gpio/gpiolib.c             |  13 ++++
 drivers/gpu/drm/i915/intel_bios.h  |   7 ++
 drivers/gpu/drm/i915/intel_drv.h   |   4 ++
 drivers/gpu/drm/i915/intel_dsi.c   |  37 +++++++++-
 drivers/gpu/drm/i915/intel_dsi.h   |   3 +
 drivers/gpu/drm/i915/intel_panel.c |  94 ++++++++++++++++++++++--
 drivers/mfd/intel_soc_pmic_core.c  |  29 ++++++++
 drivers/mfd/intel_soc_pmic_crc.c   |   3 +
 drivers/pwm/Kconfig                |   7 ++
 drivers/pwm/Makefile               |   1 +
 drivers/pwm/pwm-crc.c              | 143 +++++++++++++++++++++++++++++++++++++
 include/linux/gpio/machine.h       |   1 +
 12 files changed, 335 insertions(+), 7 deletions(-)
 create mode 100644 drivers/pwm/pwm-crc.c
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
#11 lore raw
Quoted 23 lines · Daniel Vetter
Quoted 12 lines · Shobhit Kumar

Hi,
Next update of the series reviewed at
https://lkml.org/lkml/2015/6/22/155

Major changes are few review comments from Varka and Ville being addressed. Also except for intel-gfx patches, all patches reviesion history is moved out of commit message.

Hope this series finally finds its mark.

Regards
Shobhit

Quoted 9 lines

Shobhit Kumar (7):
gpiolib: Add support for removing registered consumer lookup table
mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO
signal
mfd: intel_soc_pmic_crc: Add PWM cell device for Crystalcove PMIC
mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM
pwm: crc: Add Crystalcove (CRC) PWM driver
drm/i915: Use the CRC gpio for panel enable/disable drm/i915: Backlight control using CRC PMIC based PWM driver

Quoted 5 lines

I think we have r-b/acks on all the patches now. Ok if I pull this in through drm-intel.git for 4.3? Or should I make a topic branch with tag and then send out pull requests to everyone? Or will each maintainer merge on their own since it's all only coupled at runtime anyway? Any of these would suit me.

I forgot to mention that I had a build failure due to builtin_platform_driver() when I tried this (just changed it to module_platform_driver() to get past it). So I'm not sure if this now depends on some tree which isn't included in -nightly...

Signature · 6 lines
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#12 lore raw
Quoted 30 lines · Ville Syrjälä
Quoted 23 lines · Daniel Vetter
Quoted 12 lines · Shobhit Kumar

Hi,
Next update of the series reviewed at
https://lkml.org/lkml/2015/6/22/155

Major changes are few review comments from Varka and Ville being addressed. Also except for intel-gfx patches, all patches reviesion history is moved out of commit message.

Hope this series finally finds its mark.

Regards
Shobhit

Quoted 9 lines

Shobhit Kumar (7):
gpiolib: Add support for removing registered consumer lookup table
mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO
signal
mfd: intel_soc_pmic_crc: Add PWM cell device for Crystalcove PMIC
mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM
pwm: crc: Add Crystalcove (CRC) PWM driver
drm/i915: Use the CRC gpio for panel enable/disable drm/i915: Backlight control using CRC PMIC based PWM driver

Quoted 5 lines

I think we have r-b/acks on all the patches now. Ok if I pull this in through drm-intel.git for 4.3? Or should I make a topic branch with tag and then send out pull requests to everyone? Or will each maintainer merge on their own since it's all only coupled at runtime anyway? Any of these would suit me.

Quoted 4 lines

I forgot to mention that I had a build failure due to builtin_platform_driver() when I tried this (just changed it to module_platform_driver() to get past it). So I'm not sure if this now depends on some tree which isn't included in -nightly...

These patches are based on linux-next/master

Regards
Shobhit
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#13 lore raw
In reply to Ville Syrjälä
Quoted 30 lines · [Re: [Intel-gfx] [v3 0/7] Crystalcove (CRC) PMIC based panel and pwm control]…
Quoted 23 lines · Daniel Vetter
Quoted 12 lines · Shobhit Kumar

Hi,
Next update of the series reviewed at
https://lkml.org/lkml/2015/6/22/155

Major changes are few review comments from Varka and Ville being addressed. Also except for intel-gfx patches, all patches reviesion history is moved out of commit message.

Hope this series finally finds its mark.

Regards
Shobhit

Quoted 9 lines

Shobhit Kumar (7):
gpiolib: Add support for removing registered consumer lookup table
mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO
signal
mfd: intel_soc_pmic_crc: Add PWM cell device for Crystalcove PMIC
mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM
pwm: crc: Add Crystalcove (CRC) PWM driver
drm/i915: Use the CRC gpio for panel enable/disable drm/i915: Backlight control using CRC PMIC based PWM driver

Quoted 5 lines

I think we have r-b/acks on all the patches now. Ok if I pull this in through drm-intel.git for 4.3? Or should I make a topic branch with tag and then send out pull requests to everyone? Or will each maintainer merge on their own since it's all only coupled at runtime anyway? Any of these would suit me.

Quoted 4 lines

I forgot to mention that I had a build failure due to builtin_platform_driver() when I tried this (just changed it to module_platform_driver() to get past it). So I'm not sure if this now depends on some tree which isn't included in -nightly...

builtin_platform_register does not yet exist in mainline; as Paul (the other one) said earlier. So you can either open-code what it does for now, or use module_platform_register. If you do the latter, then ensure you (temorarily) also include module.h or you risk additional breakage in the future.

Paul.
--

Quoted 4 lines
Signature · 3 lines
-- 
Ville Syrjälä
Intel OTC
#14 lore raw

Tested by Brian Loften, "Brain Wreck" [email protected] confirmed working on ASUS T100TA, kernel 20150629 -next running 15.04 i386 Ubuntu Gnome -- suspend resume is functioning normally, backlight controls work before and after resume using slide controls and meta keys on keyboard

Quoted 44 lines · Paul Gortmaker

[Re: [Intel-gfx] [v3 0/7] Crystalcove (CRC) PMIC based panel and pwm

Quoted 7 lines · control] On 26/06/2015 (Fri 20:47) Ville Syrjälä wrote:
Quoted 6 lines · Daniel Vetter
Quoted 5 lines · Shobhit Kumar

Hi,
Next update of the series reviewed at
https://lkml.org/lkml/2015/6/22/155

Major changes are few review comments from Varka and Ville being

addressed. Also except

Quoted 1 line
Quoted 1 line
Quoted 1 line

for intel-gfx patches, all patches reviesion history is moved out of

commit message.

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

Hope this series finally finds its mark.

Regards
Shobhit

Shobhit Kumar (7):
gpiolib: Add support for removing registered consumer lookup table
mfd: intel_soc_pmic_core: Add lookup table for Panel Control as

GPIO

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

signal
mfd: intel_soc_pmic_crc: Add PWM cell device for Crystalcove PMIC
mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based

PWM

Quoted 7 lines
Quoted 7 lines
Quoted 3 lines

pwm: crc: Add Crystalcove (CRC) PWM driver drm/i915: Use the CRC gpio for panel enable/disable drm/i915: Backlight control using CRC PMIC based PWM driver

I think we have r-b/acks on all the patches now. Ok if I pull this in through drm-intel.git for 4.3? Or should I make a topic branch with tag and then send out pull requests to everyone? Or will each maintainer

merge

Quoted 1 line
Quoted 1 line

on their own since it's all only coupled at runtime anyway? Any of

these

Quoted 6 lines
Quoted 1 line

would suit me.

I forgot to mention that I had a build failure due to builtin_platform_driver() when I tried this (just changed it to module_platform_driver() to get past it). So I'm not sure if this now depends on some tree which isn't included in -nightly...

Quoted 14 lines

builtin_platform_register does not yet exist in mainline; as Paul (the other one) said earlier. So you can either open-code what it does for now, or use module_platform_register. If you do the latter, then ensure you (temorarily) also include module.h or you risk additional breakage in the future.

Paul.
--

Quoted 4 lines

--
Ville Syrjälä
Intel OTC

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#15 lore raw
In reply to Paul Gortmaker
Quoted 37 lines · Paul Gortmaker
Quoted 30 lines · [Re: [Intel-gfx] [v3 0/7] Crystalcove (CRC) PMIC based panel and pwm control]…
Quoted 23 lines · Daniel Vetter
Quoted 12 lines · Shobhit Kumar

Hi,
Next update of the series reviewed at
https://lkml.org/lkml/2015/6/22/155

Major changes are few review comments from Varka and Ville being addressed. Also except for intel-gfx patches, all patches reviesion history is moved out of commit message.

Hope this series finally finds its mark.

Regards
Shobhit

Quoted 9 lines

Shobhit Kumar (7):
gpiolib: Add support for removing registered consumer lookup table
mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO
signal
mfd: intel_soc_pmic_crc: Add PWM cell device for Crystalcove PMIC
mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM
pwm: crc: Add Crystalcove (CRC) PWM driver
drm/i915: Use the CRC gpio for panel enable/disable drm/i915: Backlight control using CRC PMIC based PWM driver

Quoted 5 lines

I think we have r-b/acks on all the patches now. Ok if I pull this in through drm-intel.git for 4.3? Or should I make a topic branch with tag and then send out pull requests to everyone? Or will each maintainer merge on their own since it's all only coupled at runtime anyway? Any of these would suit me.

Quoted 4 lines

I forgot to mention that I had a build failure due to builtin_platform_driver() when I tried this (just changed it to module_platform_driver() to get past it). So I'm not sure if this now depends on some tree which isn't included in -nightly...

Quoted 6 lines

builtin_platform_register does not yet exist in mainline; as Paul (the other one) said earlier. So you can either open-code what it does for now, or use module_platform_register. If you do the latter, then ensure you (temorarily) also include module.h or you risk additional breakage in the future.

Guess its in mainline now. Whats the plan for the merge of these patches ?

Regards
Shobhit

Quoted 11 lines

Paul.
--

Quoted 4 lines

--
Ville Syrjälä
Intel OTC

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#16 lore raw
Quoted 39 lines · Shobhit Kumar
Quoted 37 lines · Paul Gortmaker
Quoted 34 lines · [Re: [Intel-gfx] [v3 0/7] Crystalcove (CRC) PMIC based panel and pwm control]…
Quoted 23 lines · Daniel Vetter
Quoted 12 lines · Shobhit Kumar

Hi,
Next update of the series reviewed at
https://lkml.org/lkml/2015/6/22/155

Major changes are few review comments from Varka and Ville being addressed. Also except for intel-gfx patches, all patches reviesion history is moved out of commit message.

Hope this series finally finds its mark.

Regards
Shobhit

Quoted 9 lines

Shobhit Kumar (7):
gpiolib: Add support for removing registered consumer lookup table
mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO
signal
mfd: intel_soc_pmic_crc: Add PWM cell device for Crystalcove PMIC
mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM
pwm: crc: Add Crystalcove (CRC) PWM driver
drm/i915: Use the CRC gpio for panel enable/disable drm/i915: Backlight control using CRC PMIC based PWM driver

Quoted 5 lines

I think we have r-b/acks on all the patches now. Ok if I pull this in through drm-intel.git for 4.3? Or should I make a topic branch with tag and then send out pull requests to everyone? Or will each maintainer merge on their own since it's all only coupled at runtime anyway? Any of these would suit me.

I forgot to mention that I had a build failure due to builtin_platform_driver() when I tried this (just changed it to module_platform_driver() to get past it). So I'm not sure if this now depends on some tree which isn't included in -nightly...

Quoted 9 lines
Quoted 6 lines

builtin_platform_register does not yet exist in mainline; as Paul (the other one) said earlier. So you can either open-code what it does for now, or use module_platform_register. If you do the latter, then ensure you (temorarily) also include module.h or you risk additional breakage in the future.

Guess its in mainline now. Whats the plan for the merge of these patches ?

Do I need to do anything further on these patches ? Daniel can you help in the next steps.

Regards
Shobhit
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#17 lore raw
Quoted 47 lines · Shobhit Kumar
Quoted 46 lines · Shobhit Kumar
Quoted 43 lines · Paul Gortmaker
Quoted 30 lines · [Re: [Intel-gfx] [v3 0/7] Crystalcove (CRC) PMIC based panel and pwm control]…
Quoted 23 lines · Daniel Vetter
Quoted 12 lines · Shobhit Kumar

Hi,
Next update of the series reviewed at
https://lkml.org/lkml/2015/6/22/155

Major changes are few review comments from Varka and Ville being addressed. Also except for intel-gfx patches, all patches reviesion history is moved out of commit message.

Hope this series finally finds its mark.

Regards
Shobhit

Quoted 9 lines

Shobhit Kumar (7):
gpiolib: Add support for removing registered consumer lookup table
mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO
signal
mfd: intel_soc_pmic_crc: Add PWM cell device for Crystalcove PMIC
mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM
pwm: crc: Add Crystalcove (CRC) PWM driver
drm/i915: Use the CRC gpio for panel enable/disable drm/i915: Backlight control using CRC PMIC based PWM driver

Quoted 5 lines

I think we have r-b/acks on all the patches now. Ok if I pull this in through drm-intel.git for 4.3? Or should I make a topic branch with tag and then send out pull requests to everyone? Or will each maintainer merge on their own since it's all only coupled at runtime anyway? Any of these would suit me.

Quoted 4 lines

I forgot to mention that I had a build failure due to builtin_platform_driver() when I tried this (just changed it to module_platform_driver() to get past it). So I'm not sure if this now depends on some tree which isn't included in -nightly...

builtin_platform_register does not yet exist in mainline; as Paul (the other one) said earlier. So you can either open-code what it does for now, or use module_platform_register. If you do the latter, then ensure you (temorarily) also include module.h or you risk additional breakage in the future.

Quoted 5 lines
Quoted 2 lines

Guess its in mainline now. Whats the plan for the merge of these patches ?

Do I need to do anything further on these patches ? Daniel can you help in the next steps.

I'm pulling them into a topic branch and then get it merged through drm-intel.git. If other maintainers want to I can send them a pull request for that topic branch too.
-Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html