Skip to contentSkip to conversation

ARM: tegra: paz00: set gpiod_lookup table conn_id's

PATCH In review Dmitry Osipenko 2 participants 3 messages Jun 28, 2015 – Jun 30, 2015

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: tegra: paz00: set gpiod_lookup table conn_id's

Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings for ACPI") removed possibility to request GPIO by table index for non-ACPI platforms without changing it users. As result "shutdown" GPIO request will fail if request for "reset" GPIO succeeded or "reset" will be requested instead of "shutdown" if "reset" wasn't defined. Fix it by setting conn_id's in gpiod_lookup_table.

Fixes 72daceb (net: rfkill: gpio: Add default GPIO driver mappings for ACPI)
Cc <[email protected]> # v3.19+
---
 arch/arm/mach-tegra/board-paz00.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-tegra/board-paz00.c +2 -2
index fbe74c6..67024f3 100644
@@ -39,8 +39,8 @@ static struct platform_device wifi_rfkill_device = {
 static struct gpiod_lookup_table wifi_gpio_lookup = {
 	.dev_id = "rfkill_gpio",
 	.table = {
-		GPIO_LOOKUP_IDX("tegra-gpio", 25, NULL, 0, 0),
-		GPIO_LOOKUP_IDX("tegra-gpio", 85, NULL, 1, 0),
+		GPIO_LOOKUP_IDX("tegra-gpio", 25, "reset", 0, 0),
+		GPIO_LOOKUP_IDX("tegra-gpio", 85, "shutdown", 1, 0),
 		{ },
 	},
 };
Signature · 1 line
2.4.4
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Dmitry Osipenko

Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings for ACPI") removed possibility to request GPIO by table index for non-ACPI platforms without changing it users. As result "shutdown" GPIO request will fail if request for "reset" GPIO succeeded or "reset" will be requested instead of "shutdown" if "reset" wasn't defined. Fix it by setting conn_id's in gpiod_lookup_table.

Yep, and using con_ids is a good idea anyway.

Quoted 26 lines
Fixes 72daceb (net: rfkill: gpio: Add default GPIO driver mappings for ACPI)
Cc <[email protected]> # v3.19+
---
 arch/arm/mach-tegra/board-paz00.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-tegra/board-paz00.c +2 -3
index fbe74c6..67024f3 100644
@@ -39,8 +39,8 @@ static struct platform_device wifi_rfkill_device = {
 static struct gpiod_lookup_table wifi_gpio_lookup = {
        .dev_id = "rfkill_gpio",
        .table = {
-               GPIO_LOOKUP_IDX("tegra-gpio", 25, NULL, 0, 0),
-               GPIO_LOOKUP_IDX("tegra-gpio", 85, NULL, 1, 0),
+               GPIO_LOOKUP_IDX("tegra-gpio", 25, "reset", 0, 0),
+               GPIO_LOOKUP_IDX("tegra-gpio", 85, "shutdown", 1, 0),
                { },
        },
 };
--

2.4.4

#2 lore raw

30.06.2015 16:42, Alexandre Courbot ?????:

Quoted 8 lines · Dmitry Osipenko
Quoted 6 lines

Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings for ACPI") removed possibility to request GPIO by table index for non-ACPI platforms without changing it users. As result "shutdown" GPIO request will fail if request for "reset" GPIO succeeded or "reset" will be requested instead of "shutdown" if "reset" wasn't defined. Fix it by setting conn_id's in gpiod_lookup_table.

Quoted 4 lines

Yep, and using con_ids is a good idea anyway.

After discussion on irc, turned out that patch missed s/GPIO_LOOKUP_IDX/GPIO_LOOKUP. I'll send V2.

And s/conn_id/con_id typo started to annoy me...

Signature · 1 line
Dmitry