Skip to contentSkip to conversation

tools/libxc: check to set args.mmio_size before call xc_hvm_build

PATCH RESEND Applied Tiejun Chen 2 participants 2 messages Jun 29, 2015 – Jun 30, 2015

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 tools/libxc: check to set args.mmio_size before call xc_hvm_build

After commit 5dff8e9eedc7, "libxc/libxl: fill xc_hvm_build_args in libxl" is introduced, we won't check to set args.mmio_size inside xc_hvm_build as before. So instead, we need to do this before call that.

CC Ian Jackson <[email protected]>
CC Stefano Stabellini <[email protected]>
CC Ian Campbell <[email protected]>
CC Wei Liu <[email protected]>

---

As we discussed previously, we'd like to sent this separately. For more detail please see,

http://osdir.com/ml/general/2015-06/msg38370.html

 tools/libxc/xc_hvm_build_x86.c | 2 ++
 1 file changed, 2 insertions(+)
tools/libxc/xc_hvm_build_x86.c +2 -0
index 003ea06..7343e87 100644
@@ -754,6 +754,8 @@ int xc_hvm_build_target_mem(xc_interface *xch,
     args.mem_size = (uint64_t)memsize << 20;
     args.mem_target = (uint64_t)target << 20;
     args.image_file_name = image_name;
+    if ( args.mmio_size == 0 )
+        args.mmio_size = HVM_BELOW_4G_MMIO_LENGTH;
 
     return xc_hvm_build(xch, domid, &args);
 }
Signature · 1 line
1.9.1
Applied
#1 lore raw
Quoted 11 lines · Tiejun Chen

After commit 5dff8e9eedc7, "libxc/libxl: fill xc_hvm_build_args in libxl" is introduced, we won't check to set args.mmio_size inside xc_hvm_build as before. So instead, we need to do this before call that.

CC Ian Jackson <[email protected]>
CC Stefano Stabellini <[email protected]>
CC Ian Campbell <[email protected]>
CC Wei Liu <[email protected]>

Applied, thanks.