Skip to contentSkip to conversation

views.py: Added validation in recipe detail

PATCH New [email protected] 1 participant 1 message Jun 29, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 views.py: Added validation in recipe detail

From: Mariano Lopez <[email protected]>

Added the validation for the maintainer in the
recipe detail view. Also added a check if the
recipe exists.

[YOCTO #7904]

---
 rrs/views.py | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
rrs/views.py +8 -4
index ad741f6..e2aa1ce 100644
@@ -329,6 +329,8 @@ class RecipeDetailView(DetailView):
     def get_context_data(self, **kwargs):
         context = super(RecipeDetailView, self).get_context_data(**kwargs)
         recipe = self.get_object()
+        if not recipe:
+            raise django.http.Http404
 
         release = Release.get_current()
         context['release_name'] = release.name
@@ -357,10 +359,12 @@ class RecipeDetailView(DetailView):
 
         self.recipe_maintainer_history = RecipeMaintainerHistory.get_last()
         recipe_maintainer = RecipeMaintainer.objects.filter(recipe = recipe,
-                history = self.recipe_maintainer_history)[0]
-        maintainer = recipe_maintainer.maintainer
-
-        context['maintainer_name'] = maintainer.name
+                history = self.recipe_maintainer_history)
+        if recipe_maintainer:
+            maintainer = recipe_maintainer[0].maintainer
+            context['maintainer_name'] = maintainer.name
+        else:
+            context['maintainer_name'] = 'No maintainer'
 
         context['recipe_upgrade_details'] = []
         for ru in RecipeUpgrade.objects.filter(recipe =
Signature · 1 line
1.9.1