Skip to contentSkip to conversation

drm/mgag200: doesn't work in panic context

DISCUSSION Rui Wang 2 participants 2 messages Jun 30, 2015

lore
Share & tools
lore

Rui Wang

author
#0 lore raw
Quoted 4 lines · Daniel Vetter

As long as the display is up and running we should have a fair stab at showing the oops - it's just that no one has seriously bothered with the necessary infastructure, automated testing (it won't work otherwise) and driver work.

I think testing can be done by injecting a fatal machine check exception via einj's debugfs interface. I can reproduce the hard hang every time. I think It can be a simple script or C program do to the automated testing. If anyone has any patch I'll be happy to help test it out.

Thanks
Rui

#1 lore raw
Quoted 10 lines · Rui Wang
Quoted 4 lines · Daniel Vetter

As long as the display is up and running we should have a fair stab at showing the oops - it's just that no one has seriously bothered with the necessary infastructure, automated testing (it won't work otherwise) and driver work.

I think testing can be done by injecting a fatal machine check exception via einj's debugfs interface. I can reproduce the hard hang every time. I think It can be a simple script or C program do to the automated testing. If anyone has any patch I'll be happy to help test it out.

Testing shouldn't kill the machine ;-)

The idea I had is to just exercise the drm panic code (since we'd need to shunt everything else), and that can be done my calling the relevant functions from a hardirq context. And hardirq context is simples to get with a IPI to the local cpu. This way we don't depend upon the entire panic path to be recoverable, but only upon the drm bits being sane.

The other thing that needs testing is pushing all the fbdev callbacks into workers if run from non-process context. But that's something fbdev likes doing anyway (it's just that most drivers don't need to overwrite the hooks where this usually happens).
-Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch