ARM: tegra: paz00: use con_id's to refer GPIO's in gpiod_lookup table
PATCH v2 1/1 ARM: tegra: paz00: use con_id's to refer GPIO's in gpiod_lookup table
Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings for ACPI") removed possibility to request GPIO by table index for non-ACPI platforms without changing it users. As result "shutdown" GPIO request will fail if request for "reset" GPIO succeeded or "reset" will be requested instead of "shutdown" if "reset" wasn't defined. Fix it by making gpiod_lookup_table use con_id's instead of indexes.
---
v2: s/GPIO_LOOKUP_IDX/GPIO_LOOKUP/, otherwise "shutdown" GPIO won't be requested
arch/arm/mach-tegra/board-paz00.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-tegra/board-paz00.c +2 -2
@@ -39,8 +39,8 @@ static struct platform_device wifi_rfkill_device = {static struct gpiod_lookup_table wifi_gpio_lookup = { .dev_id ="rfkill_gpio" , .table = { -GPIO_LOOKUP_IDX ("tegra-gpio" ,25 ,NULL ,0 ,0 ), -GPIO_LOOKUP_IDX ("tegra-gpio" ,85 ,NULL ,1 ,0 ), +GPIO_LOOKUP ("tegra-gpio" ,25 ,"reset" ,0 ), +GPIO_LOOKUP ("tegra-gpio" ,85 ,"shutdown" ,0 ), { }, }, };
Signature · 1 line
2.4.4
Am Dienstag 30 Juni 2015, 17:15:50 schrieb Dmitry Osipenko:
Quoted 11 lines
Commit
72daceb9a10a("net: rfkill: gpio: Add default GPIO driver mappings for ACPI") removed possibility to request GPIO by table index for non-ACPI platforms without changing it users. As result "shutdown" GPIO request will fail if request for "reset" GPIO succeeded or "reset" will be requested instead of "shutdown" if "reset" wasn't defined. Fix it by makinggpiod_lookup_tableuse con_id's instead of indexes.Signed-off-by Dmitry Osipenko <[email protected]>Fixes 72daceb (net: rfkill: gpio: Add default GPIO driver mappings forACPI) Cc: <[email protected]> # v3.19+
beside a small typo in the commit message (is users -> its users) this looks good now. I can confirm that the gpio's are all available now.
Quoted 13 lines
---
v2: s/GPIO_LOOKUP_IDX/GPIO_LOOKUP/, otherwise "shutdown" GPIO won't be requested
arch/arm/mach-tegra/board-paz00.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/arch/arm/mach-tegra/board-paz00.cindex fbe74c6..49d1110 100644
arch/arm/mach-tegra/board-paz00.c static struct platform_device wifi_rfkill_device = { · line 46
Quoted 10 lines
arch/arm/mach-tegra/board-paz00.c +2
-2@@ -39,8 +39,8 @@ static struct platform_device wifi_rfkill_device = {static struct gpiod_lookup_table wifi_gpio_lookup = { .dev_id ="rfkill_gpio" , .table = { -GPIO_LOOKUP_IDX ("tegra-gpio" ,25 ,NULL ,0 ,0 ), -GPIO_LOOKUP_IDX ("tegra-gpio" ,85 ,NULL ,1 ,0 ), +GPIO_LOOKUP ("tegra-gpio" ,25 ,"reset" ,0 ), +GPIO_LOOKUP ("tegra-gpio" ,85 ,"shutdown" ,0 ), { }, }, };
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150630/47b9577a/attachment.sig>
30.06.2015 17:15, Dmitry Osipenko ?????:
Quoted 24 lines
Commit
72daceb9a10a("net: rfkill: gpio: Add default GPIO driver mappings for ACPI") removed possibility to request GPIO by table index for non-ACPI platforms without changing it users. As result "shutdown" GPIO request will fail if request for "reset" GPIO succeeded or "reset" will be requested instead of "shutdown" if "reset" wasn't defined. Fix it by makinggpiod_lookup_tableuse con_id's instead of indexes.Signed-off-by Dmitry Osipenko <[email protected]>Fixes 72daceb (net: rfkill: gpio: Add default GPIO driver mappings for ACPI)Cc <[email protected]> # v3.19+---
v2: s/GPIO_LOOKUP_IDX/GPIO_LOOKUP/, otherwise "shutdown" GPIO won't be requested
arch/arm/mach-tegra/board-paz00.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/mach-tegra/board-paz00.c +0
-0
arch/arm/mach-tegra/board-paz00.c static struct platform_device wifi_rfkill_device = { · line 46
Quoted 10 lines
arch/arm/mach-tegra/board-paz00.c +2
-2@@ -39,8 +39,8 @@ static struct platform_device wifi_rfkill_device = {static struct gpiod_lookup_table wifi_gpio_lookup = { .dev_id ="rfkill_gpio" , .table = { -GPIO_LOOKUP_IDX ("tegra-gpio" ,25 ,NULL ,0 ,0 ), -GPIO_LOOKUP_IDX ("tegra-gpio" ,85 ,NULL ,1 ,0 ), +GPIO_LOOKUP ("tegra-gpio" ,25 ,"reset" ,0 ), +GPIO_LOOKUP ("tegra-gpio" ,85 ,"shutdown" ,0 ), { }, }, };
Ping
Signature · 1 line
Dmitry
Marc Dietrich
Tested-byRe: [PATCH v2] ARM: tegra: paz00: use con_id's to refer GPIO's ingpiod_lookup table
Am Montag, 7. September 2015, 12:21:37 schrieb Dmitry Osipenko:
Quoted 35 lines
30.06.2015 17:15, Dmitry Osipenko ?????:
Quoted 34 lines
Commit
72daceb9a10a("net: rfkill: gpio: Add default GPIO driver mappings for ACPI") removed possibility to request GPIO by table index for non-ACPI platforms without changing it users. As result "shutdown" GPIO request will fail if request for "reset" GPIO succeeded or "reset" will be requested instead of "shutdown" if "reset" wasn't defined. Fix it by makinggpiod_lookup_tableuse con_id's instead of indexes.Signed-off-by Dmitry Osipenko <[email protected]>Fixes 72daceb (net: rfkill: gpio: Add default GPIO driver mappings forACPI) Cc: <[email protected]> # v3.19+
---
v2: s/GPIO_LOOKUP_IDX/GPIO_LOOKUP/, otherwise "shutdown" GPIO won't be requested>
arch/arm/mach-tegra/board-paz00.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/arch/arm/mach-tegra/board-paz00.cindex fbe74c6..49d1110 100644arch/arm/mach-tegra/board-paz00.c +2
-2@@ -39,8 +39,8 @@ static struct platform_device wifi_rfkill_device = {static struct gpiod_lookup_table wifi_gpio_lookup = { .dev_id ="rfkill_gpio" , .table = { -GPIO_LOOKUP_IDX ("tegra-gpio" ,25 ,NULL ,0 ,0 ), -GPIO_LOOKUP_IDX ("tegra-gpio" ,85 ,NULL ,1 ,0 ), +GPIO_LOOKUP ("tegra-gpio" ,25 ,"reset" ,0 ), +GPIO_LOOKUP ("tegra-gpio" ,85 ,"shutdown" ,0 ),
Quoted 7 lines
Quoted 5 lines
{ },
}, };Ping
also
I thing this should go through the tegra-soc tree. Thierry? Stephen?
Marc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150908/bb751e14/attachment.sig>