Skip to contentSkip to conversation

spi/s3c24xx: remove unnecessary memset of s3c24xx_spi

PATCH In review Alexey Klimov 3 participants 3 messages Jun 30, 2015 – Jul 7, 2015

Subsystems (4)
SPI Arm Samsung Exynos Arm Rockchip Samsung SPI drivers
lore
Share & tools
lore

Alexey Klimov

author
#0 lore raw

PATCH 1/2 spi/s3c24xx: remove unnecessary memset of s3c24xx_spi

Memory for this struct is allocated by spi_alloc_master() using kzalloc() so it doesn't need to be set to 0 one more time.

Signed-off-by Alexey Klimov <[email protected]>
---
 drivers/spi/spi-s3c24xx.c | 1 -
 1 file changed, 1 deletion(-)
drivers/spi/spi-s3c24xx.c +0 -1
index f747ca2..f36bc32 100644
@@ -501,7 +501,6 @@ static int s3c24xx_spi_probe(struct platform_device *pdev)
 	}
 
 	hw = spi_master_get_devdata(master);
-	memset(hw, 0, sizeof(struct s3c24xx_spi));
 
 	hw->master = master;
 	hw->pdata = pdata = dev_get_platdata(&pdev->dev);
Signature · 1 line
1.9.1
Reviewed-by on v1 1/2
#1 lore raw
Quoted 4 lines · Alexey Klimov

Memory for this struct is allocated by spi_alloc_master() using kzalloc() so it doesn't need to be set to 0 one more time.

Signed-off-by Alexey Klimov <[email protected]>

Yup, I just noticed this too when reviewing the mediatek SPI driver.

For both patches:

Reviewed-by Daniel Kurtz <[email protected]>
Quoted 22 lines
---
 drivers/spi/spi-s3c24xx.c | 1 -
 1 file changed, 1 deletion(-)
drivers/spi/spi-s3c24xx.c +0 -2
index f747ca2..f36bc32 100644
@@ -501,7 +501,6 @@ static int s3c24xx_spi_probe(struct platform_device *pdev)
        }
 
        hw = spi_master_get_devdata(master);
-       memset(hw, 0, sizeof(struct s3c24xx_spi));
 
        hw->master = master;
        hw->pdata = pdata = dev_get_platdata(&pdev->dev);
--

1.9.1

Quoted 4 lines

_______________________________________________
Linux-rockchip mailing list [email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw

Applied "spi/s3c24xx: remove unnecessary memset of s3c24xx_spi" to the spi tree

In reply to Alexey Klimov

The patch

spi/s3c24xx: remove unnecessary memset of s3c24xx_spi

has been applied to the spi tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 385a9c8fccc0308dbd8182c57b29a95e01e29688 Mon Sep 17 00:00:00 2001

From: Alexey Klimov <[email protected]>
Date: Tue, 30 Jun 2015 21:03:58 +0300
Subject: [PATCH] spi/s3c24xx: remove unnecessary memset of s3c24xx_spi

Memory for this struct is allocated by spi_alloc_master() using kzalloc() so it doesn't need to be set to 0 one more time.

Signed-off-by Alexey Klimov <[email protected]>
Reviewed-by Daniel Kurtz <[email protected]>
Signed-off-by Mark Brown <[email protected]>
---
 drivers/spi/spi-s3c24xx.c | 1 -
 1 file changed, 1 deletion(-)
drivers/spi/spi-s3c24xx.c +0 -1
index f747ca2..f36bc32 100644
@@ -501,7 +501,6 @@ static int s3c24xx_spi_probe(struct platform_device *pdev)
 	}
 
 	hw = spi_master_get_devdata(master);
-	memset(hw, 0, sizeof(struct s3c24xx_spi));
 
 	hw->master = master;
 	hw->pdata = pdata = dev_get_platdata(&pdev->dev);
Signature · 6 lines
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html