Skip to contentSkip to conversation

spi/rockchip: remove unnecessary memset of rockchip_spi

PATCH In review Alexey Klimov 2 participants 2 messages Jun 30, 2015 – Jul 7, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 spi/rockchip: remove unnecessary memset of rockchip_spi

Memory for struct rockchip_spi is allocated by spi_alloc_master() using kzalloc() so it doesn't need to be set to 0 one more time.

---
 drivers/spi/spi-rockchip.c | 1 -
 1 file changed, 1 deletion(-)
drivers/spi/spi-rockchip.c +0 -1
index 68e7efe..79a8bc4 100644
@@ -645,7 +645,6 @@ static int rockchip_spi_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, master);
 
 	rs = spi_master_get_devdata(master);
-	memset(rs, 0, sizeof(struct rockchip_spi));
 
 	/* Get basic io resource and map it */
 	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
Signature · 1 line
1.9.1
#1 lore raw

Applied "spi/rockchip: remove unnecessary memset of rockchip_spi" to the spi tree

The patch

spi/rockchip: remove unnecessary memset of rockchip_spi

has been applied to the spi tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 99622f56110ee8cbfe8ecf2dd5e666f67cf4bb97 Mon Sep 17 00:00:00 2001

From: Alexey Klimov <[email protected]>
Date: Tue, 30 Jun 2015 21:04:07 +0300
Subject: [PATCH] spi/rockchip: remove unnecessary memset of rockchip_spi

Memory for struct rockchip_spi is allocated by spi_alloc_master() using kzalloc() so it doesn't need to be set to 0 one more time.

---
 drivers/spi/spi-rockchip.c | 1 -
 1 file changed, 1 deletion(-)
drivers/spi/spi-rockchip.c +0 -1
index 68e7efe..79a8bc4 100644
@@ -645,7 +645,6 @@ static int rockchip_spi_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, master);
 
 	rs = spi_master_get_devdata(master);
-	memset(rs, 0, sizeof(struct rockchip_spi));
 
 	/* Get basic io resource and map it */
 	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
Signature · 6 lines
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html