Skip to contentSkip to conversation

ixgbe:Make the function ixgbe_fwd_ring_down have a return type of void

PATCH New Nicholas Krause 1 participant 1 message Jul 1, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ixgbe:Make the function ixgbe_fwd_ring_down have a return type of void

This makes the function ixgbe_fwd_ring_down have a return type of void now due to this particular function always running successfully and never signalling it's caller with a error code when this function fails internally and for what reason.

---
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +2 -5
index 9aa6104..4efaeac 100644
@@ -4583,8 +4583,8 @@ static void ixgbe_disable_fwd_ring(struct ixgbe_fwd_adapter *vadapter,
 	rx_ring->l2_accel_priv = NULL;
 }
 
-static int ixgbe_fwd_ring_down(struct net_device *vdev,
-			       struct ixgbe_fwd_adapter *accel)
+static void ixgbe_fwd_ring_down(struct net_device *vdev,
+				struct ixgbe_fwd_adapter *accel)
 {
 	struct ixgbe_adapter *adapter = accel->real_adapter;
 	unsigned int rxbase = accel->rx_base_queue;
@@ -4602,9 +4602,6 @@ static int ixgbe_fwd_ring_down(struct net_device *vdev,
 		adapter->tx_ring[txbase + i]->l2_accel_priv = NULL;
 		adapter->tx_ring[txbase + i]->netdev = adapter->netdev;
 	}
-
-
-	return 0;
 }
 
 static int ixgbe_fwd_ring_up(struct net_device *vdev,
Signature · 1 line
2.1.4