Skip to contentSkip to conversation

commit 27f344eb15dd0da80ebec80c7245e8c85043f841

PATCH Applied Chris J Arges 4 participants 4 messages Jun 25, 2015 – Jul 1, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Please consider adding commit 27f344eb15dd0da80ebec80c7245e8c85043f841 to the following stable trees: 3.10.y 3.12.y 3.13.y-ckt 3.14.y

It is a clean cherry-pick for these series, and addresses an issue on Power systems under I/O stress and using the lpfc driver.

--

Quoted 1 line

From 27f344eb15dd0da80ebec80c7245e8c85043f841 Mon Sep 17 00:00:00 2001

From: James Smart <[email protected]>
Date: Wed, 7 May 2014 17:16:46 -0400
Subject: [PATCH] lpfc: Add iotag memory barrier

Add a memory barrier to ensure the valid bit is read before any of the cqe payload is read. This fixes an issue seen on Power where the cqe payload was getting loaded before the valid bit. When this occurred, we saw an iotag out of range error when a command completed, but since the iotag looked invalid the command didn't get completed to scsi core. Later we hit the command timeout, attempted to abort the command, then waited for the aborted command to get returned. Since the adapter already returned the command, we timeout waiting, and end up escalating EEH all the way to host reset. This patch fixes this issue.

---

 lpfc_sli.c |   21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
---
 drivers/scsi/lpfc/lpfc_sli.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
drivers/scsi/lpfc/lpfc_sli.c +21 -0
index 6bb51f8..393662c 100644
@@ -265,6 +265,16 @@ lpfc_sli4_eq_get(struct lpfc_queue *q)
 		return NULL;
 
 	q->hba_index = idx;
+
+	/*
+	 * insert barrier for instruction interlock : data from the hardware
+	 * must have the valid bit checked before it can be copied and acted
+	 * upon. Given what was seen in lpfc_sli4_cq_get() of speculative
+	 * instructions allowing action on content before valid bit checked,
+	 * add barrier here as well. May not be needed as "content" is a
+	 * single 32-bit entity here (vs multi word structure for cq's).
+	 */
+	mb();
 	return eqe;
 }
 
@@ -370,6 +380,17 @@ lpfc_sli4_cq_get(struct lpfc_queue *q)
 
 	cqe = q->qe[q->hba_index].cqe;
 	q->hba_index = idx;
+
+	/*
+	 * insert barrier for instruction interlock : data from the hardware
+	 * must have the valid bit checked before it can be copied and acted
+	 * upon. Speculative instructions were allowing a bcopy at the start
+	 * of lpfc_sli4_fp_handle_wcqe(), which is called immediately
+	 * after our return, to copy data before the valid bit check above
+	 * was done. As such, some of the copied data was stale. The barrier
+	 * ensures the check is before any data is copied.
+	 */
+	mb();
 	return cqe;
 }
 
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 5 lines · Chris J Arges

Please consider adding commit 27f344eb15dd0da80ebec80c7245e8c85043f841 to the following stable trees: 3.10.y 3.12.y 3.13.y-ckt 3.14.y

It is a clean cherry-pick for these series, and addresses an issue on Power systems under I/O stress and using the lpfc driver.

Thanks, now applied.

greg k-h

Applied
#2 lore raw
In reply to Chris J Arges
Quoted 2 lines · Chris J Arges

Please consider adding commit 27f344eb15dd0da80ebec80c7245e8c85043f841 to the following stable trees: 3.10.y 3.12.y 3.13.y-ckt 3.14.y

Applied to 3.12. Thanks.

Signature · 2 lines
js
suse labs
#3 lore raw
In reply to Chris J Arges
Quoted 6 lines · Chris J Arges

Please consider adding commit 27f344eb15dd0da80ebec80c7245e8c85043f841 to the following stable trees: 3.10.y 3.12.y 3.13.y-ckt 3.14.y

It is a clean cherry-pick for these series, and addresses an issue on Power systems under I/O stress and using the lpfc driver.

Quoted 8 lines

--

From 27f344eb15dd0da80ebec80c7245e8c85043f841 Mon Sep 17 00:00:00 2001
From: James Smart <[email protected]>
Date: Wed, 7 May 2014 17:16:46 -0400
Subject: [PATCH] lpfc: Add iotag memory barrier

Thanks Chris! Queued for 3.13-stable.

-Kamal