Skip to contentSkip to conversation

HID: wacom: Enable pad device for older Bamboo Touch tablets

PATCH Applied Jason Gerecke 2 participants 2 messages Jul 1, 2015 – Jul 8, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HID: wacom: Enable pad device for older Bamboo Touch tablets

Commit 862cf55 neglected to set the WACOM_DEVICETYPE_PAD flag for older two-finger Bamboo Touch tablets. Not only does this result in the pad device not appearing when such a tablet is plugged in, but also causes a segfault when 'wacom_bpt_touch' tries to send pad events. This patch adds the flag to resolve these issues.

---
 drivers/hid/wacom_wac.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/hid/wacom_wac.c +3 -0
index 232da89..0d24423 100644
@@ -2213,6 +2213,9 @@ void wacom_setup_device_quirks(struct wacom *wacom)
 			features->x_max = 4096;
 			features->y_max = 4096;
 		}
+		else if (features->pktlen == WACOM_PKGLEN_BBTOUCH) {
+			features->device_type |= WACOM_DEVICETYPE_PAD;
+		}
 	}
 
 	/*
Signature · 1 line
2.4.4
Applied
#1 lore raw
Quoted 7 lines · Jason Gerecke

Commit 862cf55 neglected to set the WACOM_DEVICETYPE_PAD flag for older two-finger Bamboo Touch tablets. Not only does this result in the pad device not appearing when such a tablet is plugged in, but also causes a segfault when 'wacom_bpt_touch' tries to send pad events. This patch adds the flag to resolve these issues.

Applied to for-4.2/upstream-fixes.

Signature · 2 lines
Jiri Kosina
SUSE Labs