Skip to contentSkip to conversation

Patch "net/mlx4_en: Release TX QP when destroying TX ring" has been added to the 4.1-stable tree

PATCH [email protected] 1 participant 1 message Jul 4, 2015

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

net/mlx4_en: Release TX QP when destroying TX ring

to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
net-mlx4_en-release-tx-qp-when-destroying-tx-ring.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Fri Jul 3 20:00:25 PDT 2015

From: Eran Ben Elisha <[email protected]>
Date: Thu, 25 Jun 2015 11:29:41 +0300
Subject: net/mlx4_en: Release TX QP when destroying TX ring

From: Eran Ben Elisha <[email protected]>

[ Upstream commit 0eb08514fdbdcd16fd6870680cd638f203662e9d ]

TX ring QP wasn't released at mlx4_en_destroy_tx_ring. Instead, the code used the deprecated base_tx_qpn field. Move TX QP release to mlx4_en_destroy_tx_ring and remove the base_tx_qpn field.

Fixes ddae0349fdb7 ('net/mlx4: Change QP allocation scheme')
---
 drivers/net/ethernet/mellanox/mlx4/en_netdev.c |    4 ----
 drivers/net/ethernet/mellanox/mlx4/en_tx.c     |    1 +
 drivers/net/ethernet/mellanox/mlx4/mlx4_en.h   |    1 -
 3 files changed, 1 insertion(+), 5 deletions(-)
drivers/net/ethernet/mellanox/mlx4/en_netdev.c +0 -4
@@ -1973,10 +1973,6 @@ void mlx4_en_free_resources(struct mlx4_
 			mlx4_en_destroy_cq(priv, &priv->rx_cq[i]);
 	}
 
-	if (priv->base_tx_qpn) {
-		mlx4_qp_release_range(priv->mdev->dev, priv->base_tx_qpn, priv->tx_ring_num);
-		priv->base_tx_qpn = 0;
-	}
 }
 
 int mlx4_en_alloc_resources(struct mlx4_en_priv *priv)
drivers/net/ethernet/mellanox/mlx4/en_tx.c +1 -0
@@ -180,6 +180,7 @@ void mlx4_en_destroy_tx_ring(struct mlx4
 		mlx4_bf_free(mdev->dev, &ring->bf);
 	mlx4_qp_remove(mdev->dev, &ring->qp);
 	mlx4_qp_free(mdev->dev, &ring->qp);
+	mlx4_qp_release_range(priv->mdev->dev, ring->qpn, 1);
 	mlx4_en_unmap_buffer(&ring->wqres.buf);
 	mlx4_free_hwq_res(mdev->dev, &ring->wqres, ring->buf_size);
 	kfree(ring->bounce_buf);
drivers/net/ethernet/mellanox/mlx4/mlx4_en.h +0 -1
@@ -579,7 +579,6 @@ struct mlx4_en_priv {
 	int vids[128];
 	bool wol;
 	struct device *ddev;
-	int base_tx_qpn;
 	struct hlist_head mac_hash[MLX4_EN_MAC_HASH_SIZE];
 	struct hwtstamp_config hwtstamp_config;
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.1/net-mlx4_en-release-tx-qp-when-destroying-tx-ring.patch