Skip to contentSkip to conversation

firmware.inc: fetch from SVN instead of Git

PATCH In review Jonathan Liu 5 participants 11 messages Jul 4, 2015 – Jul 10, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firmware.inc: fetch from SVN instead of Git

Reduces the download time significantly.

---
 recipes-bsp/common/firmware.inc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
recipes-bsp/common/firmware.inc +3 -3
index ad3176a..100df3a 100644
@@ -1,7 +1,7 @@
-RPIFW_SRCREV ?= "e42a747e8d5c4a2fb3e837d0924c7cc39999936a"
+RPIFW_SRCREV ?= "461"
 RPIFW_DATE ?= "20150206"
-RPIFW_SRC_URI ?= "git://github.com/raspberrypi/firmware.git;protocol=git;branch=master"
-RPIFW_S ?= "${WORKDIR}/git"
+RPIFW_SRC_URI ?= "svn://github.com/raspberrypi/firmware;protocol=https;module=trunk"
+RPIFW_S ?= "${WORKDIR}/trunk"
 
 SRC_URI = "${RPIFW_SRC_URI}"
 SRCREV = "${RPIFW_SRCREV}"
Signature · 1 line
2.4.4
#1 lore raw

Hi Jonathan,

Quoted 13 lines · Jonathan Liu

Reduces the download time significantly.

---
  recipes-bsp/common/firmware.inc | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
recipes-bsp/common/firmware.inc +0 -0
index ad3176a..100df3a 100644

recipes-bsp/common/firmware.inc line 7

Quoted 10 lines
recipes-bsp/common/firmware.inc +3 -3
@@ -1,7 +1,7 @@
-RPIFW_SRCREV ?= "e42a747e8d5c4a2fb3e837d0924c7cc39999936a"
+RPIFW_SRCREV ?= "461"
  RPIFW_DATE ?= "20150206"
-RPIFW_SRC_URI ?= "git://github.com/raspberrypi/firmware.git;protocol=git;branch=master"
-RPIFW_S ?= "${WORKDIR}/git"
+RPIFW_SRC_URI ?= "svn://github.com/raspberrypi/firmware;protocol=https;module=trunk"
+RPIFW_S ?= "${WORKDIR}/trunk"
 
  SRC_URI = "${RPIFW_SRC_URI}"
  SRCREV = "${RPIFW_SRCREV}"

Just tested the download times for this repo:

git (deep clone): 24m
svn: 3m8s
git (shallow clone): 40s

Isn't it possible to use "--depth 1" for git clone? I would rather prefer seeing this instead of just giving up and going back to svn...

Regards,
Nikolay

#2 lore raw
Quoted 35 lines · Nikolay Dimitrov

Hi Jonathan,

Quoted 22 lines · Jonathan Liu

Reduces the download time significantly.

---
  recipes-bsp/common/firmware.inc | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
recipes-bsp/common/firmware.inc +1 -2
index ad3176a..100df3a 100644
@@ -1,7 +1,7 @@
-RPIFW_SRCREV ?= "e42a747e8d5c4a2fb3e837d0924c7cc39999936a"
+RPIFW_SRCREV ?= "461"
  RPIFW_DATE ?= "20150206"
-RPIFW_SRC_URI ?= 

"git://github.com/raspberrypi/firmware.git;protocol=git;branch=master"

recipes-bsp/common/firmware.inc +1 -1
-RPIFW_S ?= "${WORKDIR}/git"
+RPIFW_SRC_URI ?= 

"svn://github.com/raspberrypi/firmware;protocol=https;module=trunk" +RPIFW_S ?= "${WORKDIR}/trunk"

Quoted 3 lines
  SRC_URI = "${RPIFW_SRC_URI}"
  SRCREV = "${RPIFW_SRCREV}"

Just tested the download times for this repo:

git (deep clone): 24m
svn: 3m8s
git (shallow clone): 40s

Quoted 5 lines

Isn't it possible to use "--depth 1" for git clone? I would rather prefer seeing this instead of just giving up and going back to svn...

Regards,
Nikolay

Jonathan, I understand your problem, I have pointed out "https://github.com/raspberrypi/firmware/archive/${RPIFW_SRCREV}.zip" ontop of HEAD when building in order to get rid of this problem. But I agree with Nikolay that going back to svn feels like a step in the wrong direction and instead we should push for a changle like the one discussed in the thread: '[yocto] [meta-raspberrypi][PATCH] firmware.inc: Fetch a zip instead of cloning a git repo'

or by using "--depth=1" (which isn't supported in the bitbake git fetcher for the moment..).

I will try to push for that one of the solutions (--depth=1 or .zip) is merged soon so we once for all can get rid of this annoying problem.

BR,
Petter

#3 lore raw
In reply to Nikolay Dimitrov

Hi Nikolay,

Quoted 35 lines · Nikolay Dimitrov

Hi Jonathan,

Quoted 22 lines · Jonathan Liu

Reduces the download time significantly.

---
  recipes-bsp/common/firmware.inc | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
recipes-bsp/common/firmware.inc +1 -2
index ad3176a..100df3a 100644
@@ -1,7 +1,7 @@
-RPIFW_SRCREV ?= "e42a747e8d5c4a2fb3e837d0924c7cc39999936a"
+RPIFW_SRCREV ?= "461"
  RPIFW_DATE ?= "20150206"
-RPIFW_SRC_URI ?= 

"git://github.com/raspberrypi/firmware.git;protocol=git;branch=master"

recipes-bsp/common/firmware.inc +1 -1
-RPIFW_S ?= "${WORKDIR}/git"
+RPIFW_SRC_URI ?= 

"svn://github.com/raspberrypi/firmware;protocol=https;module=trunk" +RPIFW_S ?= "${WORKDIR}/trunk"

Quoted 3 lines
  SRC_URI = "${RPIFW_SRC_URI}"
  SRCREV = "${RPIFW_SRCREV}"

Just tested the download times for this repo:

git (deep clone): 24m
svn: 3m8s
git (shallow clone): 40s

Quoted 5 lines

Isn't it possible to use "--depth 1" for git clone? I would rather prefer seeing this instead of just giving up and going back to svn...

Regards,
Nikolay

How would you clone a specific Git revision using --depth 1?

Regards,
Jonathan

#4 lore raw

Hi Jonathan,

Quoted 42 lines · Jonathan Liu

Hi Nikolay,

Quoted 39 lines · Nikolay Dimitrov

Hi Jonathan,

Quoted 23 lines · Jonathan Liu

Reduces the download time significantly.

---
  recipes-bsp/common/firmware.inc | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
recipes-bsp/common/firmware.inc +1 -2
index ad3176a..100df3a 100644
@@ -1,7 +1,7 @@
-RPIFW_SRCREV ?= "e42a747e8d5c4a2fb3e837d0924c7cc39999936a"
+RPIFW_SRCREV ?= "461"
  RPIFW_DATE ?= "20150206"
-RPIFW_SRC_URI ?=

"git://github.com/raspberrypi/firmware.git;protocol=git;branch=master"

recipes-bsp/common/firmware.inc +1 -1
-RPIFW_S ?= "${WORKDIR}/git"
+RPIFW_SRC_URI ?=

"svn://github.com/raspberrypi/firmware;protocol=https;module=trunk" +RPIFW_S ?= "${WORKDIR}/trunk"

Quoted 3 lines
  SRC_URI = "${RPIFW_SRC_URI}"
  SRCREV = "${RPIFW_SRCREV}"

Just tested the download times for this repo:

git (deep clone): 24m
svn: 3m8s
git (shallow clone): 40s

Isn't it possible to use "--depth 1" for git clone? I would rather prefer seeing this instead of just giving up and going back to svn...

Quoted 6 lines
Quoted 2 lines

Regards,
Nikolay

How would you clone a specific Git revision using --depth 1?

Regards,
Jonathan

git fetch --depth=1 git://repo.git $SHA1

Available in the latest git code.

A point to be made is that this feature requires cooperation from the server side (uploadpack.allowReachableSHA1InWant config variable) which can complicate thing somewhat, but we can probably start pushing the server provider to accelerate the process :D.

Regards,
Nikolay

#5 lore raw
Quoted 4 lines · Nikolay Dimitrov

git fetch --depth=1 git://repo.git $SHA1

Available in the latest git code.

How latest, remembering that oe-core supports LTS distros which are likely to have old releases of git.

Ross

#6 lore raw
Quoted 3 lines · Ross

How latest, remembering that oe-core supports LTS distros which are likely to have old releases of git.

Assuming I'm driving it correctly:

[git init, git remote add origin ...]

$ git fetch  --depth=1 origin beeafee030a38380c65a9a664003ba50f87aefbf
error: no such remote ref beeafee030a38380c65a9a664003ba50f87aefbf
$ git --version
git version 2.1.4

That's with the latest Debian release.

Ross

#7 lore raw

Hi Ross,

Quoted 11 lines · Ross

On 6 July 2015 at 17:23, Burton, Ross <[email protected] <mailto:[email protected]>> wrote:

How latest, remembering that oe-core supports LTS distros which are likely to have old releases of git.

Assuming I'm driving it correctly:

[git init, git remote add origin ...]

Quoted 8 lines
$ git fetch  --depth=1 origin beeafee030a38380c65a9a664003ba50f87aefbf
error: no such remote ref beeafee030a38380c65a9a664003ba50f87aefbf
$ git --version
git version 2.1.4

That's with the latest Debian release.

Ross

Well, the commits that add this feature are from May-June.2015. I fully agree with you that LTS is a factor that can't be ignored.

Kind regards,
Nikolay

#8 lore raw

Hi Ross,

Quoted 21 lines · Nikolay Dimitrov

Hi Ross,

Quoted 18 lines · Ross

On 6 July 2015 at 17:23, Burton, Ross <[email protected] <mailto:[email protected]>> wrote:

How latest, remembering that oe-core supports LTS distros which are likely to have old releases of git.

Assuming I'm driving it correctly:

[git init, git remote add origin ...]

$ git fetch  --depth=1 origin beeafee030a38380c65a9a664003ba50f87aefbf
error: no such remote ref beeafee030a38380c65a9a664003ba50f87aefbf
$ git --version
git version 2.1.4

That's with the latest Debian release.

Quoted 7 lines
Quoted 1 line

Ross

Well, the commits that add this feature are from May-June.2015. I fully agree with you that LTS is a factor that can't be ignored.

Kind regards,
Nikolay

Forgot to answer you question - the expected versions to include this feature are 2.5.0/2.5.1.

Regards,
Nikolay

#9 lore raw
Quoted 32 lines · Nikolay Dimitrov

Hi Ross,

Quoted 28 lines · Nikolay Dimitrov

Hi Ross,

Quoted 11 lines · Ross

On 6 July 2015 at 17:23, Burton, Ross <[email protected] <mailto:[email protected]>> wrote:

How latest, remembering that oe-core supports LTS distros which are likely to have old releases of git.

Assuming I'm driving it correctly:

[git init, git remote add origin ...]

Quoted 9 lines
$ git fetch  --depth=1 origin beeafee030a38380c65a9a664003ba50f87aefbf
error: no such remote ref beeafee030a38380c65a9a664003ba50f87aefbf
$ git --version
git version 2.1.4

That's with the latest Debian release.

Ross

Well, the commits that add this feature are from May-June.2015. I fully agree with you that LTS is a factor that can't be ignored.

Quoted 8 lines
Quoted 3 lines

Kind regards,
Nikolay

Forgot to answer you question - the expected versions to include this feature are 2.5.0/2.5.1.

So there is no support for depth clones until 2.5.0? I didn't really understand.

--
Andrei Gherzan

#10 lore raw

Hi Andrei,

Quoted 45 lines · Andrei Gherzan

On Mon, Jul 6, 2015 at 6:59 PM, Nikolay Dimitrov <[email protected] <mailto:[email protected]>> wrote:

Hi Ross,

On 07/06/2015 07:58 PM, Nikolay Dimitrov wrote:

Hi Ross,

On 07/06/2015 07:26 PM, Burton, Ross wrote:

On 6 July 2015 at 17:23, Burton, Ross <[email protected] <mailto:[email protected]> <mailto:[email protected] <mailto:[email protected]>>> wrote:

How latest, remembering that oe-core supports LTS
distros which are
likely to have old releases of git.

Assuming I'm driving it correctly:

[git init, git remote add origin ...] $ git fetch --depth=1 origin beeafee030a38380c65a9a664003ba50f87aefbf
error: no such remote ref beeafee030a38380c65a9a664003ba50f87aefbf $ git --version
git version 2.1.4

That's with the latest Debian release.

Ross

Well, the commits that add this feature are from May-June.2015. I fully
agree with you that LTS is a factor that can't be ignored.

Kind regards,
Nikolay

Quoted 6 lines

Forgot to answer you question - the expected versions to include this feature are 2.5.0/2.5.1. <http://2.5.1.>

So there is no support for depth clones until 2.5.0? I didn't really understand.

Well, shallow clones are supported but only for branch tips, which is not what we need. This feature for shallow cloning a specific revision is available only in git 2.5.0+. Also, this feature needs a server-side configuration option to be enabled, in order to work properly.

Regards,
Nikolay