Skip to contentSkip to conversation

net: phy: add dependency on HAS_IOMEM to MDIO_BUS_MUX_MMIOREG

PATCH Applied Rob Herring 3 participants 3 messages Jul 5, 2015 – Jul 8, 2015

Subsystems (3)
Networking Network drivers Ethernet PHY
lore
Share & tools
lore

Rob Herring

author
#0 lore raw

PATCH 1/1 net: phy: add dependency on HAS_IOMEM to MDIO_BUS_MUX_MMIOREG

On UML builds, mdio-mux-mmioreg.c fails to compile:

drivers/net/phy/mdio-mux-mmioreg.c:50:3: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration] drivers/net/phy/mdio-mux-mmioreg.c:63:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]

This is due to CONFIG_OF now being user selectable. Add a dependency on HAS_IOMEM to fix this.

Signed-off-by Rob Herring <[email protected]>
Cc Florian Fainelli <[email protected]>
Cc David S. Miller <[email protected]>
---
 drivers/net/phy/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/phy/Kconfig +1 -1
index cf18940..cb86d7a 100644
@@ -191,7 +191,7 @@ config MDIO_BUS_MUX_GPIO
 
 config MDIO_BUS_MUX_MMIOREG
 	tristate "Support for MMIO device-controlled MDIO bus multiplexers"
-	depends on OF_MDIO
+	depends on OF_MDIO && HAS_IOMEM
 	select MDIO_BUS_MUX
 	help
 	  This module provides a driver for MDIO bus multiplexers that
Signature · 1 line
2.1.0
Reviewed-by on v1 1/1
#1 lore raw

2015-07-05 10:16 GMT-07:00 Rob Herring <[email protected]>:

Quoted 9 lines

On UML builds, mdio-mux-mmioreg.c fails to compile:

drivers/net/phy/mdio-mux-mmioreg.c:50:3: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration] drivers/net/phy/mdio-mux-mmioreg.c:63:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]

This is due to CONFIG_OF now being user selectable. Add a dependency on HAS_IOMEM to fix this.

Signed-off-by Rob Herring <[email protected]>
Reviewed-by Florian Fainelli <[email protected]>
Quoted 22 lines
Cc Florian Fainelli <[email protected]>
Cc David S. Miller <[email protected]>
---
 drivers/net/phy/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/phy/Kconfig +1 -2
index cf18940..cb86d7a 100644
@@ -191,7 +191,7 @@ config MDIO_BUS_MUX_GPIO
 
 config MDIO_BUS_MUX_MMIOREG
        tristate "Support for MMIO device-controlled MDIO bus multiplexers"
-       depends on OF_MDIO
+       depends on OF_MDIO && HAS_IOMEM
        select MDIO_BUS_MUX
        help
          This module provides a driver for MDIO bus multiplexers that
--

2.1.0

Signature · 1 line
Florian
maintainer Applied
#2 lore raw
In reply to Rob Herring

From: Rob Herring <[email protected]>
Date: Sun, 5 Jul 2015 12:16:27 -0500

Quoted 9 lines

On UML builds, mdio-mux-mmioreg.c fails to compile:

drivers/net/phy/mdio-mux-mmioreg.c:50:3: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration] drivers/net/phy/mdio-mux-mmioreg.c:63:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]

This is due to CONFIG_OF now being user selectable. Add a dependency on HAS_IOMEM to fix this.

Signed-off-by Rob Herring <[email protected]>

Applied, thanks.