Skip to contentSkip to conversation

ALSA: hda - add codec ID for Broxton display audio codec

PATCH In review [email protected] 2 participants 3 messages Jul 6, 2015 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda - add codec ID for Broxton display audio codec

From: Libin Yang <[email protected]>

This patch adds codec ID (0x8086280a) and module alias for Broxton display codec.

---
 sound/pci/hda/patch_hdmi.c | 2 ++
 1 file changed, 2 insertions(+)
sound/pci/hda/patch_hdmi.c +2 -0
index 2f24338..9515891 100644
@@ -3527,6 +3527,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
 { .id = 0x80862807, .name = "Haswell HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x80862808, .name = "Broadwell HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x80862809, .name = "Skylake HDMI",	.patch = patch_generic_hdmi },
+{ .id = 0x8086280a, .name = "Broxton HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x80862880, .name = "CedarTrail HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x80862882, .name = "Valleyview2 HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x80862883, .name = "Braswell HDMI",	.patch = patch_generic_hdmi },
@@ -3591,6 +3592,7 @@ MODULE_ALIAS("snd-hda-codec-id:80862806");
 MODULE_ALIAS("snd-hda-codec-id:80862807");
 MODULE_ALIAS("snd-hda-codec-id:80862808");
 MODULE_ALIAS("snd-hda-codec-id:80862809");
+MODULE_ALIAS("snd-hda-codec-id:8086280a");
 MODULE_ALIAS("snd-hda-codec-id:80862880");
 MODULE_ALIAS("snd-hda-codec-id:80862882");
 MODULE_ALIAS("snd-hda-codec-id:80862883");
Signature · 1 line
1.9.1
#1 lore raw

At Mon, 6 Jul 2015 10:44:26 +0800,

Quoted 7 lines · [email protected] wrote:

From: Libin Yang <[email protected]>

This patch adds codec ID (0x8086280a) and module alias for Broxton display codec.

I applied this now, but don't you need the workaround for haswell+?

thanks,

Takashi

Quoted 27 lines
---
 sound/pci/hda/patch_hdmi.c | 2 ++
 1 file changed, 2 insertions(+)
sound/pci/hda/patch_hdmi.c +2 -0
index 2f24338..9515891 100644
@@ -3527,6 +3527,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
 { .id = 0x80862807, .name = "Haswell HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x80862808, .name = "Broadwell HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x80862809, .name = "Skylake HDMI",	.patch = patch_generic_hdmi },
+{ .id = 0x8086280a, .name = "Broxton HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x80862880, .name = "CedarTrail HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x80862882, .name = "Valleyview2 HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x80862883, .name = "Braswell HDMI",	.patch = patch_generic_hdmi },
@@ -3591,6 +3592,7 @@ MODULE_ALIAS("snd-hda-codec-id:80862806");
 MODULE_ALIAS("snd-hda-codec-id:80862807");
 MODULE_ALIAS("snd-hda-codec-id:80862808");
 MODULE_ALIAS("snd-hda-codec-id:80862809");
+MODULE_ALIAS("snd-hda-codec-id:8086280a");
 MODULE_ALIAS("snd-hda-codec-id:80862880");
 MODULE_ALIAS("snd-hda-codec-id:80862882");
 MODULE_ALIAS("snd-hda-codec-id:80862883");
Signature · 1 line
1.9.1
#2 lore raw

Hi Takashi,

Quoted 11 lines

-----Original Message-----
From: Takashi Iwai [mailto:[email protected]]
Sent: Monday, July 06, 2015 4:38 PM
To: Yang, Libin
Cc: [email protected]
Subject: Re: [PATCH] ALSA: hda - add codec ID for Broxton display audio codec

At Mon, 6 Jul 2015 10:44:26 +0800,

Quoted 1 line · [email protected] wrote:
Quoted 8 lines
Quoted 6 lines

From: Libin Yang <[email protected]>

This patch adds codec ID (0x8086280a) and module alias for Broxton display codec.

I applied this now, but don't you need the workaround for haswell+?

Yes, I believe we need the workaround. As we currently don't have a platform to test, I do not make the workaround patch.

I will make the patch when I get a platform to test.

Quoted 43 lines

thanks,

Takashi

Review

Quoted 5 lines
---
 sound/pci/hda/patch_hdmi.c | 2 ++
 1 file changed, 2 insertions(+)
(quoted diff) +0 -0

b/sound/pci/hda/patch_hdmi.c

sound/pci/hda/patch_hdmi.c static const struct hda_codec_preset

Quoted 4 lines

index 2f24338..9515891 100644

sound/pci/hda/patch_hdmi.c +0 -0
@@ -3527,6 +3527,7 @@ static const struct hda_codec_preset

snd_hda_preset_hdmi[] = {

sound/pci/hda/patch_hdmi.c static const struct hda_codec_preset · line 3527

Quoted 1 line
sound/pci/hda/patch_hdmi.c +0 -0
 { .id = 0x80862807, .name = "Haswell HDMI",	.patch =

patch_generic_hdmi },

sound/pci/hda/patch_hdmi.c static const struct hda_codec_preset · line 3528

Quoted 1 line
sound/pci/hda/patch_hdmi.c +0 -0
 { .id = 0x80862808, .name = "Broadwell HDMI",	.patch =

patch_generic_hdmi },

sound/pci/hda/patch_hdmi.c static const struct hda_codec_preset · line 3529

Quoted 1 line
sound/pci/hda/patch_hdmi.c +0 -0
 { .id = 0x80862809, .name = "Skylake HDMI",	.patch =

patch_generic_hdmi },

sound/pci/hda/patch_hdmi.c static const struct hda_codec_preset · line 3530

Quoted 1 line
sound/pci/hda/patch_hdmi.c +1 -0
+{ .id = 0x8086280a, .name = "Broxton HDMI",	.patch =

patch_generic_hdmi },

sound/pci/hda/patch_hdmi.c static const struct hda_codec_preset · line 3531

Quoted 1 line
sound/pci/hda/patch_hdmi.c +0 -0
 { .id = 0x80862880, .name = "CedarTrail HDMI",	.patch =

patch_generic_hdmi },

sound/pci/hda/patch_hdmi.c static const struct hda_codec_preset · line 3532

Quoted 1 line
sound/pci/hda/patch_hdmi.c +0 -0
 { .id = 0x80862882, .name = "Valleyview2 HDMI",	.patch =

patch_generic_hdmi },

sound/pci/hda/patch_hdmi.c static const struct hda_codec_preset · line 3533

Quoted 1 line
sound/pci/hda/patch_hdmi.c +0 -0
 { .id = 0x80862883, .name = "Braswell HDMI",	.patch =

patch_generic_hdmi },

sound/pci/hda/patch_hdmi.c MODULE_ALIAS("snd-hda-codec-

Quoted 1 line
sound/pci/hda/patch_hdmi.c +0 -0
@@ -3591,6 +3592,7 @@ MODULE_ALIAS("snd-hda-codec-

id:80862806");

Quoted 10 lines
sound/pci/hda/patch_hdmi.c +1 -1
 MODULE_ALIAS("snd-hda-codec-id:80862807");
 MODULE_ALIAS("snd-hda-codec-id:80862808");
 MODULE_ALIAS("snd-hda-codec-id:80862809");
+MODULE_ALIAS("snd-hda-codec-id:8086280a");
 MODULE_ALIAS("snd-hda-codec-id:80862880");
 MODULE_ALIAS("snd-hda-codec-id:80862882");
 MODULE_ALIAS("snd-hda-codec-id:80862883");
--

1.9.1