Patch "vfs: Remove incorrect debugging WARN in prepend_path" has been added to the 4.1-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
vfs: Remove incorrect debugging WARN in prepend_path
to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
vfs-remove-incorrect-debugging-warn-in-prepend_path.patch
and it can be found in the queue-4.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
93e3bce6287e1fb3e60d3324ed08555b5bbafa89Mon Sep 17 00:00:00 2001
From: "Eric W. Biederman" <[email protected]>
Date: Sun, 24 May 2015 09:25:00 -0500
Subject: vfs: Remove incorrect debugging WARN in prepend_path
From: "Eric W. Biederman" <[email protected]>
commit 93e3bce6287e1fb3e60d3324ed08555b5bbafa89 upstream.
The warning message in prepend_path is unclear and outdated. It was added as a warning that the mechanism for generating names of pseudo files had been removed from prepend_path and d_dname should be used instead. Unfortunately the warning reads like a general warning, making it unclear what to do with it.
Remove the warning. The transition it was added to warn about is long over, and I added code several years ago which in rare cases causes the warning to fire on legitimate code, and the warning is now firing and scaring people for no good reason.
--- fs/dcache.c | 11 ----------- 1 file changed, 11 deletions(-)
fs/dcache.c +0 -11
@@ -2927,17 +2927,6 @@ restart: vfsmnt = &mnt->mnt;continue ; } -/* -* Filesystems needing to implement special "root names" -* should do so with ->d_dname() -*/ -if (IS_ROOT (dentry) && - (dentry->d_name.len !=1 || - dentry->d_name.name[0 ] !='/' )) { -WARN (1 ,"Root dentry has weird name <%.*s>\n" , - (int ) dentry->d_name.len, - dentry->d_name.name); - }if (!error) error =is_mounted (vfsmnt) ?1 :2 ;break ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.1/vfs-ignore-unlocked-mounts-in-fs_fully_visible.patch queue-4.1/vfs-remove-incorrect-debugging-warn-in-prepend_path.patch