Skip to contentSkip to conversation

Staging: android: ion: fixed a blank line after declarations coding style issue

PATCH Superseded rcodin 4 participants 5 messages Jul 9, 2015 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

rcodin

author
#0 lore raw

PATCH 1/1 Staging: android: ion: fixed a blank line after declarations coding style issue

From: Ronit Halder <[email protected]>

Fixed a coding style issue.

---
 drivers/staging/android/ion/ion.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/android/ion/ion.c +1 -0
index 6f48112..e44f5e6 100644
@@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
 	struct ion_buffer *buffer;
 	struct dma_buf *dmabuf;
 	bool valid_handle;
+
 	DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
 
 	mutex_lock(&client->lock);
Signature · 1 line
1.9.1
#1 lore raw
Quoted 1 line · rcodin

From: Ronit Halder <[email protected]>

You do not need a From: here. Please fix your gitconfig file and git send-email will give your name correctly in the email header.

regards
sudip

#2 lore raw
Quoted 8 lines · Sudip Mukherjee
Quoted 1 line · rcodin

From: Ronit Halder <[email protected]>

You do not need a From: here. Please fix your gitconfig file and git send-email will give your name correctly in the email header.

regards
sudip

thanks for pointing it sudip.
Sorry for the stupid mistake, version 2 of the patch is coming.

maintainer
#3 lore raw
In reply to rcodin
Quoted 14 lines · rcodin

From: Ronit Halder <[email protected]>

Fixed a coding style issue.

---
 drivers/staging/android/ion/ion.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/android/ion/ion.c +0 -0
index 6f48112..e44f5e6 100644

drivers/staging/android/ion/ion.c struct dma_buf *ion_share_dma_buf(struct ion_client *client, · line 1110

Quoted 5 lines
drivers/staging/android/ion/ion.c +1 -0
@@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
 	struct ion_buffer *buffer;
 	struct dma_buf *dmabuf;
 	bool valid_handle;
+
 	DEFINE_DMA_BUF_EXPORT_INFO(exp_info);

This is a false positive and has been rejected so many times it's really getting old...

#4 lore raw
Quoted 2 lines · Greg KH
Quoted 1 line · rcodin

Fixed a coding style issue.

[]

Quoted 1 line

drivers/staging/android/ion/ion.c

Quoted 1 line
drivers/staging/android/ion/ion.c +0 -0

[]

Quoted 9 lines
(quoted diff) +0 -0
@@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
 >  	struct ion_buffer *buffer;
 >  	struct dma_buf *dmabuf;
 >  	bool valid_handle;

drivers/staging/android/ion/ion.c struct dma_buf *ion_share_dma_buf(struct ion_client *client, · line 1110

Quoted 2 lines
drivers/staging/android/ion/ion.c +1 -0
+
 	DEFINE_DMA_BUF_EXPORT_INFO(exp_info);

This is a false positive and has been rejected so many times it's really getting old...

There's a checkpatch patch for that that'll eventually get applied.

https://lkml.org/lkml/2015/7/1/383