Skip to contentSkip to conversation

regulator: qcom_spmi-regulator: Use DIV_ROUND_UP instead of open-coded

PATCH In review Axel Lin 3 participants 3 messages Jul 9, 2015 – Jul 10, 2015

Subsystems (2)
Arm Qualcomm mailing list Voltage and current regulator framework
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: qcom_spmi-regulator: Use DIV_ROUND_UP instead of open-coded

Signed-off-by Axel Lin <[email protected]>
---
 drivers/regulator/qcom_spmi-regulator.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/regulator/qcom_spmi-regulator.c +1 -2
index 850a30a..9ef0e2f 100644
@@ -504,8 +504,7 @@ static int spmi_regulator_select_voltage(struct spmi_regulator *vreg,
 	 * Force uV to be an allowed set point by applying a ceiling function to
 	 * the uV value.
 	 */
-	*voltage_sel = (uV - range->min_uV + range->step_uV - 1)
-			/ range->step_uV;
+	*voltage_sel = DIV_ROUND_UP(uV - range->min_uV, range->step_uV);
 	uV = *voltage_sel * range->step_uV + range->min_uV;
 
 	if (uV > max_uV) {
Signature · 1 line
2.1.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Axel Lin
Signed-off-by Axel Lin <[email protected]>
---
 drivers/regulator/qcom_spmi-regulator.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by Andy Gross <[email protected]>
Signature · 3 lines
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
maintainer
#2 lore raw

Applied "regulator: qcom_spmi-regulator: Use DIV_ROUND_UP instead of open-coded" to the regulator tree

In reply to Axel Lin

The patch

regulator: qcom_spmi-regulator: Use DIV_ROUND_UP instead of open-coded

has been applied to the regulator tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 5d506a5ad4155e813d254d2f02ce17b58045423c Mon Sep 17 00:00:00 2001

From: Axel Lin <[email protected]>
Date: Thu, 9 Jul 2015 16:48:50 +0800
Subject: [PATCH] regulator: qcom_spmi-regulator: Use DIV_ROUND_UP instead of
open-coded

Signed-off-by Axel Lin <[email protected]>
Reviewed-by Andy Gross <[email protected]>
Signed-off-by Mark Brown <[email protected]>
---
 drivers/regulator/qcom_spmi-regulator.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/regulator/qcom_spmi-regulator.c +1 -2
index 850a30a95b5b..9ef0e2f28ec4 100644
@@ -504,8 +504,7 @@ static int spmi_regulator_select_voltage(struct spmi_regulator *vreg,
 	 * Force uV to be an allowed set point by applying a ceiling function to
 	 * the uV value.
 	 */
-	*voltage_sel = (uV - range->min_uV + range->step_uV - 1)
-			/ range->step_uV;
+	*voltage_sel = DIV_ROUND_UP(uV - range->min_uV, range->step_uV);
 	uV = *voltage_sel * range->step_uV + range->min_uV;
 
 	if (uV > max_uV) {
Signature · 1 line
2.1.4