drm/i915: storm detection documentation update
Subsystems (2)
PATCH 1/1 drm/i915: storm detection documentation update
From: "Thulasimani,Sivakumar" <[email protected]>
Update the hotplug documentation to explain that hotplug storm is not expected for Display port panels and hence is not handled in current code.
v2: update the statements as recommended by Daniel
--- drivers/gpu/drm/i915/intel_hotplug.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/gpu/drm/i915/intel_hotplug.c +8 -0
@@ -66,6 +66,14 @@* while before being re-enabled. The intention is to mitigate issues raising * from broken hardware triggering massive amounts of interrupts and grinding * the system to a halt. +* +* Current implementation expects that hotplug interrupt storm will not be +* seen when display port sink is connected, hence on platforms whose DP +* callback is handled by i915_digport_work_func reenabling of hpd is not +* performed (it was never expected to be disabled in the first place ;) ) +* this is specific to DP sinks handled by this routine and any other display +* such as HDMI or DVI enabled on the same port will have proper logic since +* it will use i915_hotplug_work_func where this logic is handled. */ enum port intel_hpd_pin_to_port (enum hpd_pin pin)
Signature · 6 lines
1.7.9.5 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Task id: 6770 -------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
ILK 303/303 303/303
SNB +3 309/316 312/316
IVB 343/343 343/343
BYT -1 285/285 284/285
HSW +13 367/381 380/381
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
*SNB igt@kms_mmio_vs_cs_flip@setcrtc_vs_cs_flip DMESG_WARN(1) PASS(1) *SNB igt@kms_mmio_vs_cs_flip@setplane_vs_cs_flip DMESG_WARN(1) PASS(1) *SNB igt@pm_rpm@cursor DMESG_WARN(1) PASS(1) *SNB igt@pm_rpm@cursor-dpms DMESG_FAIL(1) FAIL(1) *BYT igt@gem_tiled_partial_pwrite_pread@reads PASS(1) FAIL(1) *HSW igt@kms_mmio_vs_cs_flip@setplane_vs_cs_flip DMESG_WARN(1) PASS(1) *HSW igt@pm_lpsp@non-edp DMESG_WARN(1) PASS(1) *HSW igt@pm_rpm@debugfs-read DMESG_WARN(1) PASS(1) *HSW igt@pm_rpm@gem-idle DMESG_WARN(1) PASS(1) *HSW igt@pm_rpm@gem-mmap-gtt DMESG_WARN(1) PASS(1) *HSW igt@pm_rpm@gem-pread DMESG_WARN(1) PASS(1) *HSW igt@pm_rpm@i2c DMESG_WARN(1) PASS(1) *HSW igt@pm_rpm@modeset-non-lpsp DMESG_WARN(1) PASS(1) *HSW igt@pm_rpm@modeset-non-lpsp-stress-no-wait DMESG_WARN(1) PASS(1) *HSW igt@pm_rpm@pci-d3-state DMESG_WARN(1) PASS(1) *HSW igt@pm_rpm@reg-read-ioctl DMESG_WARN(1) PASS(1) *HSW igt@pm_rpm@rte DMESG_WARN(1) PASS(1) *HSW igt@pm_rpm@sysfs-read DMESG_WARN(1) PASS(1)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list [email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter
AppliedQuoted 9 lines · Sivakumar Thulasimani
From: "Thulasimani,Sivakumar" <[email protected]>
Update the hotplug documentation to explain that hotplug storm is not expected for Display port panels and hence is not handled in current code.
v2: update the statements as recommended by Daniel
Signed-off-by Sivakumar Thulasimani <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Quoted 30 lines
--- drivers/gpu/drm/i915/intel_hotplug.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/gpu/drm/i915/intel_hotplug.c +8
-0@@ -66,6 +66,14 @@* while before being re-enabled. The intention is to mitigate issues raising * from broken hardware triggering massive amounts of interrupts and grinding * the system to a halt. +* +* Current implementation expects that hotplug interrupt storm will not be +* seen when display port sink is connected, hence on platforms whose DP +* callback is handled by i915_digport_work_func reenabling of hpd is not +* performed (it was never expected to be disabled in the first place ;) ) +* this is specific to DP sinks handled by this routine and any other display +* such as HDMI or DVI enabled on the same port will have proper logic since +* it will use i915_hotplug_work_func where this logic is handled. */ enum port intel_hpd_pin_to_port (enum hpd_pin pin)Signature · 6 lines
1.7.9.5 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx