Remove clk.h from clk-provider.h (non-clk drivers part)
Subsystems (13)
cover Remove clk.h from clk-provider.h (non-clk drivers part)
This is the second set in a series of patches that removes clk.h from clk-provider.h. This allows us to clearly see what provider drivers are using the consumer API (clk.h) by checking the includes. Currently clk.h is included by clk-provider.h even though it doesn't need to so quite a few clk provider drivers are relying on the implicit include.
Stephen Boyd (7):
powerpc/512x: clk: Include clk.h
staging: clocking-wizard: Include clk.h
spi: spi-pxa2xx: Remove clk.h include
clocksource: cadence_ttc: Remove clk-provider.h include
ACPI: Remove clk.h include
simplefb: Include clk.h
lib/vsprintf.c: Include clk.h
arch/powerpc/platforms/512x/clock-commonclk.c | 1 + drivers/acpi/acpi_apd.c | 1 - drivers/acpi/acpi_lpss.c | 1 - drivers/clocksource/cadence_ttc_timer.c | 1 - drivers/spi/spi-pxa2xx-pci.c | 1 - drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 + drivers/video/fbdev/simplefb.c | 1 + lib/vsprintf.c | 1 + 8 files changed, 4 insertions(+), 4 deletions(-)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH 1/7 powerpc/512x: clk: Include clk.h
This clock provider uses the consumer API, so include clk.h explicitly.
---
Please ack so this can go through the clk-tree.
arch/powerpc/platforms/512x/clock-commonclk.c | 1 + 1 file changed, 1 insertion(+)
arch/powerpc/platforms/512x/clock-commonclk.c +1 -0
@@ -12,6 +12,7 @@*/ #include <linux/bitops.h> +#include <linux/clk.h> #include <linux/clk-provider.h> #include <linux/clkdev.h> #include <linux/device.h>
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH 1/7] powerpc/512x: clk: Include clk.h
Quoted 7 lines · On Fri, 10 Jul 2015 16:03:23 -0700 Stephen Boyd <[email protected]> wrote:
This clock provider uses the consumer API, so include
clk.hexplicitly.Cc Gerhard Sittig <[email protected]>Cc Scott Wood <[email protected]>Cc Anatolij Gustschin <[email protected]>Signed-off-by Stephen Boyd <[email protected]>
PATCH 2/7 staging: clocking-wizard: Include clk.h
In reply to Stephen BoydThis clock provider uses the consumer API, so include clk.h explicitly.
---
Please ack so this can go through the clk-tree.
drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 + 1 file changed, 1 insertion(+)
drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c +1 -0
@@ -19,6 +19,7 @@*/ #include <linux/platform_device.h> +#include <linux/clk.h> #include <linux/clk-provider.h> #include <linux/slab.h> #include <linux/io.h>
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH 2/7] staging: clocking-wizard: Include clk.h
Quoted 6 lines · Stephen Boyd
This clock provider uses the consumer API, so include
clk.hexplicitly.Cc Sören Brinkmann <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Signed-off-by Stephen Boyd <[email protected]>
Thanks,
Sören
Re: [PATCH 2/7] staging: clocking-wizard: Include clk.h
In reply to Stephen BoydQuoted 6 lines · Stephen Boyd
This clock provider uses the consumer API, so include
clk.hexplicitly.Cc Sören Brinkmann <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Signed-off-by Stephen Boyd <[email protected]>
Quoted 7 lines
---
Please ack so this can go through the clk-tree.
drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 + 1 file changed, 1 insertion(+)
PATCH 3/7 spi: spi-pxa2xx: Remove clk.h include
In reply to Stephen BoydClock provider drivers generally shouldn't include clk.h because it's the consumer API. Remove the include here because this is a provider driver.
---
Please ack so this can go through the clk tree. Otherwise it's ok to go through spi tree.
drivers/spi/spi-pxa2xx-pci.c | 1 - 1 file changed, 1 deletion(-)
drivers/spi/spi-pxa2xx-pci.c +0 -1
@@ -7,7 +7,6 @@#include <linux/of_device.h> #include <linux/module.h> #include <linux/spi/pxa2xx_spi.h> -#include <linux/clk.h> #include <linux/clk-provider.h> #include <linux/dmaengine.h>
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH 4/7 clocksource: cadence_ttc: Remove clk-provider.h include
In reply to Stephen BoydThis file doesn't use the clk provider APIs. Remove the include.
---
Please ack if you want this to go through clk-tree, otherwise it's ok to take it through the clocksource side.
drivers/clocksource/cadence_ttc_timer.c | 1 - 1 file changed, 1 deletion(-)
drivers/clocksource/cadence_ttc_timer.c +0 -1
@@ -16,7 +16,6 @@*/ #include <linux/clk.h> -#include <linux/clk-provider.h> #include <linux/interrupt.h> #include <linux/clockchips.h> #include <linux/of_address.h>
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH 4/7] clocksource: cadence_ttc: Remove clk-provider.h include
Quoted 9 lines · Stephen Boyd
This file doesn't use the clk provider APIs. Remove the include.
Cc Michal Simek <[email protected]>Cc Daniel Lezcano <[email protected]>Signed-off-by Stephen Boyd <[email protected]>---
Please ack if you want this to go through clk-tree, otherwise it's ok to take it through the clocksource side.
This patchset touches different parts, so I guess it makes sense I take this one through my tree. But if Mike is willing to take it I am ok with that.
Quoted 15 lines
drivers/clocksource/cadence_ttc_timer.c | 1 - 1 file changed, 1 deletion(-)drivers/clocksource/cadence_ttc_timer.c +0
-1@@ -16,7 +16,6 @@*/ #include <linux/clk.h> -#include <linux/clk-provider.h> #include <linux/interrupt.h> #include <linux/clockchips.h> #include <linux/of_address.h>
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Re: [PATCH 4/7] clocksource: cadence_ttc: Remove clk-provider.h include
Quoted 8 lines · Daniel Lezcano
Quoted 7 lines · Stephen Boyd
This file doesn't use the clk provider APIs. Remove the include.
Cc Michal Simek <[email protected]>Cc Daniel Lezcano <[email protected]>Signed-off-by Stephen Boyd <[email protected]>---
Quoted 5 lines
Quoted 2 lines
Please ack if you want this to go through clk-tree, otherwise it's ok to take it through the clocksource side.
This patchset touches different parts, so I guess it makes sense I take this one through my tree. But if Mike is willing to take it I am ok with that.
I'm willing to take it through clk-tree with your ack. Or you can take it directly. It's not strictly necessary for the larger series.
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH 4/7] clocksource: cadence_ttc: Remove clk-provider.h include
In reply to Stephen BoydQuoted 6 lines · Stephen Boyd
This file doesn't use the clk provider APIs. Remove the include.
Cc Michal Simek <[email protected]>Cc Daniel Lezcano <[email protected]>Signed-off-by Stephen Boyd <[email protected]>---
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
PATCH 5/7 ACPI: Remove clk.h include
In reply to Stephen BoydClock provider drivers generally shouldn't include clk.h because it's the consumer API. Remove the includes here because these are provider drivers.
---
Please ack so this can go through clk-tree. Otherwise it's ok to go through the acpi tree.
drivers/acpi/acpi_apd.c | 1 - drivers/acpi/acpi_lpss.c | 1 - 2 files changed, 2 deletions(-)
drivers/acpi/acpi_apd.c +0 -1
@@ -16,7 +16,6 @@#include <linux/clkdev.h> #include <linux/acpi.h> #include <linux/err.h> -#include <linux/clk.h> #include <linux/pm.h> #include "internal.h"
drivers/acpi/acpi_lpss.c +0 -1
@@ -11,7 +11,6 @@*/ #include <linux/acpi.h> -#include <linux/clk.h> #include <linux/clkdev.h> #include <linux/clk-provider.h> #include <linux/err.h>
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH 6/7 simplefb: Include clk.h
In reply to Stephen BoydThis driver uses the consumer API, so include clk.h explicitly instead of impliclty through the provider API.
---
Please ack so this can go through clk-tree.
drivers/video/fbdev/simplefb.c | 1 + 1 file changed, 1 insertion(+)
drivers/video/fbdev/simplefb.c +1 -0
@@ -26,6 +26,7 @@#include <linux/module.h> #include <linux/platform_data/simplefb.h> #include <linux/platform_device.h> +#include <linux/clk.h> #include <linux/clk-provider.h> #include <linux/of_platform.h>
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH 6/7] simplefb: Include clk.h
Quoted 10 lines · Stephen Boyd
This driver uses the consumer API, so include
clk.hexplicitly instead of impliclty through the provider API.Cc Luc Verhaegen <[email protected]>Cc Hans de Goede <[email protected]>Cc Geert Uytterhoeven <[email protected]>Cc Maxime Ripard <[email protected]>Cc David Herrmann <[email protected]>Cc Tomi Valkeinen <[email protected]>Signed-off-by Stephen Boyd <[email protected]>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH 6/7] simplefb: Include clk.h
In reply to Stephen BoydQuoted 10 lines · Stephen Boyd
This driver uses the consumer API, so include
clk.hexplicitly instead of impliclty through the provider API.Cc Luc Verhaegen <[email protected]>Cc Hans de Goede <[email protected]>Cc Geert Uytterhoeven <[email protected]>Cc Maxime Ripard <[email protected]>Cc David Herrmann <[email protected]>Cc Tomi Valkeinen <[email protected]>Signed-off-by Stephen Boyd <[email protected]>
Quoted 6 lines
---
Please ack so this can go through clk-tree.
drivers/video/fbdev/simplefb.c | 1 + 1 file changed, 1 insertion(+)
Tomi
PATCH 7/7 lib/vsprintf.c: Include clk.h
In reply to Stephen BoydThis file uses the clk API so it should include clk.h directly instead of indirectly including it through clk-provider.h.
---
Please ack so this can go through clk-tree.
lib/vsprintf.c | 1 + 1 file changed, 1 insertion(+)
lib/vsprintf.c +1 -0
@@ -17,6 +17,7 @@*/ #include <stdarg.h> +#include <linux/clk.h> #include <linux/clk-provider.h> #include <linux/module.h> /* for KSYM_SYMBOL_LEN */ #include <linux/types.h>
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH 7/7] lib/vsprintf.c: Include clk.h
Quoted 5 lines · Stephen Boyd
This file uses the clk API so it should include
clk.hdirectly instead of indirectly including it throughclk-provider.h.Cc Geert Uytterhoeven <[email protected]>Signed-off-by Stephen Boyd <[email protected]>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds