Skip to contentSkip to conversation

fastboot: Dynamic controller index for usb_gadget_handle_interrupts

PATCH New Paul Kocialkowski 4 participants 9 messages May 24, 2015 – Jul 14, 2015

lore
Share & tools
lore

Paul Kocialkowski

author
#0 lore raw

PATCH 1/1 fastboot: Dynamic controller index for usb_gadget_handle_interrupts

Since we're now using a dynamic controller index for fastboot too, usb_gadget_handle_interrupts should be using it instead of 0 (despite the fact that it's currently not being used at all in the musb-new implementation).

Signed-off-by Paul Kocialkowski <[email protected]>
---
 common/cmd_fastboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/cmd_fastboot.c +1 -1
index 86fbddf..b9d1c8c 100644
@@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
 			break;
 		if (ctrlc())
 			break;
-		usb_gadget_handle_interrupts(0);
+		usb_gadget_handle_interrupts(controller_index);
 	}
 
 	ret = CMD_RET_SUCCESS;
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 fastboot: Dynamic controller index for usb_gadget_handle_interrupts

Hi Paul,

Quoted 15 lines

Since we're now using a dynamic controller index for fastboot too, usb_gadget_handle_interrupts should be using it instead of 0 (despite the fact that it's currently not being used at all in the musb-new implementation).

Signed-off-by Paul Kocialkowski <[email protected]>
---
 common/cmd_fastboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/cmd_fastboot.c +0 -0
index 86fbddf..b9d1c8c 100644

common/cmd_fastboot.c static int do_fastboot(cmd_tbl_t *cmdtp, int flag, · line 53

Quoted 8 lines
common/cmd_fastboot.c +1 -1
@@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag,
 int argc, char *const argv[]) break;
 		if (ctrlc())
 			break;
-		usb_gadget_handle_interrupts(0);
+		usb_gadget_handle_interrupts(controller_index);
 	}
 
 	ret = CMD_RET_SUCCESS;
Reviewed-by Lukasz Majewski <[email protected]>
Signature · 5 lines
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
#2 lore raw

PATCH 1/1 fastboot: Dynamic controller index for usb_gadget_handle_interrupts

Quoted 24 lines · Lukasz Majewski

Hi Paul,

Quoted 22 lines

Since we're now using a dynamic controller index for fastboot too, usb_gadget_handle_interrupts should be using it instead of 0 (despite the fact that it's currently not being used at all in the musb-new implementation).

Signed-off-by Paul Kocialkowski <[email protected]>
---
 common/cmd_fastboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/cmd_fastboot.c +1 -1
index 86fbddf..b9d1c8c 100644
@@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag,
 int argc, char *const argv[]) break;
              if (ctrlc())
                      break;
-             usb_gadget_handle_interrupts(0);
+             usb_gadget_handle_interrupts(controller_index);
      }
Quoted 3 lines

common/cmd_fastboot.c static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) · line 53

Quoted 1 line
common/cmd_fastboot.c +0 -0
      ret = CMD_RET_SUCCESS;
Reviewed-by Lukasz Majewski <[email protected]>

This is in my queue and looks like a fix, so I'm picking it up.

Applied to u-boot-x86, thanks!

#3 lore raw

PATCH 1/1 fastboot: Dynamic controller index for usb_gadget_handle_interrupts

Quoted 26 lines · On Sun, 7 Jun 2015 08:48:31 -0600 Simon Glass <[email protected]> wrote:
Quoted 24 lines · Lukasz Majewski

Hi Paul,

Quoted 22 lines

Since we're now using a dynamic controller index for fastboot too, usb_gadget_handle_interrupts should be using it instead of 0 (despite the fact that it's currently not being used at all in the musb-new implementation).

Signed-off-by Paul Kocialkowski <[email protected]>
---
 common/cmd_fastboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/cmd_fastboot.c +1 -1
index 86fbddf..b9d1c8c 100644
@@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int
 flag, int argc, char *const argv[]) break;
              if (ctrlc())
                      break;
-             usb_gadget_handle_interrupts(0);
+             usb_gadget_handle_interrupts(controller_index);
      }
Quoted 7 lines
Quoted 3 lines

common/cmd_fastboot.c static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) · line 53

Quoted 1 line
common/cmd_fastboot.c +0 -0
      ret = CMD_RET_SUCCESS;
Reviewed-by Lukasz Majewski <[email protected]>

This is in my queue and looks like a fix, so I'm picking it up.

Applied to u-boot-x86, thanks!

One less to go ;-).

Thanks Simon.

Quoted 4 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150607/78a54f3b/attachment.sig>

#4 lore raw

PATCH 1/1 fastboot: Dynamic controller index for usb_gadget_handle_interrupts

In reply to Simon Glass

Hi Paul,

Quoted 25 lines · Simon Glass
Quoted 24 lines · Lukasz Majewski

Hi Paul,

Quoted 22 lines

Since we're now using a dynamic controller index for fastboot too, usb_gadget_handle_interrupts should be using it instead of 0 (despite the fact that it's currently not being used at all in the musb-new implementation).

Signed-off-by Paul Kocialkowski <[email protected]>
---
 common/cmd_fastboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/cmd_fastboot.c +1 -1
index 86fbddf..b9d1c8c 100644
@@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag,
 int argc, char *const argv[]) break;
              if (ctrlc())
                      break;
-             usb_gadget_handle_interrupts(0);
+             usb_gadget_handle_interrupts(controller_index);
      }
Quoted 7 lines
Quoted 3 lines

common/cmd_fastboot.c static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) · line 53

Quoted 1 line
common/cmd_fastboot.c +0 -0
      ret = CMD_RET_SUCCESS;
Reviewed-by Lukasz Majewski <[email protected]>

This is in my queue and looks like a fix, so I'm picking it up.

Applied to u-boot-x86, thanks!

Unfortunately in my final build test this breaks a number of boards, including:

am335x_boneblack_vboot

common/cmd_fastboot.c:36:32: error: ?controller_index? undeclared (first use in this function)
usb_gadget_handle_interrupts(controller_index);

Can you please take a look and respin it?

For now I've dropped it from u-boot-x86.

Regards,
Simon

author
#5 lore raw

PATCH 1/1 fastboot: Dynamic controller index for usb_gadget_handle_interrupts

[snip]

Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Reviewed-by Lukasz Majewski <[email protected]>

This is in my queue and looks like a fix, so I'm picking it up.

Applied to u-boot-x86, thanks!

Unfortunately in my final build test this breaks a number of boards, including:

Quoted 7 lines

am335x_boneblack_vboot

common/cmd_fastboot.c:36:32: error: ?controller_index? undeclared (first use in this function)
usb_gadget_handle_interrupts(controller_index);

Can you please take a look and respin it?

Of course, this makes perfect sense. I didn't think about it until now, but this patch goes on top of the four fastboot-related dfu patches that I sent out (again) yesterday.

I think this should be picked up along with those patches. Lukasz, could you do that?

Thanks

Quoted 1 line

For now I've dropped it from u-boot-x86.

Makes sense.

Signature · 16 lines
Paul Kocialkowski, Replicant developer

Replicant is a fully free Android distribution running on several
devices, a free software mobile operating system putting the emphasis on
freedom and privacy/security.

Website: http://www.replicant.us/
Blog: http://blog.replicant.us/
Wiki/tracker/forums: http://redmine.replicant.us/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150613/4e3a79c3/attachment.sig>
author
#6 lore raw

PATCH 1/1 fastboot: Dynamic controller index for usb_gadget_handle_interrupts

In reply to Lukasz Majewski

Le lundi 25 mai 2015 ? 16:50 +0200, Lukasz Majewski a ?crit :

Quoted 24 lines

Hi Paul,

Quoted 22 lines

Since we're now using a dynamic controller index for fastboot too, usb_gadget_handle_interrupts should be using it instead of 0 (despite the fact that it's currently not being used at all in the musb-new implementation).

Signed-off-by Paul Kocialkowski <[email protected]>
---
 common/cmd_fastboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/cmd_fastboot.c +1 -1
index 86fbddf..b9d1c8c 100644
@@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag,
 int argc, char *const argv[]) break;
 		if (ctrlc())
 			break;
-		usb_gadget_handle_interrupts(0);
+		usb_gadget_handle_interrupts(controller_index);
 	}
Quoted 3 lines

common/cmd_fastboot.c static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) · line 53

Quoted 1 line
common/cmd_fastboot.c +0 -0
 	ret = CMD_RET_SUCCESS;
Reviewed-by Lukasz Majewski <[email protected]>

Now that the other patches have been merged, this one could be as well.

Lukasz, is there anything else holding it back?

Signature · 16 lines
Paul Kocialkowski, Replicant developer

Replicant is a fully free Android distribution running on several
devices, a free software mobile operating system putting the emphasis on
freedom and privacy/security.

Website: http://www.replicant.us/
Blog: http://blog.replicant.us/
Wiki/tracker/forums: http://redmine.replicant.us/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150707/cefd31c1/attachment.sig>
author
#7 lore raw

PATCH 1/1 fastboot: Dynamic controller index for usb_gadget_handle_interrupts

Le mardi 07 juillet 2015 ? 14:29 +0200, Paul Kocialkowski a ?crit :

Quoted 25 lines

Le lundi 25 mai 2015 ? 16:50 +0200, Lukasz Majewski a ?crit :

Quoted 24 lines

Hi Paul,

Quoted 22 lines

Since we're now using a dynamic controller index for fastboot too, usb_gadget_handle_interrupts should be using it instead of 0 (despite the fact that it's currently not being used at all in the musb-new implementation).

Signed-off-by Paul Kocialkowski <[email protected]>
---
 common/cmd_fastboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/cmd_fastboot.c +1 -1
index 86fbddf..b9d1c8c 100644
@@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag,
 int argc, char *const argv[]) break;
 		if (ctrlc())
 			break;
-		usb_gadget_handle_interrupts(0);
+		usb_gadget_handle_interrupts(controller_index);
 	}
Quoted 7 lines
Quoted 3 lines

common/cmd_fastboot.c static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) · line 53

Quoted 1 line
common/cmd_fastboot.c +0 -0
 	ret = CMD_RET_SUCCESS;
Reviewed-by Lukasz Majewski <[email protected]>

Now that the other patches have been merged, this one could be as well.

Lukasz, is there anything else holding it back?

It's been a week since I asked this. Any news?

Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150714/62f4dcf9/attachment.sig>

#8 lore raw

PATCH 1/1 fastboot: Dynamic controller index for usb_gadget_handle_interrupts

Hi Paul,

Quoted 30 lines

Le mardi 07 juillet 2015 ? 14:29 +0200, Paul Kocialkowski a ?crit :

Quoted 29 lines

Le lundi 25 mai 2015 ? 16:50 +0200, Lukasz Majewski a ?crit :

Quoted 27 lines

Hi Paul,

Quoted 15 lines

Since we're now using a dynamic controller index for fastboot too, usb_gadget_handle_interrupts should be using it instead of 0 (despite the fact that it's currently not being used at all in the musb-new implementation).

Signed-off-by Paul Kocialkowski <[email protected]>
---
 common/cmd_fastboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/cmd_fastboot.c +0 -0
index 86fbddf..b9d1c8c 100644

common/cmd_fastboot.c static int do_fastboot(cmd_tbl_t *cmdtp, int · line 53

Quoted 8 lines
common/cmd_fastboot.c +1 -1
@@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int
 flag, int argc, char *const argv[]) break;
 		if (ctrlc())
 			break;
-		usb_gadget_handle_interrupts(0);
+		usb_gadget_handle_interrupts(controller_index);
 	}
 
 	ret = CMD_RET_SUCCESS;
Reviewed-by Lukasz Majewski <[email protected]>
Quoted 6 lines
Quoted 4 lines

Now that the other patches have been merged, this one could be as well.

Lukasz, is there anything else holding it back?

It's been a week since I asked this. Any news?

Applied to u-boot-dfu tree.

Thanks for the patch!

Quoted 2 lines

Thanks!

Signature · 5 lines
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group