Skip to contentSkip to conversation

Patch "regmap: Fix regmap_bulk_read in BE mode" has been added to the 3.14-stable tree

PATCH [email protected] 1 participant 1 message Jul 17, 2015

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

regmap: Fix regmap_bulk_read in BE mode

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
regmap-fix-regmap_bulk_read-in-be-mode.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 15b8d2c41fe5839582029f65c5f7004db451cc2b Mon Sep 17 00:00:00 2001

From: Arun Chandran <[email protected]>
Date: Mon, 15 Jun 2015 15:59:02 +0530
Subject: regmap: Fix regmap_bulk_read in BE mode

From: Arun Chandran <[email protected]>

commit 15b8d2c41fe5839582029f65c5f7004db451cc2b upstream.

In big endian mode regmap_bulk_read gives incorrect data for byte reads.

This is because memcpy of a single byte from an address after full word read gives different results when endianness differs. ie. we get little-end in LE and big-end in BE.

---
 drivers/base/regmap/regmap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/base/regmap/regmap.c +1 -1
@@ -1947,7 +1947,7 @@ int regmap_bulk_read(struct regmap *map,
 					  &ival);
 			if (ret != 0)
 				return ret;
-			memcpy(val + (i * val_bytes), &ival, val_bytes);
+			map->format.format_val(val + (i * val_bytes), ival, 0);
 		}
 	}
 

Patches currently in stable-queue which might be from [email protected] are

queue-3.14/regmap-fix-regmap_bulk_read-in-be-mode.patch