Skip to contentSkip to conversation

qt: enable Script and WebKit modules for ARC

PATCH New Alexey Brodkin 2 participants 3 messages Jul 15, 2015 – Jul 20, 2015

lore
Share & tools
lore

Alexey Brodkin

author
#0 lore raw

PATCH 1/1 qt: enable Script and WebKit modules for ARC

Now when ARC toolchain also supports NPTL both Qt's Script and WebKit modules could be successfully built and then executed on ARC.

Signed-off-by Alexey Brodkin <[email protected]>
Cc Thomas Petazzoni <[email protected]>
---
 package/qt/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/qt/Config.in +3 -2
index 306fe1f..cadc784 100644
@@ -412,7 +412,8 @@ config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
 	default y if BR2_arm || BR2_armeb || BR2_i386 || BR2_microblazeel || \
 		BR2_microblazebe || BR2_mips || BR2_mipsel || \
 		(BR2_mips64 || BR2_mips64el) && !BR2_MIPS_NABI32 || BR2_powerpc || \
-		BR2_powerpc64 || BR2_powerpc64le || BR2_sparc || BR2_x86_64
+		BR2_powerpc64 || BR2_powerpc64le || BR2_sparc || BR2_x86_64 || \
+		BR2_arc
 	# The CodeSourcery SuperH toolchain fails to build Webkit,
 	# with an assertion failure in binutils.
 	default y if (BR2_sh4 || BR2_sh4eb || BR2_sh4a || BR2_sh4aeb) && \

@@ -459,7 +460,7 @@ config BR2_PACKAGE_QT_ARCH_SUPPORTS_SCRIPT
 		BR2_microblazeel || BR2_microblazebe || BR2_mips || BR2_mipsel || \
 		BR2_mips64 || BR2_mips64el || BR2_nios2 || BR2_powerpc || \
 		BR2_powerpc64 || BR2_powerpc64le || BR2_sh4 || BR2_sh4eb || \
-		BR2_sh4a || BR2_sh4aeb || BR2_sparc || BR2_x86_64
+		BR2_sh4a || BR2_sh4aeb || BR2_sparc || BR2_x86_64 || BR2_arc
 
 config BR2_PACKAGE_QT_SCRIPT
 	bool "Script Module"
Signature · 1 line
2.4.3
#1 lore raw

PATCH 1/1 qt: enable Script and WebKit modules for ARC

Dear Alexey Brodkin,

package/qt/Config.in config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT · line 416

Quoted 11 lines · Alexey Brodkin
package/qt/Config.in +2 -1
index 306fe1f..cadc784 100644
@@ -412,7 +412,8 @@ config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
 	default y if BR2_arm || BR2_armeb || BR2_i386 || BR2_microblazeel || \
 		BR2_microblazebe || BR2_mips || BR2_mipsel || \
 		(BR2_mips64 || BR2_mips64el) && !BR2_MIPS_NABI32 || BR2_powerpc || \
-		BR2_powerpc64 || BR2_powerpc64le || BR2_sparc || BR2_x86_64
+		BR2_powerpc64 || BR2_powerpc64le || BR2_sparc || BR2_x86_64 || \
+		BR2_arc

Alphabetic ordering was not correct (for both), so I've fixed that up and applied, thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 qt: enable Script and WebKit modules for ARC

Hi Thomas,

Quoted 4 lines · Thomas Petazzoni

Dear Alexey Brodkin,

On Wed, 15 Jul 2015 16:47:17 +0300, Alexey Brodkin wrote:

Quoted 14 lines

package/qt/Config.in config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT · line 416

Quoted 11 lines
package/qt/Config.in +2 -1
index 306fe1f..cadc784 100644
@@ -412,7 +412,8 @@ config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
 	default y if BR2_arm || BR2_armeb || BR2_i386 || BR2_microblazeel || \
 		BR2_microblazebe || BR2_mips || BR2_mipsel || \
 		(BR2_mips64 || BR2_mips64el) && !BR2_MIPS_NABI32 || BR2_powerpc || \
-		BR2_powerpc64 || BR2_powerpc64le || BR2_sparc || BR2_x86_64
+		BR2_powerpc64 || BR2_powerpc64le || BR2_sparc || BR2_x86_64 || \
+		BR2_arc

Alphabetic ordering was not correct (for both), so I've fixed that up and applied, thanks!

I'm sorry that you had to rework this but I put ARC in the end consciously. As an extension to existing arches. But if alphabetical order is preferred in Buildroot even for things added later I'll keep this in mind for the future.

And thanks a lot for fixing this minor issue.

-Alexey