x86: hd0_info and hd1_info are obsolete and unused fields
PATCH 1/1 x86: hd0_info and hd1_info are obsolete and unused fields
hd0_info and hd1_info are not used anymore, don't reference them in the code
Signed-off-by Paolo Pisati <[email protected]>
--- arch/x86/kernel/kexec-bzimage64.c | 4 ---- 1 file changed, 4 deletions(-)
arch/x86/kernel/kexec-bzimage64.c +0 -4
@@ -218,10 +218,6 @@ setup_boot_parameters(struct kimage *image, struct boot_params *params,/* Default APM info */ memset (¶ms->apm_bios_info,0 ,sizeof (params->apm_bios_info)); -/* Default drive info */ -memset (¶ms->hd0_info,0 ,sizeof (params->hd0_info)); -memset (¶ms->hd1_info,0 ,sizeof (params->hd1_info)); -if (image->type ==KEXEC_TYPE_CRASH ) { ret =crash_setup_memmap_entries (image, params);if (ret)
Signature · 1 line
2.1.4
Quoted 12 lines · Paolo Pisati
hd0_infoandhd1_infoare not used anymore, don't reference them in the codeSigned-off-by Paolo Pisati <[email protected]>--- arch/x86/kernel/kexec-bzimage64.c | 4 ---- 1 file changed, 4 deletions(-)arch/x86/kernel/kexec-bzimage64.c +0
-0
arch/x86/kernel/kexec-bzimage64.c setup_boot_parameters(struct kimage *image, struct boot_params *params, · line 223
Quoted 10 lines
arch/x86/kernel/kexec-bzimage64.c +0
-4@@ -218,10 +218,6 @@ setup_boot_parameters(struct kimage *image, struct boot_params *params,/* Default APM info */ memset (¶ms->apm_bios_info,0 ,sizeof (params->apm_bios_info)); -/* Default drive info */ -memset (¶ms->hd0_info,0 ,sizeof (params->hd0_info)); -memset (¶ms->hd1_info,0 ,sizeof (params->hd1_info)); -if (image->type ==KEXEC_TYPE_CRASH ) { ret =crash_setup_memmap_entries (image, params);if (ret)
But they are not unused: we pass them to secondary kernel images, via kcrash for example.
So it makes sense to zero out these parameters.
Thanks,
Ingo