drm/i915: Update HAS_PSR macro to include all gen>=8 platforms
Subsystems (2)
PATCH 1/1 drm/i915: Update HAS_PSR macro to include all gen>=8 platforms
This is to get PSR support for bxt.
--- drivers/gpu/drm/i915/i915_drv.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +2 -3
@@ -2537,9 +2537,8 @@ struct drm_i915_cmd_table {#define HAS_DDI (dev) (INTEL_INFO(dev)->has_ddi)#define HAS_FPGA_DBG_UNCLAIMED (dev) (INTEL_INFO(dev)->has_fpga_dbg) -#define HAS_PSR (dev) (IS_HASWELL(dev) || IS_BROADWELL(dev) || \ - IS_VALLEYVIEW(dev) || IS_CHERRYVIEW(dev) || \ - IS_SKYLAKE(dev)) +#define HAS_PSR (dev) (IS_HASWELL(dev) || IS_VALLEYVIEW(dev) || \ + INTEL_INFO(dev)->gen >= 8)#define HAS_RUNTIME_PM (dev) (IS_GEN6(dev) || IS_HASWELL(dev) || \ IS_BROADWELL(dev) || IS_VALLEYVIEW(dev) || \ IS_SKYLAKE(dev))
Signature · 6 lines
1.7.10.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 3 lines · Sonika Jindal
This is to get PSR support for bxt.
Signed-off-by Sonika Jindal <[email protected]>
Maybe with a drm/i915/bxt prefix:
Signature · 1 line
Damien
Quoted 27 lines
--- drivers/gpu/drm/i915/i915_drv.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/i915_drv.h +2
-3@@ -2537,9 +2537,8 @@ struct drm_i915_cmd_table {#define HAS_DDI (dev) (INTEL_INFO(dev)->has_ddi)#define HAS_FPGA_DBG_UNCLAIMED (dev) (INTEL_INFO(dev)->has_fpga_dbg) -#define HAS_PSR (dev) (IS_HASWELL(dev) || IS_BROADWELL(dev) || \ - IS_VALLEYVIEW(dev) || IS_CHERRYVIEW(dev) || \ - IS_SKYLAKE(dev)) +#define HAS_PSR (dev) (IS_HASWELL(dev) || IS_VALLEYVIEW(dev) || \ + INTEL_INFO(dev)->gen >= 8)#define HAS_RUNTIME_PM (dev) (IS_GEN6(dev) || IS_HASWELL(dev) || \ IS_BROADWELL(dev) || IS_VALLEYVIEW(dev) || \ IS_SKYLAKE(dev))Signature · 6 lines
1.7.10.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 8 lines · Damien Lespiau
Quoted 3 lines · Sonika Jindal
This is to get PSR support for bxt.
Signed-off-by Sonika Jindal <[email protected]>Maybe with a drm/i915/bxt prefix:
Reviewed-by Damien Lespiau <[email protected]>
Is this actually tested? Can we maybe enable psr by default (Rodrigo seems so close ...)?
-Daniel
Quoted 35 lines
Signature · 2 lines
-- DamienQuoted 27 lines
--- drivers/gpu/drm/i915/i915_drv.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/i915_drv.h +2
-3@@ -2537,9 +2537,8 @@ struct drm_i915_cmd_table {#define HAS_DDI (dev) (INTEL_INFO(dev)->has_ddi)#define HAS_FPGA_DBG_UNCLAIMED (dev) (INTEL_INFO(dev)->has_fpga_dbg) -#define HAS_PSR (dev) (IS_HASWELL(dev) || IS_BROADWELL(dev) || \ - IS_VALLEYVIEW(dev) || IS_CHERRYVIEW(dev) || \ - IS_SKYLAKE(dev)) +#define HAS_PSR (dev) (IS_HASWELL(dev) || IS_VALLEYVIEW(dev) || \ + INTEL_INFO(dev)->gen >= 8)#define HAS_RUNTIME_PM (dev) (IS_GEN6(dev) || IS_HASWELL(dev) || \ IS_BROADWELL(dev) || IS_VALLEYVIEW(dev) || \ IS_SKYLAKE(dev))Signature · 6 lines
1.7.10.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
I replied to Daniel last time. Pasting it on mailing list as well:
"Yes this is tested on android with HW tracking. Not sure about enabling by default part. But this patch will be anyways required.
Regards,
Sonika"
-----Original Message-----
From: Daniel Vetter [mailto:[email protected]] On Behalf Of Daniel Vetter
Sent: Tuesday, July 21, 2015 3:18 PM
To: Lespiau, Damien
Cc: Jindal, Sonika; [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Update HAS_PSR macro to include all gen>=8 platforms
Quoted 8 lines · Damien Lespiau
Quoted 3 lines · Sonika Jindal
This is to get PSR support for bxt.
Signed-off-by Sonika Jindal <[email protected]>Maybe with a drm/i915/bxt prefix:
Reviewed-by Damien Lespiau <[email protected]>
Is this actually tested? Can we maybe enable psr by default (Rodrigo seems so close ...)? -Daniel
Quoted 27 lines
--
DamienQuoted 23 lines
--- drivers/gpu/drm/i915/i915_drv.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)(quoted diff) +0
-0
b/drivers/gpu/drm/i915/i915_drv.hindex 718170c..54d2729 100644drivers/gpu/drm/i915/i915_drv.h +2
-4@@ -2537,9 +2537,8 @@ struct drm_i915_cmd_table {#define HAS_DDI (dev) (INTEL_INFO(dev)->has_ddi)#define HAS_FPGA_DBG_UNCLAIMED (dev) (INTEL_INFO(dev)->has_fpga_dbg) -#define HAS_PSR (dev) (IS_HASWELL(dev) || IS_BROADWELL(dev) || \ - IS_VALLEYVIEW(dev) || IS_CHERRYVIEW(dev) || \ - IS_SKYLAKE(dev)) +#define HAS_PSR (dev) (IS_HASWELL(dev) || IS_VALLEYVIEW(dev) || \ + INTEL_INFO(dev)->gen >= 8)#define HAS_RUNTIME_PM (dev) (IS_GEN6(dev) || IS_HASWELL(dev) || \ IS_BROADWELL(dev) || IS_VALLEYVIEW(dev) || \ IS_SKYLAKE(dev)) --1.7.10.4
Quoted 8 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 4 lines · Sonika
I replied to Daniel last time. Pasting it on mailing list as well:
"Yes this is tested on android with HW tracking. Not sure about enabling by default part. But this patch will be anyways required.
I'd like it to be tested with igt testcases from Paulo/Rodrigo though since that's what we use for upstream validation and to make sure all upstream use-cases are working too. Otherwise we just make an accounting trick and shift the maintainenance burden from android to upstream without being able to use the code really. And looking at psr fixing up the last 10% took 90% of all the effort.
And if there are failures still in the current igts (both kms_psr and kms_frontbuffer_tracking) then I want a plan for how to get this all addressed.
-Daniel
Quoted 64 lines
Regards,
Sonika"-----Original Message-----
From: Daniel Vetter [mailto:[email protected]] On Behalf Of Daniel Vetter
Sent: Tuesday, July 21, 2015 3:18 PM
To: Lespiau, Damien
Cc: Jindal, Sonika; [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i915: UpdateHAS_PSRmacro to include all gen>=8 platformsQuoted 8 lines · Damien Lespiau
Quoted 3 lines · Sonika Jindal
This is to get PSR support for bxt.
Signed-off-by Sonika Jindal <[email protected]>Maybe with a drm/i915/bxt prefix:
Reviewed-by Damien Lespiau <[email protected]>Is this actually tested? Can we maybe enable psr by default (Rodrigo seems so close ...)? -Daniel
Quoted 27 lines
--
DamienQuoted 23 lines
--- drivers/gpu/drm/i915/i915_drv.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)(quoted diff) +0
-0
b/drivers/gpu/drm/i915/i915_drv.hindex 718170c..54d2729 100644drivers/gpu/drm/i915/i915_drv.h +2
-4@@ -2537,9 +2537,8 @@ struct drm_i915_cmd_table {#define HAS_DDI (dev) (INTEL_INFO(dev)->has_ddi)#define HAS_FPGA_DBG_UNCLAIMED (dev) (INTEL_INFO(dev)->has_fpga_dbg) -#define HAS_PSR (dev) (IS_HASWELL(dev) || IS_BROADWELL(dev) || \ - IS_VALLEYVIEW(dev) || IS_CHERRYVIEW(dev) || \ - IS_SKYLAKE(dev)) +#define HAS_PSR (dev) (IS_HASWELL(dev) || IS_VALLEYVIEW(dev) || \ + INTEL_INFO(dev)->gen >= 8)#define HAS_RUNTIME_PM (dev) (IS_GEN6(dev) || IS_HASWELL(dev) || \ IS_BROADWELL(dev) || IS_VALLEYVIEW(dev) || \ IS_SKYLAKE(dev)) --1.7.10.4
Quoted 8 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/1 drm/i915/bxt: Update HAS_PSR macro to include all gen>=8 platforms
In reply to Damien LespiauThis is to get PSR support for bxt.
v2: Adding bxt prefix in title (Damien)
--- drivers/gpu/drm/i915/i915_drv.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +2 -3
@@ -2537,9 +2537,8 @@ struct drm_i915_cmd_table {#define HAS_DDI (dev) (INTEL_INFO(dev)->has_ddi)#define HAS_FPGA_DBG_UNCLAIMED (dev) (INTEL_INFO(dev)->has_fpga_dbg) -#define HAS_PSR (dev) (IS_HASWELL(dev) || IS_BROADWELL(dev) || \ - IS_VALLEYVIEW(dev) || IS_CHERRYVIEW(dev) || \ - IS_SKYLAKE(dev)) +#define HAS_PSR (dev) (IS_HASWELL(dev) || IS_VALLEYVIEW(dev) || \ + INTEL_INFO(dev)->gen >= 8)#define HAS_RUNTIME_PM (dev) (IS_GEN6(dev) || IS_HASWELL(dev) || \ IS_BROADWELL(dev) || IS_VALLEYVIEW(dev) || \ IS_SKYLAKE(dev))
Signature · 6 lines
1.7.10.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx