Skip to contentSkip to conversation

Patch "thermal: step_wise: fix: Prevent from binary overflow when trend is dropping" has been added to the 3.14-stable tree

PATCH [email protected] 1 participant 1 message Jul 21, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

thermal: step_wise: fix: Prevent from binary overflow when trend is dropping

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
thermal-step_wise-fix-prevent-from-binary-overflow-when-trend-is-dropping.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 26bb0e9a1a938ec98ee07aa76533f1a711fba706 Mon Sep 17 00:00:00 2001

From: Lukasz Majewski <[email protected]>
Date: Wed, 24 Sep 2014 10:27:10 +0200
Subject: thermal: step_wise: fix: Prevent from binary overflow when trend is dropping

From: Lukasz Majewski <[email protected]>

commit 26bb0e9a1a938ec98ee07aa76533f1a711fba706 upstream.

It turns out that some boards can have instance->lower greater than 0 and when thermal trend is dropping it results with next_target equal to -1.

Since the next_target is defined as unsigned long it is interpreted as 0xFFFFFFFF and larger than instance->upper.
As a result the next_target is set to instance->upper which ramps up to maximal cooling device target when the temperature is steadily decreasing.

---
 drivers/thermal/step_wise.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/step_wise.c +1 -1
@@ -76,7 +76,7 @@ static unsigned long get_target_state(st
 			next_target = instance->upper;
 		break;
 	case THERMAL_TREND_DROPPING:
-		if (cur_state == instance->lower) {
+		if (cur_state <= instance->lower) {
 			if (!throttle)
 				next_target = THERMAL_NO_TARGET;
 		} else {

Patches currently in stable-queue which might be from [email protected] are

queue-3.14/thermal-step_wise-fix-prevent-from-binary-overflow-when-trend-is-dropping.patch