ASoC: sgtl5000: Fix up define for SGTL5000_SMALL_POP

PATCH In review Axel Lin 5 participants 6 messages Jul 22, 2015

Subsystems (3)

Sound ASoC NXP SGTL5000 driver

lore

Share & tools

lore

Axel Lin

author

2015-07-22 03:27 UTC #0 lore raw

PATCH 1/1 ASoC: sgtl5000: Fix up define for SGTL5000_SMALL_POP

Currently, below code actually does not update any bit because SGTL5000_SMALL_POP is 0.

snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL, SGTL5000_SMALL_POP, 1);

The SGTL5000_SMALL_POP should be BIT(0) rather than 0, fix it.

Signed-off-by Axel Lin <[email protected]>

---
Hi,
I don't have h/w and datasheet, but the code looks obvious does not make sense. Can someone help to confirm and test if this patch? Thanks,
Axel

 sound/soc/codecs/sgtl5000.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

sound/soc/codecs/sgtl5000.h +1 -1

index bd7a344..1c317de 100644
@@ -275,7 +275,7 @@
 #define SGTL5000_BIAS_CTRL_MASK			0x000e
 #define SGTL5000_BIAS_CTRL_SHIFT		1
 #define SGTL5000_BIAS_CTRL_WIDTH		3
-#define SGTL5000_SMALL_POP			0
+#define SGTL5000_SMALL_POP			1
 
 /*
  * SGTL5000_CHIP_MIC_CTRL

Signature · 1 line

2.1.0

Alexander Stein

Acked-by on v1 1/1

2015-07-22 08:59 UTC #1 lore raw

Quoted 8 lines · Axel Lin

Currently, below code actually does not update any bit because SGTL5000_SMALL_POP is 0.
snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL, SGTL5000_SMALL_POP, 1);
The SGTL5000_SMALL_POP should be BIT(0) rather than 0, fix it.
Signed-off-by Axel Lin <[email protected]>

I can not test this right now, but it seems appropriate.

Acked-by Alexander Stein <[email protected]>

Quoted 3 lines

Hi,
I don't have h/w and datasheet, but the code looks obvious does not make sense. Can someone help to confirm and test if this patch?

The datasheet can be found online: http://www.freescale.com/webapp/sps/site/prod_summary.jsp?code=SGTL5000&fpsp=1&tab=Documentation_Tab

Best regards,
Alexander

Signature · 35 lines

Dipl.-Inf. Alexander Stein
SYS TEC electronic GmbH
[email protected]

Legal and Commercial Address:
Am Windrad 2
08468 Heinsdorfergrund
Germany

Office: +49 (0) 3765 38600-0
Fax:    +49 (0) 3765 38600-4100
 
Managing Directors:
	Director Technology/CEO: Dipl.-Phys. Siegmar Schmidt;
	Director Commercial Affairs/COO: Dipl. Ing. (FH) Armin von Collrepp
Commercial Registry:
	Amtsgericht Chemnitz, HRB 28082; USt.-Id Nr. DE150534010
-- 
Dipl.-Inf. Alexander Stein
SYS TEC electronic GmbH
[email protected]

Legal and Commercial Address:
Am Windrad 2
08468 Heinsdorfergrund
Germany

Office: +49 (0) 3765 38600-0
Fax:    +49 (0) 3765 38600-4100
 
Managing Directors:
	Director Technology/CEO: Dipl.-Phys. Siegmar Schmidt;
	Director Commercial Affairs/COO: Dipl. Ing. (FH) Armin von Collrepp
Commercial Registry:
	Amtsgericht Chemnitz, HRB 28082; USt.-Id Nr. DE150534010

Axel Lin

author

2015-07-22 09:45 UTC #2 lore raw

2015-07-22 16:58 GMT+08:00 Alexander Stein
<[email protected]>:

Quoted 10 lines · Axel Lin

Quoted 8 lines
Currently, below code actually does not update any bit because SGTL5000_SMALL_POP is 0.
snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL, SGTL5000_SMALL_POP, 1);
The SGTL5000_SMALL_POP should be BIT(0) rather than 0, fix it.
Signed-off-by Axel Lin <[email protected]>

Quoted 8 lines

I can not test this right now, but it seems appropriate.
Acked-by Alexander Stein <[email protected]>
Quoted 3 lines
Hi,
I don't have h/w and datasheet, but the code looks obvious does not make sense. Can someone help to confirm and test if this patch?
The datasheet can be found online: http://www.freescale.com/webapp/sps/site/prod_summary.jsp?code=SGTL5000&fpsp=1&tab=Documentation_Tab

I just checked the datasheet and confirm the SMALL_POP is BIT(0). Thanks,
Axel

Fabio Estevam

maintainer Reviewed-by

2015-07-22 10:55 UTC #3 lore raw

Quoted 1 line · Axel Lin

I just checked the datasheet and confirm the SMALL_POP is BIT(0).

Yes, this is correct:

Reviewed-by Fabio Estevam <[email protected]>

Mark Brown

maintainer

2015-07-22 09:57 UTC #4 lore raw

Applied "ASoC: sgtl5000: Fix up define for SGTL5000_SMALL_POP" to the asoc tree

In reply to Axel Lin

The patch

ASoC: sgtl5000: Fix up define for SGTL5000_SMALL_POP

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From b101acfabc9377469af3abfb7cb63112da367284 Mon Sep 17 00:00:00 2001

From: Axel Lin <[email protected]>
Date: Wed, 22 Jul 2015 11:27:45 +0800
Subject: [PATCH] ASoC: sgtl5000: Fix up define for SGTL5000_SMALL_POP

Currently, below code actually does not update any bit because SGTL5000_SMALL_POP is 0.

snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL, SGTL5000_SMALL_POP, 1);

The SGTL5000_SMALL_POP should be BIT(0) rather than 0, fix it.

Signed-off-by Axel Lin <[email protected]>

Acked-by Alexander Stein <[email protected]>

Signed-off-by Mark Brown <[email protected]>

---
 sound/soc/codecs/sgtl5000.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

sound/soc/codecs/sgtl5000.h +1 -1

index bd7a344bf8c5..1c317de26176 100644
@@ -275,7 +275,7 @@
 #define SGTL5000_BIAS_CTRL_MASK			0x000e
 #define SGTL5000_BIAS_CTRL_SHIFT		1
 #define SGTL5000_BIAS_CTRL_WIDTH		3
-#define SGTL5000_SMALL_POP			0
+#define SGTL5000_SMALL_POP			1
 
 /*
  * SGTL5000_CHIP_MIC_CTRL

Signature · 1 line

2.1.4

Zeng Zhaoming

2015-07-22 10:15 UTC #5 lore raw

In reply to Axel Lin

Quoted 31 lines · Axel Lin

Currently, below code actually does not update any bit because SGTL5000_SMALL_POP is 0.
snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL, SGTL5000_SMALL_POP, 1);
The SGTL5000_SMALL_POP should be BIT(0) rather than 0, fix it.
Signed-off-by Axel Lin <[email protected]>
---
Hi,
I don't have h/w and datasheet, but the code looks obvious does not make sense. Can someone help to confirm and test if this patch? Thanks,
Axel
 sound/soc/codecs/sgtl5000.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/sgtl5000.h +1 -2
index bd7a344..1c317de 100644
@@ -275,7 +275,7 @@
 #define SGTL5000_BIAS_CTRL_MASK                        0x000e
 #define SGTL5000_BIAS_CTRL_SHIFT               1
 #define SGTL5000_BIAS_CTRL_WIDTH               3
-#define SGTL5000_SMALL_POP                     0
+#define SGTL5000_SMALL_POP                     1
 
 /*
  * SGTL5000_CHIP_MIC_CTRL
--

Quoted 4 lines

2.1.0

Thanks for your report, seems your are right. I have no board to test it.

The code introduced by c251ea7bd7a04f1f2575467e0de76e803cf59149. Fabio, can you verify it on mx28evk?

Thanks

Signature · 2 lines

Best Regards
    Zeng Zhaoming