ASoC: cs35l32: Fix define for CS35L32_SDOUT_3ST

PATCH In review Axel Lin 3 participants 5 messages Jul 23, 2015

Subsystems (3)

Sound ASoC Cirrus Logic audio codecs

lore

Share & tools

lore

Axel Lin

author

2015-07-23 00:28 UTC #0 lore raw

PATCH 1/2 ASoC: cs35l32: Fix define for CS35L32_SDOUT_3ST

According to the datasheet, the CS35L32_SDOUT_3ST is BIT(3).

Signed-off-by Axel Lin <[email protected]>

---
 sound/soc/codecs/cs35l32.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

sound/soc/codecs/cs35l32.h +1 -1

index 31ab804..1d6c250 100644
@@ -80,7 +80,7 @@ struct cs35l32_platform_data {
 #define CS35L32_GAIN_MGR_MASK		0x08
 #define CS35L32_ADSP_SHARE_MASK		0x08
 #define CS35L32_ADSP_DATACFG_MASK	0x30
-#define CS35L32_SDOUT_3ST		0x80
+#define CS35L32_SDOUT_3ST		0x08
 #define CS35L32_BATT_REC_MASK		0x0E
 #define CS35L32_BATT_THRESH_MASK	0x30

Signature · 1 line

2.1.0

Axel Lin

author

2015-07-23 00:30 UTC #1 lore raw

PATCH 2/2 ASoC: cs35l32: Remove unneeded NULL test for cs35l32->reset_gpio

It's safe to call gpiod_set_value_cansleep() with NULL desc.

Signed-off-by Axel Lin <[email protected]>

---
 sound/soc/codecs/cs35l32.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

sound/soc/codecs/cs35l32.c +4 -8

index 7e7d243..203c720 100644
@@ -441,8 +441,7 @@ static int cs35l32_i2c_probe(struct i2c_client *i2c_client,
 	if (IS_ERR(cs35l32->reset_gpio))
 		return PTR_ERR(cs35l32->reset_gpio);
 
-	if (cs35l32->reset_gpio)
-		gpiod_set_value_cansleep(cs35l32->reset_gpio, 1);
+	gpiod_set_value_cansleep(cs35l32->reset_gpio, 1);
 
 	/* initialize codec */
 	ret = regmap_read(cs35l32->regmap, CS35L32_DEVID_AB, &reg);

@@ -536,8 +535,7 @@ static int cs35l32_i2c_remove(struct i2c_client *i2c_client)
 	snd_soc_unregister_codec(&i2c_client->dev);
 
 	/* Hold down reset */
-	if (cs35l32->reset_gpio)
-		gpiod_set_value_cansleep(cs35l32->reset_gpio, 0);
+	gpiod_set_value_cansleep(cs35l32->reset_gpio, 0);
 
 	return 0;
 }

@@ -551,8 +549,7 @@ static int cs35l32_runtime_suspend(struct device *dev)
 	regcache_mark_dirty(cs35l32->regmap);
 
 	/* Hold down reset */
-	if (cs35l32->reset_gpio)
-		gpiod_set_value_cansleep(cs35l32->reset_gpio, 0);
+	gpiod_set_value_cansleep(cs35l32->reset_gpio, 0);
 
 	/* remove power */
 	regulator_bulk_disable(ARRAY_SIZE(cs35l32->supplies),

@@ -575,8 +572,7 @@ static int cs35l32_runtime_resume(struct device *dev)
 		return ret;
 	}
 
-	if (cs35l32->reset_gpio)
-		gpiod_set_value_cansleep(cs35l32->reset_gpio, 1);
+	gpiod_set_value_cansleep(cs35l32->reset_gpio, 1);
 
 	regcache_cache_only(cs35l32->regmap, false);
 	regcache_sync(cs35l32->regmap);

Signature · 1 line

2.1.0

Mark Brown

maintainer

2015-07-23 15:04 UTC #2 lore raw

Applied "ASoC: cs35l32: Remove unneeded NULL test for cs35l32->reset_gpio" to the asoc tree

The patch

ASoC: cs35l32: Remove unneeded NULL test for cs35l32->reset_gpio

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From d5a78c8ea050e9c81db1e25a4916d8d9168dfb2e Mon Sep 17 00:00:00 2001

From: Axel Lin <[email protected]>
Date: Thu, 23 Jul 2015 08:29:57 +0800
Subject: [PATCH] ASoC: cs35l32: Remove unneeded NULL test for
cs35l32->reset_gpio

It's safe to call gpiod_set_value_cansleep() with NULL desc.

Signed-off-by Axel Lin <[email protected]>

Acked-by Brian Austin <[email protected]>

Signed-off-by Mark Brown <[email protected]>

---
 sound/soc/codecs/cs35l32.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

sound/soc/codecs/cs35l32.c +4 -8

index 8f40025b7e7c..f5f86b204521 100644
@@ -441,8 +441,7 @@ static int cs35l32_i2c_probe(struct i2c_client *i2c_client,
 	if (IS_ERR(cs35l32->reset_gpio))
 		return PTR_ERR(cs35l32->reset_gpio);
 
-	if (cs35l32->reset_gpio)
-		gpiod_set_value_cansleep(cs35l32->reset_gpio, 1);
+	gpiod_set_value_cansleep(cs35l32->reset_gpio, 1);
 
 	/* initialize codec */
 	ret = regmap_read(cs35l32->regmap, CS35L32_DEVID_AB, &reg);

@@ -536,8 +535,7 @@ static int cs35l32_i2c_remove(struct i2c_client *i2c_client)
 	snd_soc_unregister_codec(&i2c_client->dev);
 
 	/* Hold down reset */
-	if (cs35l32->reset_gpio)
-		gpiod_set_value_cansleep(cs35l32->reset_gpio, 0);
+	gpiod_set_value_cansleep(cs35l32->reset_gpio, 0);
 
 	return 0;
 }

@@ -551,8 +549,7 @@ static int cs35l32_runtime_suspend(struct device *dev)
 	regcache_mark_dirty(cs35l32->regmap);
 
 	/* Hold down reset */
-	if (cs35l32->reset_gpio)
-		gpiod_set_value_cansleep(cs35l32->reset_gpio, 0);
+	gpiod_set_value_cansleep(cs35l32->reset_gpio, 0);
 
 	/* remove power */
 	regulator_bulk_disable(ARRAY_SIZE(cs35l32->supplies),

@@ -575,8 +572,7 @@ static int cs35l32_runtime_resume(struct device *dev)
 		return ret;
 	}
 
-	if (cs35l32->reset_gpio)
-		gpiod_set_value_cansleep(cs35l32->reset_gpio, 1);
+	gpiod_set_value_cansleep(cs35l32->reset_gpio, 1);
 
 	regcache_cache_only(cs35l32->regmap, false);
 	regcache_sync(cs35l32->regmap);

Signature · 1 line

2.1.4

Austin, Brian

Acked-by on v1 1/2

2015-07-23 10:38 UTC #3 lore raw

In reply to Axel Lin

Quoted 7 lines · Axel Lin

According to the datasheet, the CS35L32_SDOUT_3ST is BIT(3).
Signed-off-by Axel Lin <[email protected]>

Acked-by Brian Austin <[email protected]>

Thanks

Mark Brown

maintainer

2015-07-23 15:04 UTC #4 lore raw

Applied "ASoC: cs35l32: Fix define for CS35L32_SDOUT_3ST" to the asoc tree

In reply to Axel Lin

The patch

ASoC: cs35l32: Fix define for CS35L32_SDOUT_3ST

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 4c38b9c30f78d44c576ca3049577fbd4d5c2acc6 Mon Sep 17 00:00:00 2001

From: Axel Lin <[email protected]>
Date: Thu, 23 Jul 2015 08:28:50 +0800
Subject: [PATCH] ASoC: cs35l32: Fix define for CS35L32_SDOUT_3ST

According to the datasheet, the CS35L32_SDOUT_3ST is BIT(3).

Signed-off-by Axel Lin <[email protected]>

Acked-by Brian Austin <[email protected]>

Signed-off-by Mark Brown <[email protected]>

---
 sound/soc/codecs/cs35l32.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

sound/soc/codecs/cs35l32.h +1 -1

index 31ab804a22bc..1d6c2508cd41 100644
@@ -80,7 +80,7 @@ struct cs35l32_platform_data {
 #define CS35L32_GAIN_MGR_MASK		0x08
 #define CS35L32_ADSP_SHARE_MASK		0x08
 #define CS35L32_ADSP_DATACFG_MASK	0x30
-#define CS35L32_SDOUT_3ST		0x80
+#define CS35L32_SDOUT_3ST		0x08
 #define CS35L32_BATT_REC_MASK		0x0E
 #define CS35L32_BATT_THRESH_MASK	0x30

Signature · 1 line

2.1.4