Skip to contentSkip to conversation

ASoC: tas2552: Fix off-by-one for max_register setting

PATCH In review Axel Lin 3 participants 3 messages Jul 23, 2015

Subsystems (3)
Sound ASoC Texas Instruments audio (ASoC/HDA) drivers
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 ASoC: tas2552: Fix off-by-one for max_register setting

The latest valid register is TAS2552_VBAT_DATA.

Signed-off-by Axel Lin <[email protected]>
---
 sound/soc/codecs/tas2552.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/tas2552.h +1 -1
index 5746f8f..e34752b 100644
@@ -42,7 +42,7 @@
 #define TAS2552_BOOST_APT_CTRL		0x14
 #define TAS2552_VER_NUM			0x16
 #define TAS2552_VBAT_DATA		0x19
-#define TAS2552_MAX_REG			0x20
+#define TAS2552_MAX_REG			TAS2552_VBAT_DATA
 
 /* CFG1 Register Masks */
 #define TAS2552_DEV_RESET		(1 << 0)
Signature · 1 line
2.1.0
Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Axel Lin

The latest valid register is TAS2552_VBAT_DATA.

Signed-off-by Axel Lin <[email protected]>
---
 sound/soc/codecs/tas2552.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/tas2552.h +0 -0
index 5746f8f..e34752b 100644

sound/soc/codecs/tas2552.h line 48

Quoted 8 lines
sound/soc/codecs/tas2552.h +1 -1
@@ -42,7 +42,7 @@
 #define TAS2552_BOOST_APT_CTRL		0x14
 #define TAS2552_VER_NUM			0x16
 #define TAS2552_VBAT_DATA		0x19
-#define TAS2552_MAX_REG			0x20
+#define TAS2552_MAX_REG			TAS2552_VBAT_DATA
 
 /* CFG1 Register Masks */
 #define TAS2552_DEV_RESET		(1 << 0)
Acked-by Dan Murphy<[email protected]>
Signature · 2 lines
------------------
Dan Murphy
maintainer
#2 lore raw

Applied "ASoC: tas2552: Fix off-by-one for max_register setting" to the asoc tree

In reply to Axel Lin

The patch

ASoC: tas2552: Fix off-by-one for max_register setting

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 95f1044f5674b53f67e0933abff228c594792f4c Mon Sep 17 00:00:00 2001

From: Axel Lin <[email protected]>
Date: Thu, 23 Jul 2015 22:56:04 +0800
Subject: [PATCH] ASoC: tas2552: Fix off-by-one for max_register setting

The latest valid register is TAS2552_VBAT_DATA.

Signed-off-by Axel Lin <[email protected]>
Acked-by Dan Murphy<[email protected]>
Signed-off-by Mark Brown <[email protected]>
---
 sound/soc/codecs/tas2552.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/tas2552.h +1 -1
index 5746f8fd0afd..e34752b8a299 100644
@@ -42,7 +42,7 @@
 #define TAS2552_BOOST_APT_CTRL		0x14
 #define TAS2552_VER_NUM			0x16
 #define TAS2552_VBAT_DATA		0x19
-#define TAS2552_MAX_REG			0x20
+#define TAS2552_MAX_REG			TAS2552_VBAT_DATA
 
 /* CFG1 Register Masks */
 #define TAS2552_DEV_RESET		(1 << 0)
Signature · 1 line
2.1.4