Skip to contentSkip to conversation

config: ti_omap5_common: Palmas power support in SPL

PATCH In review Paul Kocialkowski 2 participants 5 messages Jul 1, 2015 – Jul 28, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 config: ti_omap5_common: Palmas power support in SPL

Palmas power support is required for OMAP5 devices such as the OMAP5 uEVM, that need to e.g. enable MMC power at SPL stage.

This is especially important when booting from a peripheral (such as USB, UART), where the bootrom will not enable power for the MMC device that will hold the main U-Boot.

---
 include/configs/ti_armv7_common.h | 1 +
 include/configs/ti_omap5_common.h | 2 --
 2 files changed, 1 insertion(+), 2 deletions(-)
include/configs/ti_armv7_common.h +1 -0
index 0aea7d1..34756de 100644
@@ -261,6 +261,7 @@
 #define CONFIG_SPL_LIBCOMMON_SUPPORT
 #define CONFIG_SPL_LIBGENERIC_SUPPORT
 #define CONFIG_SPL_SERIAL_SUPPORT
+#define CONFIG_SPL_POWER_SUPPORT
 #define CONFIG_SPL_GPIO_SUPPORT
 #define CONFIG_SPL_BOARD_INIT
 
include/configs/ti_omap5_common.h +0 -2
index 4179a57..b33feb6 100644
@@ -40,9 +40,7 @@
 #define CONFIG_SYS_DEFAULT_LPDDR2_TIMINGS
 #endif
 
-#ifndef CONFIG_SPL_BUILD
 #define CONFIG_PALMAS_POWER
-#endif
 
 #include <asm/arch/cpu.h>
 #include <asm/arch/omap.h>
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 config: ti_omap5_common: Palmas power support in SPL

Le jeudi 02 juillet 2015 ? 00:20 +0200, Paul Kocialkowski a ?crit :

Quoted 6 lines

Palmas power support is required for OMAP5 devices such as the OMAP5 uEVM, that need to e.g. enable MMC power at SPL stage.

This is especially important when booting from a peripheral (such as USB, UART), where the bootrom will not enable power for the MMC device that will hold the main U-Boot.

I sent this a while back and it hasn't been picked up yet. Anything holding it back in particular?

Quoted 23 lines
---
 include/configs/ti_armv7_common.h | 1 +
 include/configs/ti_omap5_common.h | 2 --
 2 files changed, 1 insertion(+), 2 deletions(-)
include/configs/ti_armv7_common.h +1 -0
index 0aea7d1..34756de 100644
@@ -261,6 +261,7 @@
 #define CONFIG_SPL_LIBCOMMON_SUPPORT
 #define CONFIG_SPL_LIBGENERIC_SUPPORT
 #define CONFIG_SPL_SERIAL_SUPPORT
+#define CONFIG_SPL_POWER_SUPPORT
 #define CONFIG_SPL_GPIO_SUPPORT
 #define CONFIG_SPL_BOARD_INIT
 
include/configs/ti_omap5_common.h +0 -0
index 4179a57..b33feb6 100644

include/configs/ti_omap5_common.h line 46

Quoted 9 lines
include/configs/ti_omap5_common.h +0 -2
@@ -40,9 +40,7 @@
 #define CONFIG_SYS_DEFAULT_LPDDR2_TIMINGS
 #endif
 
-#ifndef CONFIG_SPL_BUILD
 #define CONFIG_PALMAS_POWER
-#endif
 
 #include <asm/arch/cpu.h>
 #include <asm/arch/omap.h>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150715/6f0fb42b/attachment.sig>

#2 lore raw

PATCH 1/1 config: ti_omap5_common: Palmas power support in SPL

Quoted 37 lines · Paul Kocialkowski

Le jeudi 02 juillet 2015 ? 00:20 +0200, Paul Kocialkowski a ?crit :

Quoted 6 lines

Palmas power support is required for OMAP5 devices such as the OMAP5 uEVM, that need to e.g. enable MMC power at SPL stage.

This is especially important when booting from a peripheral (such as USB, UART), where the bootrom will not enable power for the MMC device that will hold the main U-Boot.

I sent this a while back and it hasn't been picked up yet. Anything holding it back in particular?

Quoted 26 lines
---
 include/configs/ti_armv7_common.h | 1 +
 include/configs/ti_omap5_common.h | 2 --
 2 files changed, 1 insertion(+), 2 deletions(-)
include/configs/ti_armv7_common.h +1 -0
index 0aea7d1..34756de 100644
@@ -261,6 +261,7 @@
 #define CONFIG_SPL_LIBCOMMON_SUPPORT
 #define CONFIG_SPL_LIBGENERIC_SUPPORT
 #define CONFIG_SPL_SERIAL_SUPPORT
+#define CONFIG_SPL_POWER_SUPPORT
 #define CONFIG_SPL_GPIO_SUPPORT
 #define CONFIG_SPL_BOARD_INIT
 
include/configs/ti_omap5_common.h +0 -0
index 4179a57..b33feb6 100644
@@ -40,9 +40,7 @@
 #define CONFIG_SYS_DEFAULT_LPDDR2_TIMINGS
 #endif
 
Quoted 6 lines

include/configs/ti_omap5_common.h line 46

Quoted 6 lines
include/configs/ti_omap5_common.h +0 -2
-#ifndef CONFIG_SPL_BUILD
 #define CONFIG_PALMAS_POWER
-#endif
 
 #include <asm/arch/cpu.h>
 #include <asm/arch/omap.h>
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150716/9cc980a6/attachment.sig>
#3 lore raw

PATCH 1/1 config: ti_omap5_common: Palmas power support in SPL

Le jeudi 16 juillet 2015 ? 09:21 -0400, Tom Rini a ?crit :

Quoted 38 lines · Paul Kocialkowski
Quoted 37 lines

Le jeudi 02 juillet 2015 ? 00:20 +0200, Paul Kocialkowski a ?crit :

Quoted 6 lines

Palmas power support is required for OMAP5 devices such as the OMAP5 uEVM, that need to e.g. enable MMC power at SPL stage.

This is especially important when booting from a peripheral (such as USB, UART), where the bootrom will not enable power for the MMC device that will hold the main U-Boot.

I sent this a while back and it hasn't been picked up yet. Anything holding it back in particular?

Quoted 26 lines
---
 include/configs/ti_armv7_common.h | 1 +
 include/configs/ti_omap5_common.h | 2 --
 2 files changed, 1 insertion(+), 2 deletions(-)
include/configs/ti_armv7_common.h +1 -0
index 0aea7d1..34756de 100644
@@ -261,6 +261,7 @@
 #define CONFIG_SPL_LIBCOMMON_SUPPORT
 #define CONFIG_SPL_LIBGENERIC_SUPPORT
 #define CONFIG_SPL_SERIAL_SUPPORT
+#define CONFIG_SPL_POWER_SUPPORT
 #define CONFIG_SPL_GPIO_SUPPORT
 #define CONFIG_SPL_BOARD_INIT
 
include/configs/ti_omap5_common.h +0 -0
index 4179a57..b33feb6 100644
@@ -40,9 +40,7 @@
 #define CONFIG_SYS_DEFAULT_LPDDR2_TIMINGS
 #endif
 
Quoted 8 lines
Quoted 6 lines

include/configs/ti_omap5_common.h line 46

Quoted 6 lines
include/configs/ti_omap5_common.h +0 -2
-#ifndef CONFIG_SPL_BUILD
 #define CONFIG_PALMAS_POWER
-#endif
 
 #include <asm/arch/cpu.h>
 #include <asm/arch/omap.h>

Now that the merge window is open, I think we could merge that one.

What do you think?

Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150726/911d0ecd/attachment.sig>

#4 lore raw
In reply to Paul Kocialkowski
Quoted 9 lines · Paul Kocialkowski

Palmas power support is required for OMAP5 devices such as the OMAP5 uEVM, that need to e.g. enable MMC power at SPL stage.

This is especially important when booting from a peripheral (such as USB, UART), where the bootrom will not enable power for the MMC device that will hold the main U-Boot.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150728/073943cf/attachment.sig>