Skip to contentSkip to conversation

am33xx: Unused get_board_rev function removal

PATCH In review Paul Kocialkowski 2 participants 4 messages Jul 16, 2015 – Jul 28, 2015 Arm (32-bit)

lore
Share & tools
lore

Paul Kocialkowski

author
#0 lore raw

PATCH 1/1 am33xx: Unused get_board_rev function removal

All am33xx device tree are using device-tree, so get_board_rev is never actually called. Thus, we can get rid of it to make the code easier to maintain.

Signed-off-by Paul Kocialkowski <[email protected]>
---
 arch/arm/cpu/armv7/am33xx/sys_info.c | 9 ---------
 1 file changed, 9 deletions(-)
arch/arm/cpu/armv7/am33xx/sys_info.c +0 -9
index 781d83f..52a6824 100644
@@ -51,15 +51,6 @@ u32 get_cpu_type(void)
 }
 
 /**
- * get_board_rev() - setup to pass kernel board revision information
- * returns: 0 for the ATAG REVISION tag value.
- */
-u32 __weak get_board_rev(void)
-{
-	return 0;
-}
-
-/**
  * get_device_type(): tell if GP/HS/EMU/TST
  */
 u32 get_device_type(void)
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 am33xx: Unused get_board_rev function removal

Quoted 4 lines · Paul Kocialkowski

All am33xx device tree are using device-tree, so get_board_rev is never actually called. Thus, we can get rid of it to make the code easier to maintain.

Signed-off-by Paul Kocialkowski <[email protected]>
Reviewed-by Tom Rini <[email protected]>
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150716/bcf0fe26/attachment.sig>
author
#2 lore raw

PATCH 1/1 am33xx: Unused get_board_rev function removal

Le jeudi 16 juillet 2015 ? 09:40 -0400, Tom Rini a ?crit :

Quoted 8 lines · Paul Kocialkowski
Quoted 5 lines

All am33xx device tree are using device-tree, so get_board_rev is never actually called. Thus, we can get rid of it to make the code easier to maintain.

Signed-off-by Paul Kocialkowski <[email protected]>
Reviewed-by Tom Rini <[email protected]>

What about merging this patch? It's been more than a week since we last discussed it.

Thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150726/b19c4d5b/attachment.sig>

#3 lore raw
In reply to Paul Kocialkowski
Quoted 5 lines · Paul Kocialkowski

All am33xx device tree are using device-tree, so get_board_rev is never actually called. Thus, we can get rid of it to make the code easier to maintain.

Signed-off-by Paul Kocialkowski <[email protected]>
Reviewed-by Tom Rini <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150728/e0a9c41f/attachment.sig>