video: fbdev: atmel: fix warning for const return value
PATCH 1/1 video: fbdev: atmel: fix warning for const return value
A const on a return value is meaningless and generates a warning on some versions of gcc:
drivers/video/fbdev/atmel_lcdfb.c:1003: warning: type qualifiers ignored on function return type
This was found on 0-day with avr32 builds with CONFIG_OF enabled, but it doesn't seem to generate warnings for other arches.
--- drivers/video/fbdev/atmel_lcdfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/atmel_lcdfb.c +1 -1
@@ -999,7 +999,7 @@ static const char *atmel_lcdfb_wiring_modes[] = { [ATMEL_LCDC_WIRING_RGB] = "RGB", }; -const int atmel_lcdfb_get_of_wiring_modes (struct device_node *np) +int atmel_lcdfb_get_of_wiring_modes (struct device_node *np) {const char *mode;int err, i;
Signature · 1 line
2.1.0
Quoted 11 lines · Rob Herring
A const on a return value is meaningless and generates a warning on some versions of gcc:
drivers/video/fbdev/atmel_lcdfb.c:1003: warning: type qualifiers ignored on function return typeThis was found on 0-day with avr32 builds with
CONFIG_OFenabled, but it doesn't seem to generate warnings for other arches.Reported-by Fengguang Wu <[email protected]>Signed-off-by Rob Herring <[email protected]>Cc Nicolas Ferre <[email protected]>
Sure:
Thanks Rob!
Quoted 20 lines
Cc Jean-Christophe Plagniol-Villard <[email protected]>Cc Tomi Valkeinen <[email protected]>--- drivers/video/fbdev/atmel_lcdfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/video/fbdev/atmel_lcdfb.c +1
-1@@ -999,7 +999,7 @@ static const char *atmel_lcdfb_wiring_modes[] = { [ATMEL_LCDC_WIRING_RGB] = "RGB", }; -const int atmel_lcdfb_get_of_wiring_modes (struct device_node *np) +int atmel_lcdfb_get_of_wiring_modes (struct device_node *np) {const char *mode;int err, i;
Signature · 1 line
Nicolas Ferre
Quoted 4 lines · Rob Herring
A const on a return value is meaningless and generates a warning on some versions of gcc:
drivers/video/fbdev/atmel_lcdfb.c:1003: warning: type qualifiers ignored on function return type
maybe this one should have been static instead of const.
regards
sudip
Quoted 6 lines · Sudip Mukherjee
Quoted 4 lines · Rob Herring
A const on a return value is meaningless and generates a warning on some versions of gcc:
drivers/video/fbdev/atmel_lcdfb.c:1003: warning: type qualifiers ignored on function return typemaybe this one should have been static instead of const.
I think that makes sense. I will apply the following patch instead of Rob's, if no one complains.
Author: Tomi Valkeinen <[email protected]> Date: Thu Aug 20 13:46:10 2015 +0300
video: fbdev: atmel: fix warning for const return value
A const on a return value is meaningless and generates a warning on some versions of gcc:
drivers/video/fbdev/atmel_lcdfb.c:1003: warning: type qualifiers ignored on function return type
The function in question is only used inside the .c file, so the author of the code most likely means "static" instead of "const".
Change the const to static.
drivers/video/fbdev/atmel_lcdfb.c +1 -1
@@ -999,7 +999,7 @@ static const char *atmel_lcdfb_wiring_modes[] = { [ATMEL_LCDC_WIRING_RGB] = "RGB", }; -const int atmel_lcdfb_get_of_wiring_modes (struct device_node *np) +static int atmel_lcdfb_get_of_wiring_modes (struct device_node *np) {const char *mode;int err, i;