Skip to contentSkip to conversation

Staging : wilc1000: Remove unnecessary parentheses

PATCH In review Shraddha Barke 2 participants 2 messages Jul 29, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging : wilc1000: Remove unnecessary parentheses

Remove parentheses around the right hand side of an assignment as they are not needed

The semantic patch used is :

@@
expression E;
expression f;
constant C;
@@
(
f = (E == C)
|
f =
- (
E
- )

)

---
 drivers/staging/wilc1000/wilc_sdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wilc1000/wilc_sdio.c +1 -1
index 897e47e..4b81f17 100644
@@ -1072,7 +1072,7 @@ static int sdio_clear_int_ext(uint32_t val)
 						cmd.function = 0;
 						cmd.raw = 0;
 						cmd.address = 0xf8;
-						cmd.data = (1 << i);
+						cmd.data = 1 << i;
 
 						ret = g_sdio.sdio_cmd52(&cmd);
 						if (!ret) {
Signature · 1 line
2.1.0
#1 lore raw

The original code is fine... I probably would write it the way you suggest, but I can also see why people would write it the other way. This isn't an official CodingStyle rule so I feel like the author gets to choose. Part of the reason for CodingStyle is so that we don't run into madness of changing every single thing all the time.

regards,
dan carpenter