Skip to contentSkip to conversation

Clean all defconfigs with savedefconfig

PATCH New Joe Hershberger 8 participants 29 messages May 11, 2015 – Aug 1, 2015 Page 3 of 3

Subsystems (28)
Arm (32-bit) Arm sub-architectures PowerPC Arm i.MX and Layerscape +24 more subsystems
lore
Share & tools
lore
#25 lore raw

PATCH v3 1/2 arch: Make board selection choices optional

In reply to Tom Rini

Hi Joe,

2015-05-13 7:12 GMT+09:00 Tom Rini <[email protected]>:

arch/arc/Kconfig config ARC_CACHE_LINE_SHIFT · line 138

Quoted 12 lines
arch/arc/Kconfig +1 -0
index c044ad4..85fddd2 100644
@@ -132,6 +132,7 @@ config ARC_CACHE_LINE_SHIFT
 
 choice
        prompt "Target select"
+       optional
 
 config TARGET_DUMMY
        bool "Dummy target"

You do not need to add "optional" to the ARC board select because Alexey intentionally added TARGET_DUMMY to the top of the board select list.

This is another solution to not lose any CONFIG_BOARD_ by savedefconfig although I personally prefer this idea very much.

Signature · 2 lines
Best Regards
Masahiro Yamada
#26 lore raw

PATCH v3 1/2 arch: Make board selection choices optional

Hi Joe,

Quoted 22 lines · Masahiro Yamada

Hi Joe,

2015-05-13 7:12 GMT+09:00 Tom Rini <[email protected]>:

arch/arc/Kconfig config ARC_CACHE_LINE_SHIFT · line 138

Quoted 12 lines
arch/arc/Kconfig +1 -0
index c044ad4..85fddd2 100644
@@ -132,6 +132,7 @@ config ARC_CACHE_LINE_SHIFT
 
 choice
        prompt "Target select"
+       optional
 
 config TARGET_DUMMY
        bool "Dummy target"

You do not need to add "optional" to the ARC board select because Alexey intentionally added TARGET_DUMMY to the top of the board select list.

Quoted 2 lines

This is another solution to not lose any CONFIG_BOARD_ by savedefconfig although I personally prefer this idea very much.

Looks like I discover an issue that happens with that change.
If one attempts to do something like:
------------------>8------------------
"yes "" | make oldconfig" on defconfig ------------------>8------------------
(that trick is done by automated build frameworks like Buildroot that prefer to not do "xxx_defconfig" explicitly, but modify that defconfig and later expand it to a full-scale .config) target won't be set because on prompt you'll see something like that:
------------------>8------------------
Target select [N/y] (NEW)
------------------>8------------------

See default answer here is No!
Which later on attempt to do a build causes:
------------------>8------------------

$ make
scripts/kconfig/conf --silentoldconfig Kconfig
#
# configuration written to .config
#
  CHK     include/config.h
  UPD     include/config.h
  GEN     include/autoconf.mk
In file included from ./include/common.h:18:0:
include/config.h:5:22: fatal error: configs/.h: No such file or directory
 #include <configs/.h>
                      ^
compilation terminated.
scripts/Makefile.autoconf:72: recipe for target 'include/autoconf.mk' failed
make[1]: *** [include/autoconf.mk] Error 1
------------------>8------------------

If "optional" is removed from "choice -> prompt "Target select"" then target is selected by default and build runs smoothly.

Any thoughts on how to fix it?

-Alexey

#27 lore raw

PATCH v3 1/2 arch: Make board selection choices optional

Hi Joe, Masahiro-san,

Quoted 27 lines · Alexey Brodkin

Hi Joe,

Quoted 24 lines · Masahiro Yamada

Hi Joe,

2015-05-13 7:12 GMT+09:00 Tom Rini <[email protected]>:

arch/arc/Kconfig config ARC_CACHE_LINE_SHIFT · line 138

Quoted 12 lines
arch/arc/Kconfig +1 -0
index c044ad4..85fddd2 100644
@@ -132,6 +132,7 @@ config ARC_CACHE_LINE_SHIFT
 
 choice
        prompt "Target select"
+       optional
 
 config TARGET_DUMMY
        bool "Dummy target"

You do not need to add "optional" to the ARC board select because Alexey intentionally added TARGET_DUMMY to the top of the board select list.

This is another solution to not lose any CONFIG_BOARD_ by savedefconfig although I personally prefer this idea very much.

It looks like I'm not the only one suffering from that change. For UniPhier that issue was resolved by Masahiro with replacement of "optional" with explicit default option.

And probably that's the way we'll need to go for all other affected Kconfigs.

Still all proposals are more than welcome.

-Alexey

#28 lore raw

PATCH v3 1/2 arch: Make board selection choices optional

Hi Alexey,

2015-07-30 2:32 GMT+09:00 Alexey Brodkin <[email protected]>:

Quoted 31 lines

Hi Joe, Masahiro-san,

Quoted 27 lines · Alexey Brodkin

Hi Joe,

Quoted 24 lines · Masahiro Yamada

Hi Joe,

2015-05-13 7:12 GMT+09:00 Tom Rini <[email protected]>:

arch/arc/Kconfig config ARC_CACHE_LINE_SHIFT · line 138

Quoted 12 lines
arch/arc/Kconfig +1 -0
index c044ad4..85fddd2 100644
@@ -132,6 +132,7 @@ config ARC_CACHE_LINE_SHIFT
 
 choice
        prompt "Target select"
+       optional
 
 config TARGET_DUMMY
        bool "Dummy target"

You do not need to add "optional" to the ARC board select because Alexey intentionally added TARGET_DUMMY to the top of the board select list.

This is another solution to not lose any CONFIG_BOARD_ by savedefconfig although I personally prefer this idea very much.

Quoted 9 lines

It looks like I'm not the only one suffering from that change. For UniPhier that issue was resolved by Masahiro with replacement of "optional" with explicit default option.

And probably that's the way we'll need to go for all other affected Kconfigs.

Still all proposals are more than welcome.

Alexey, you are not alone.

I am also opposed to "optional" in SoC/board select menu.

Maybe, we should choose a reasonable default in each select menu? (or simply choose the first choice in the menu?)

I posted two patches:
http://patchwork.ozlabs.org/patch/502793/
http://patchwork.ozlabs.org/patch/502794/

I hope these two are not bad choice.

Signature · 2 lines
Best Regards
Masahiro Yamada