Skip to contentSkip to conversation

Patch "[media] s5h1420: fix a buffer overflow when checking userspace params" has been added to the 4.1-stable tree

PATCH [email protected] 1 participant 1 message Jul 30, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

[media] s5h1420: fix a buffer overflow when checking userspace params

to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
s5h1420-fix-a-buffer-overflow-when-checking-userspace-params.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 12f4543f5d6811f864e6c4952eb27253c7466c02 Mon Sep 17 00:00:00 2001

From: Mauro Carvalho Chehab <[email protected]>
Date: Tue, 28 Apr 2015 18:34:40 -0300
Subject: [media] s5h1420: fix a buffer overflow when checking userspace params

From: Mauro Carvalho Chehab <[email protected]>

commit 12f4543f5d6811f864e6c4952eb27253c7466c02 upstream.

The maximum size for a DiSEqC command is 6, according to the userspace API. However, the code allows to write up to 7 values:

	drivers/media/dvb-frontends/s5h1420.c:193 s5h1420_send_master_cmd() error: buffer overflow 'cmd->msg' 6 <= 7
---
 drivers/media/dvb-frontends/s5h1420.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/dvb-frontends/s5h1420.c +1 -1
@@ -180,7 +180,7 @@ static int s5h1420_send_master_cmd (stru
 	int result = 0;
 
 	dprintk("enter %s\n", __func__);
-	if (cmd->msg_len > 8)
+	if (cmd->msg_len > sizeof(cmd->msg))
 		return -EINVAL;
 
 	/* setup for DISEQC */

Patches currently in stable-queue which might be from [email protected] are

queue-4.1/media-fix-regression-in-some-more-dib0700-based-devices.patch queue-4.1/cx24116-fix-a-buffer-overflow-when-checking-userspace-params.patch queue-4.1/saa7164-fix-querycap-warning.patch queue-4.1/vb2-don-t-warn-when-v4l2_buffer.bytesused-is-0-for-multiplanar-buffers.patch queue-4.1/s5h1420-fix-a-buffer-overflow-when-checking-userspace-params.patch queue-4.1/rc-core-fix-dib0700-scancode-generation-for-rc5.patch queue-4.1/cx24117-fix-a-buffer-overflow-when-checking-userspace-params.patch queue-4.1/af9013-don-t-accept-invalid-bandwidth.patch queue-4.1/cx18-add-missing-caps-for-the-pcm-video-device.patch