Skip to contentSkip to conversation

Patch "ext4: call sync_blockdev() before invalidate_bdev() in put_super()" has been added to the 3.14-stable tree

PATCH [email protected] 1 participant 1 message Jul 30, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ext4: call sync_blockdev() before invalidate_bdev() in put_super()

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ext4-call-sync_blockdev-before-invalidate_bdev-in-put_super.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 89d96a6f8e6491f24fc8f99fd6ae66820e85c6c1 Mon Sep 17 00:00:00 2001

From: Theodore Ts'o <[email protected]>
Date: Sat, 20 Jun 2015 22:50:33 -0400
Subject: ext4: call sync_blockdev() before invalidate_bdev() in put_super()

From: Theodore Ts'o <[email protected]>

commit 89d96a6f8e6491f24fc8f99fd6ae66820e85c6c1 upstream.

Normally all of the buffers will have been forced out to disk before we call invalidate_bdev(), but there will be some cases, where a file system operation was aborted due to an ext4_error(), where there may still be some dirty buffers in the buffer cache for the device. So try to force them out to memory before calling invalidate_bdev().

This fixes a warning triggered by generic/081:

WARNING: CPU: 1 PID: 3473 at /usr/projects/linux/ext4/fs/block_dev.c:56 __blkdev_put+0xb5/0x16f()
---
 fs/ext4/super.c |    1 +
 1 file changed, 1 insertion(+)
fs/ext4/super.c +1 -0
@@ -832,6 +832,7 @@ static void ext4_put_super(struct super_
 		dump_orphan_list(sb, sbi);
 	J_ASSERT(list_empty(&sbi->s_orphan));
 
+	sync_blockdev(sb->s_bdev);
 	invalidate_bdev(sb->s_bdev);
 	if (sbi->journal_bdev && sbi->journal_bdev != sb->s_bdev) {
 		/*

Patches currently in stable-queue which might be from [email protected] are

queue-3.14/ext4-correctly-migrate-a-file-with-a-hole-at-the-beginning.patch queue-3.14/jbd2-fix-ocfs2-corrupt-when-updating-journal-superblock-fails.patch queue-3.14/ext4-be-more-strict-when-migrating-to-non-extent-based-file.patch queue-3.14/jbd2-use-gfp_nofs-in-jbd2_cleanup_journal_tail.patch queue-3.14/ext4-replace-open-coded-nofail-allocation-in-ext4_free_blocks.patch queue-3.14/ext4-don-t-retry-file-block-mapping-on-bigalloc-fs-with-non-extent-file.patch queue-3.14/ext4-call-sync_blockdev-before-invalidate_bdev-in-put_super.patch queue-3.14/ext4-fix-race-between-truncate-and-__ext4_journalled_writepage.patch queue-3.14/ext4-fix-reservation-release-on-invalidatepage-for-delalloc-fs.patch