Skip to contentSkip to conversation

Patch "phy: twl4030-usb: remove incorrect pm_runtime_get_sync() in probe function." has been added to the 4.1-stable tree

PATCH [email protected] 1 participant 1 message Jul 30, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

phy: twl4030-usb: remove incorrect pm_runtime_get_sync() in probe function.

to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
phy-twl4030-usb-remove-incorrect-pm_runtime_get_sync-in-probe-function.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 4724e27114c4a7eceeee07db227a17fcab6f165c Mon Sep 17 00:00:00 2001

From: NeilBrown <[email protected]>
Date: Thu, 16 Apr 2015 18:03:04 +1000
Subject: phy: twl4030-usb: remove incorrect pm_runtime_get_sync() in probe function.

From: NeilBrown <[email protected]>

commit 4724e27114c4a7eceeee07db227a17fcab6f165c upstream.

The USB phy should initialize with power-off, and will be powered on by the USB system when a cable connection is detected.

Having this pm_runtime_get_sync() during probe causes the phy to *always* be powered on.
Removing it returns to sensible power management.

Fixes 96be39ab34b77c6f6f5cd6ae03aac6c6449ee5c4
---
 drivers/phy/phy-twl4030-usb.c |    1 -
 1 file changed, 1 deletion(-)
drivers/phy/phy-twl4030-usb.c +0 -1
@@ -711,7 +711,6 @@ static int twl4030_usb_probe(struct plat
 	pm_runtime_use_autosuspend(&pdev->dev);
 	pm_runtime_set_autosuspend_delay(&pdev->dev, 2000);
 	pm_runtime_enable(&pdev->dev);
-	pm_runtime_get_sync(&pdev->dev);
 
 	/* Our job is to use irqs and status from the power module
 	 * to keep the transceiver disabled when nothing's connected.

Patches currently in stable-queue which might be from [email protected] are

queue-4.1/phy-twl4030-usb-remove-incorrect-pm_runtime_get_sync-in-probe-function.patch