Skip to contentSkip to conversation

Patch "vTPM: set virtual device before passing to ibmvtpm_reset_crq" has been added to the 3.10-stable tree

PATCH [email protected] 1 participant 1 message Jul 30, 2015

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

vTPM: set virtual device before passing to ibmvtpm_reset_crq

to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
vtpm-set-virtual-device-before-passing-to-ibmvtpm_reset_crq.patch
and it can be found in the queue-3.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 9d75f08946e8485109458ccf16f714697c207f41 Mon Sep 17 00:00:00 2001

From: "Hon Ching \\(Vicky\\) Lo" <[email protected]>
Date: Fri, 22 May 2015 13:23:02 -0400
Subject: vTPM: set virtual device before passing to ibmvtpm_reset_crq

From: "Hon Ching \\(Vicky\\) Lo" <[email protected]>

commit 9d75f08946e8485109458ccf16f714697c207f41 upstream.

tpm_ibmvtpm_probe() calls ibmvtpm_reset_crq(ibmvtpm) without having yet set the virtual device in the ibmvtpm structure. So in ibmvtpm_reset_crq, the phype call contains empty unit addresses, ibmvtpm->vdev->unit_address.

Fixes 132f76294744 ("drivers/char/tpm: Add new device driver to support IBM vTPM")
---
 drivers/char/tpm/tpm_ibmvtpm.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/char/tpm/tpm_ibmvtpm.c +3 -2
@@ -618,6 +618,9 @@ static int tpm_ibmvtpm_probe(struct vio_
 		goto cleanup;
 	}
 
+	ibmvtpm->dev = dev;
+	ibmvtpm->vdev = vio_dev;
+
 	crq_q = &ibmvtpm->crq_queue;
 	crq_q->crq_addr = (struct ibmvtpm_crq *)get_zeroed_page(GFP_KERNEL);
 	if (!crq_q->crq_addr) {
@@ -662,8 +665,6 @@ static int tpm_ibmvtpm_probe(struct vio_
 
 	crq_q->index = 0;
 
-	ibmvtpm->dev = dev;
-	ibmvtpm->vdev = vio_dev;
 	TPM_VPRIV(chip) = (void *)ibmvtpm;
 
 	spin_lock_init(&ibmvtpm->rtce_lock);

Patches currently in stable-queue which might be from [email protected] are

queue-3.10/vtpm-set-virtual-device-before-passing-to-ibmvtpm_reset_crq.patch