drm/i915: read bpp from vbt only for older panels
Subsystems (2)
PATCH 1/1 drm/i915: read bpp from vbt only for older panels
From: "Thulasimani,Sivakumar" <[email protected]>
BPP bits defined in VBT should be used only on panels whose edid version is 1.3 or older. EDID version 1.4 introduced offsets where bpp is defined and read into display_info, hence bpp from VBT will be used only when bpc in display_info is zero.
v2: use display_info.bpc for deciding when to use vbt_bpp (Jani)
--- drivers/gpu/drm/i915/intel_dp.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_dp.c +4 -1
@@ -1409,7 +1409,10 @@ intel_dp_compute_config(struct intel_encoder *encoder,* bpc in between. */ bpp = pipe_config->pipe_bpp;if (is_edp (intel_dp)) { -if (dev_priv->vbt.edp_bpp && dev_priv->vbt.edp_bpp < bpp) { + +/* Get bpp from vbt only for panels that dont have bpp in edid */ +if (intel_connector->base.display_info.bpc ==0 && + (dev_priv->vbt.edp_bpp && dev_priv->vbt.edp_bpp < bpp)) {DRM_DEBUG_KMS ("clamping bpp for eDP panel to BIOS-provided %i\n" , dev_priv->vbt.edp_bpp); bpp = dev_priv->vbt.edp_bpp;
Signature · 6 lines
1.7.9.5 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 19 lines · Sivakumar Thulasimani
From: "Thulasimani,Sivakumar" <[email protected]>
BPP bits defined in VBT should be used only on panels whose edid version is 1.3 or older. EDID version 1.4 introduced offsets where bpp is defined and read into
display_info, hence bpp from VBT will be used only when bpc indisplay_infois zero.v2: use display_info.bpc for deciding when to use
vbt_bpp(Jani)Signed-off-by Sivakumar Thulasimani <[email protected]>--- drivers/gpu/drm/i915/intel_dp.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dp.c +0
-0
drivers/gpu/drm/i915/intel_dp.c intel_dp_compute_config(struct intel_encoder *encoder, · line 1415
Quoted 8 lines
drivers/gpu/drm/i915/intel_dp.c +4
-1@@ -1409,7 +1409,10 @@ intel_dp_compute_config(struct intel_encoder *encoder,* bpc in between. */ bpp = pipe_config->pipe_bpp;if (is_edp (intel_dp)) { -if (dev_priv->vbt.edp_bpp && dev_priv->vbt.edp_bpp < bpp) { + +/* Get bpp from vbt only for panels that dont have bpp in edid */ +if (intel_connector->base.display_info.bpc ==0 && + (dev_priv->vbt.edp_bpp && dev_priv->vbt.edp_bpp < bpp)) {
The indentation seems wrong here, otherwise
Quoted 6 lines
drivers/gpu/drm/i915/intel_dp.c +0
-0DRM_DEBUG_KMS ("clamping bpp for eDP panel to BIOS-provided %i\n" , dev_priv->vbt.edp_bpp); bpp = dev_priv->vbt.edp_bpp;Signature · 1 line
1.7.9.5
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx