Patch "fixing infinite OPEN loop in 4.0 stateid recovery" has been added to the 3.14-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
fixing infinite OPEN loop in 4.0 stateid recovery
to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
fixing-infinite-open-loop-in-4.0-stateid-recovery.patch
and it can be found in the queue-3.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
e8d975e73e5fa05f983fbf2723120edcf68e0b38Mon Sep 17 00:00:00 2001
From: Olga Kornievskaia <[email protected]>
Date: Fri, 15 May 2015 11:45:31 -0400
Subject: fixing infinite OPEN loop in 4.0 stateid recovery
From: Olga Kornievskaia <[email protected]>
commit e8d975e73e5fa05f983fbf2723120edcf68e0b38 upstream.
Problem: When an operation like WRITE receives a BAD_STATEID, even though recovery code clears the RECLAIM_NOGRACE recovery flag before recovering the open state, because of clearing delegation state for the associated inode, nfs_inode_find_state_and_recover() gets called and it makes the same state with RECLAIM_NOGRACE flag again. As a results, when we restart looking over the open states, we end up in the infinite loop instead of breaking out in the next test of state flags.
Solution: unset the RECLAIM_NOGRACE set because of
calling of nfs_inode_find_state_and_recover() after returning from calling recover_open() function.
--- fs/nfs/nfs4state.c | 2 ++ 1 file changed, 2 insertions(+)
fs/nfs/nfs4state.c +2 -0
@@ -1482,6 +1482,8 @@ restart:spin_unlock (&state->state_lock); }nfs4_put_open_state (state); +clear_bit (NFS4CLNT_RECLAIM_NOGRACE , + &state->flags);spin_lock (&sp->so_lock); goto restart; }
Patches currently in stable-queue which might be from [email protected] are
queue-3.14/fixing-infinite-open-loop-in-4.0-stateid-recovery.patch