Skip to contentSkip to conversation

Patch "rbd: use GFP_NOIO in rbd_obj_request_create()" has been added to the 4.1-stable tree

PATCH [email protected] 1 participant 1 message Jul 31, 2015

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

rbd: use GFP_NOIO in rbd_obj_request_create()

to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
rbd-use-gfp_noio-in-rbd_obj_request_create.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 5a60e87603c4c533492c515b7f62578189b03c9c Mon Sep 17 00:00:00 2001

From: Ilya Dryomov <[email protected]>
Date: Wed, 24 Jun 2015 17:24:33 +0300
Subject: rbd: use GFP_NOIO in rbd_obj_request_create()

From: Ilya Dryomov <[email protected]>

commit 5a60e87603c4c533492c515b7f62578189b03c9c upstream.

rbd_obj_request_create() is called on the main I/O path, so we need to use GFP_NOIO to make sure allocation doesn't blow back on us. Not all callers need this, but I'm still hardcoding the flag inside rather than making it a parameter because a) this is going to stable, and b) those callers shouldn't really use rbd_obj_request_create() and will be fixed in the future.

More memory allocation fixes will follow.

---
 drivers/block/rbd.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/block/rbd.c +2 -2
@@ -2001,11 +2001,11 @@ static struct rbd_obj_request *rbd_obj_r
 	rbd_assert(obj_request_type_valid(type));
 
 	size = strlen(object_name) + 1;
-	name = kmalloc(size, GFP_KERNEL);
+	name = kmalloc(size, GFP_NOIO);
 	if (!name)
 		return NULL;
 
-	obj_request = kmem_cache_zalloc(rbd_obj_request_cache, GFP_KERNEL);
+	obj_request = kmem_cache_zalloc(rbd_obj_request_cache, GFP_NOIO);
 	if (!obj_request) {
 		kfree(name);
 		return NULL;

Patches currently in stable-queue which might be from [email protected] are

queue-4.1/crush-fix-a-bug-in-tree-bucket-decode.patch queue-4.1/rbd-use-gfp_noio-in-rbd_obj_request_create.patch